[GitHub] cordova-docs pull request #713: CB-12980: (iOS) Improve instruction and add ...

[sudotamm]

Github user sudotamm closed the pull request at:

https://github.com/apache/cordova-docs/pull/713


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #713: CB-12980: (iOS) Improve instruction and add ...

[shazron]

Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/713#discussion_r129762417
  
--- Diff: www/docs/en/dev/guide/platforms/ios/webview.md ---
@@ -220,5 +222,16 @@ After using either of these two methods, continue with 
the **"Using CDVViewContr
 */
 viewController.wwwFolderName = @"myfolder";
 viewController.startPage = @"mypage.html"
-```
+    ```
+## Adding Plugins files used in you cordova project
--- End diff --

It's just that you skipped over all the parts of how they get the plugin 
source in the first place. That part is missing, since your steps assume a CLI 
workflow (assuming a Plugins folder and such).

In a CLI workflow, they just do "cordova plugin add". In an embedded 
webview workflow, how do they get it in without the CLI? This is the thing we 
haven't solved yet. By the way, just adding plugin source does not solve the 
problem totally, they have to add entries in config.xml, etc. It is not a 
trivial problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #713: CB-12980: (iOS) Improve instruction and add ...

[sudotamm]

Github user sudotamm commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/713#discussion_r128179344
  
--- Diff: www/docs/en/dev/guide/platforms/ios/webview.md ---
@@ -220,5 +222,16 @@ After using either of these two methods, continue with 
the **"Using CDVViewContr
 */
 viewController.wwwFolderName = @"myfolder";
 viewController.startPage = @"mypage.html"
-```
+    ```
+## Adding Plugins files used in you cordova project
--- End diff --

When user want to integrate cordova project which used plugins in xcode 
project.  They also need to add source code of these plugins into their xcode 
project. Otherwise plugins will not work when use cordova  CDVViewController in 
xcode  project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #713: CB-12980: (iOS) Improve instruction and add ...

[shazron]

Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/713#discussion_r126568456
  
--- Diff: www/docs/en/dev/guide/platforms/ios/webview.md ---
@@ -220,5 +222,16 @@ After using either of these two methods, continue with 
the **"Using CDVViewContr
 */
 viewController.wwwFolderName = @"myfolder";
 viewController.startPage = @"mypage.html"
-```
+    ```
+## Adding Plugins files used in you cordova project
--- End diff --

I'm not sure I agree with this section. This assumes that they already have 
a Cordova app. This whole section is for adding Cordova to an existing Xcode 
project, without needing cordova-cli and its tools. Granted a Cordova app 
without plugins is useless, but there is no workflow on how to do that, from 
start to finish. PhoneGap itself has instructions on how to do that: 
http://docs.phonegap.com/tutorials/develop/1-embed-webview/ios/ but that's 
packaging up the core plugins into Cocoapods (with a fixed config.xml). 

A generalized plugin add solution for an Embedded Webview workflow has not 
been implemented yet although we have discussed it (with no satisfactory 
conclusion).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #713: CB-12980: (iOS) Improve instruction and add ...

[sudotamm]

GitHub user sudotamm opened a pull request:

https://github.com/apache/cordova-docs/pull/713

CB-12980: (iOS) Improve instruction and add detail steps for plugins in 
cordova project.

1. Embed dynamic binaries for Cordova.framework for xcode 8.3.2
2. Add step to show how to integrate plugins in xcode which used in cordova 
project.



### Platforms affected
Embed cordova in ios native app documentation only.

### What does this PR do?
Improve instruction and add detail steps for plugins in cordova project.

### What testing has been done on this change?
N/A

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sudotamm/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/713.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #713


commit 341f5455c7db01a1b6622835a3442f170cd2ca71
Author: Ryan 
Date:   2017-07-03T02:12:06Z

Update webview

1. Embed dynamic binaries for Cordova.framework for xcode 8.3.2
2. Add step to show how to integrate plugins in xcode which used in cordova 
project.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org