[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/149 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r141135727
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB";
},
"scripts": {
+"eslint": "eslint src test",
--- End diff --
If I do `npm run eslint pkg/`, it will reveal all of the pkg/ errors. I can
reduce some errors using --fix (mostly indenting errors) but the rest would
have to be fixed manually. I won't be able to change/fix anything, however,
unless I can check in the pkg/ directory though. If I run `npm run eslint`
without specifying pkg, it will just ignore it. Hmm...
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r141133636
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB";
},
"scripts": {
+"eslint": "eslint src test",
--- End diff --
we want to keep `pkg` in `.gitignore`. What happens if we run `eslint` on a
folder that doesn't exist?
We need to figure out how to fix those errors. Grr. I can take a look with
you. Manually fixing those errors is not an option. Are they all fixable with
`eslint --fix`?
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r141107663
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB";
},
"scripts": {
+"eslint": "eslint src test",
--- End diff --
But yes running eslint on pkg results in many errors. Mostly indentation
errors.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r141106590
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB";
},
"scripts": {
+"eslint": "eslint src test",
--- End diff --
Hmm so if we add in pkg here, there may be an issue because pkg is in the
.gitignore. Should I remove pkg from .gitignore so eslint can test it?
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r140927739
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB";
},
"scripts": {
+"eslint": "eslint src test",
"test": "grunt test",
--- End diff --
can you add `npm run eslint` to the test script here
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r140927689
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB";
},
"scripts": {
+"eslint": "eslint src test",
--- End diff --
can you also get it to run on `pkg`
`"eslint src test pkg"`
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-js/pull/149 CB-12895 : added eslint to repo ### Platforms affected ### What does this PR do? Added eslint to repo ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-js CB-12895-eslint Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/149.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #149 commit b26580bf5cf4705c19ee00783f462e8fc4d3c958 Author: Audrey So Date: 2017-09-25T21:06:08Z CB-12895 : added eslint to repo --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
