[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/219 Regarding the AppVeyor CI error - try closing then re-opening this PR again to trigger the CI. I'm thinking perhaps another rebase is in order first... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/219
I tried to manually apply the patch (add `.patch` to the url) and it didn't
apply.
```
$ git am < ~/Desktop/219.patch
Applying: CB-9033 : fix WatchKit support
.git/rebase-apply/patch:15: trailing whitespace.
var plist_file_entry = _.find(xcBuildConfiguration, function
(entry) {
.git/rebase-apply/patch:17: trailing whitespace.
{
error: patch failed: cordova-lib/src/plugman/platforms/ios.js:184
error: cordova-lib/src/plugman/platforms/ios.js: patch does not apply
Patch failed at 0001 CB-9033 : fix WatchKit support
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/219 Related: CB-9176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/219 Looking at it this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support
Github user eladmoshe commented on the issue: https://github.com/apache/cordova-lib/pull/219 @shazron I really wish this PR gets merged soon. Thanks @ogoguel for your contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support
Github user leouze commented on the issue: https://github.com/apache/cordova-lib/pull/219 +1 please look into this again. It is really painful and annoying to install plugins on apps with multiple targets. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support
Github user ogoguel commented on the issue: https://github.com/apache/cordova-lib/pull/219 +1 Still hoping to have that code validated :) Updated the PR that was almost one year old! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support
Github user tabrindle commented on the issue: https://github.com/apache/cordova-lib/pull/219 Can we look into this again? Being able to handle multiple targets is more important now that other application extensions like for messages are being used. Currently any time we install a plugin, it is going to our messages app extension target. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
