[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...
Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/561 Your experience going through the integration tests in here is valuable with respect to understanding what code these tests exercise, so armed with that knowledge, I think you have the right context to add unit tests for that code (and instead, delete the integration tests relevant to that code). As for whether it's in this PR or a separate one, your call. There will probably end up being extraneous commits in this PR. I would probably issue a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/561 @filmaj I rebased this for now. If we change the tests to unit tests, should it be in this PR or in a separate one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...
Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/561 Couple things in this one: 1. This will need a rebase with the latest. 2. I wonder if instead of putting more efforts into tweaking the fixtures and integration tests, we put more effort into converting the integration tests into unit tests wherever it makes sense. Let me know what you think @audreyso. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/561 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=h1) Report > Merging [#561](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/aafe7c773614b09dadcf9efd041a2663d1d7b555?src=pr=desc) will **decrease** coverage by `1.77%`. > The diff coverage is `81.25%`. [](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=tree) ```diff @@Coverage Diff @@ ## master #561 +/- ## == - Coverage 80.12% 78.35% -1.78% == Files 57 57 Lines3960 3964 +4 Branches 832 833 +1 == - Hits 3173 3106 -67 - Misses787 858 +71 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=tree) | Coverage Π| | |---|---|---| | [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | `96.03% <81.25%> (-0.34%)` | :arrow_down: | | [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=) | `71.31% <0%> (-20.16%)` | :arrow_down: | | [cordova-lib/src/plugman/platforms/common.js](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2NvbW1vbi5qcw==) | `69.47% <0%> (-14.74%)` | :arrow_down: | | [cordova-lib/src/cordova/metadata/browser\_parser.js](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvbWV0YWRhdGEvYnJvd3Nlcl9wYXJzZXIuanM=) | `83.72% <0%> (-13.96%)` | :arrow_down: | | [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `75.53% <0%> (+0.47%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=footer). Last update [aafe7c7...e9767d0](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
