[GitHub] cordova-lib issue #565: Platform's spec is ignored in config.xml if package....

2017-06-21 Thread filmaj
Github user filmaj commented on the issue:

https://github.com/apache/cordova-lib/pull/565
  
+1 to creating a new issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #565: Platform's spec is ignored in config.xml if package....

2017-06-21 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-lib/pull/565
  
@filmaj, thanks for the information. I'm looking forward to getting back 
working CI.
Also, I think that I should create a new issue for this bug. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #565: Platform's spec is ignored in config.xml if package....

2017-06-21 Thread filmaj
Github user filmaj commented on the issue:

https://github.com/apache/cordova-lib/pull/565
  
Yeah, this is a really important change.

One thing to note: all the tests in cordova-lib are failing right now 
because @stevengill, @audreyso and I are working on changing the tests from 
being very I/O heavy (integration tests) to lighter unit tests. I should have 
PR up today to share that will at least get CI back to passing. I will make 
sure to tag you in that PR, @matrosov-nikita, so you're aware when it drops and 
can review. The changes will be *big*.

Once we clean master up and get tests passing again here, we should look at 
incorporating this change (and also ensuring we update the new unit tests to 
reflect the changes).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org