[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-lib/pull/385#issuecomment-184180642
  
Added [CB-10616 Cover browserify scenario with 
tests](https://issues.apache.org/jira/browse/CB-10616).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/385


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-lib/pull/385

CB-10584 Splashscreen plugin crashes the app on windows 10 when built…

… with browserify

[Jira issue](https://issues.apache.org/jira/browse/CB-10584)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10584

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/385.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #385


commit 52e072e9379b5ca82ea4d3fabd9dfde6f662aae4
Author: daserge 
Date:   2016-02-10T19:38:29Z

CB-10584 Splashscreen plugin crashes the app on windows 10 when built with 
browserify




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-lib/pull/385#issuecomment-182552066
  
@vladimir-kotikov, could you please review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-lib/pull/385#issuecomment-182551514
  
It was taking the old version from `legacy_exec` so `base.js` was not found.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/385#discussion_r52569334
  
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -106,7 +106,7 @@ module.exports = function doBrowserify (project, 
platformApi, pluginInfoProvider
 commitId = cId;
 return getPlatformVersion(commitId, platformApi.root);
 }).then(function(platformVersion){
-var libraryRelease = bundle(platform, false, commitId, 
platformVersion);
+var libraryRelease = bundle(platform, false, commitId, 
platformVersion, wwwDir);
--- End diff --

Shouldn't we use `platform_www` directory here instead of `/www`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org