[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-03-24 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/522


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-03-24 Thread audreyso 
Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r107952809
  
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) {
 if (!expectedIdAndVersion) return;
 
 var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
-
-if (parsedSpec.id != pinfo.id) {
-var alias = parsedSpec.scope ? null : 
pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
--- End diff --

Made some updates! Let me know if there is anything else! Thank you! :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-03-23 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r107831849
  
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) {
 if (!expectedIdAndVersion) return;
 
 var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
-
-if (parsedSpec.id != pinfo.id) {
-var alias = parsedSpec.scope ? null : 
pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
--- End diff --

I know this is the opposite of what I told you before. My bad 😛 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-03-23 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r107829266
  
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) {
 if (!expectedIdAndVersion) return;
 
 var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
-
-if (parsedSpec.id != pinfo.id) {
-var alias = parsedSpec.scope ? null : 
pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
--- End diff --

for this section, can you get rid of lines 260-263 but keep line 262.

It should look like 
```
 if (parsedSpec.id != pinfo.id) {
throw new Error('Expected plugin to have ID "' + parsedSpec.id + '" but 
got "' + pinfo.id + '".');
}
```

That way, you can also undo your changes to 
cordova-lib/spec-plugman/fetch.spec.js. We should keep those tests I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-28 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r103528081
  
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
 var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
 
 if (parsedSpec.id != pinfo.id) {
-var alias = parsedSpec.scope ? null : 
pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
+var alias = null;
 if (alias !== pinfo.id) {
--- End diff --

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-28 Thread audreyso 
Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r103526011
  
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
 var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
 
 if (parsedSpec.id != pinfo.id) {
-var alias = parsedSpec.scope ? null : 
pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
+var alias = null;
 if (alias !== pinfo.id) {
--- End diff --

kk thanks! @stevengill  If you remove this code, there are tests that go 
with it and they will fail so I removed those in the next commit. How does this 
look? 
https://github.com/apache/cordova-lib/pull/522/commits/a29720e6d6b2378d9e342a5b1bb46bef1db17fa8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r103361780
  
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -165,14 +165,7 @@ module.exports.uninstallPlugin = function(id, 
plugins_dir, options) {
 deps.forEach(function (d) {
 var parsedSpec = pluginSpec.parse(d.id);
 deps_path = path.join(plugin_dir, '..', parsedSpec.id);
--- End diff --

don't need deps_path variable or parsedSpec anymore i think. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r103362278
  
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -342,13 +322,6 @@ function copyPlugin(pinfo, plugins_dir, link) {
 var dest = path.join(plugins_dir, pinfo.id);
 var altDest;
 
-//check if alternative id already exists in plugins directory
-if(pluginMapperotn[pinfo.id]) {
-altDest = path.join(plugins_dir, pluginMapperotn[pinfo.id]);
-} else if(pluginMappernto[pinfo.id]) {
-altDest = path.join(plugins_dir, pluginMappernto[pinfo.id]);
-}
-
 if(fs.existsSync(altDest)) {
--- End diff --

I think altDest doesn't need to exist anymore


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r103360880
  
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -221,7 +221,7 @@ describe('install', function() {
 });
 });
 
-it('Test 006 : should call fetch and convert oldID to newID', 
function(done) {
+xit('Test 006 : should call fetch and convert oldID to newID', 
function(done) {
--- End diff --

yup


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r103362438
  
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
 var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
 
 if (parsedSpec.id != pinfo.id) {
-var alias = parsedSpec.scope ? null : 
pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
+var alias = null;
 if (alias !== pinfo.id) {
--- End diff --

delete this if + alias


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread audreyso 
Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r103343073
  
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -221,7 +221,7 @@ describe('install', function() {
 });
 });
 
-it('Test 006 : should call fetch and convert oldID to newID', 
function(done) {
+xit('Test 006 : should call fetch and convert oldID to newID', 
function(done) {
--- End diff --

 I don't think this test is needed any more??


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread audreyso 
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/522

CB-12016 : removes pluginId mapping



### Platforms affected


### What does this PR do?

Removes pluginId mapping

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12016

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #522


commit 787913cdc8080de201faae93dc17f810b53eb1f5
Author: Audrey So 
Date:   2017-02-24T18:59:56Z

CB-12016 : removed pluginMapper code from uninstall

commit 5272c964da85ae4d3b3a2d3ec9e30399d89cb68a
Author: Audrey So 
Date:   2017-02-24T19:18:52Z

CB-12016 : removed mapping code from install.js

commit ee485815de266157cfafa65fb8febb27506bed97
Author: Audrey So 
Date:   2017-02-24T22:30:22Z

CB-12016 : removed mapper code from plugin.js

commit 3d26f495bfd9790f2292fdb28dd84b8e1e2adf37
Author: Audrey So 
Date:   2017-02-24T23:59:43Z

CB-12016 : removed plugin mapping from fetch




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org