[GitHub] cordova-lib pull request #570: CB-12361 : updated cordova-lib addHelper.spec...

[audreyso]

Github user audreyso closed the pull request at:

https://github.com/apache/cordova-lib/pull/570


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #570: CB-12361 : updated cordova-lib addHelper.spec...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/570

CB-12361 : updated cordova-lib addHelper.spec tests

Not ready to be merged/reviewed yet! Thank you!



### Platforms affected


### What does this PR do?
Updated cordova-lib addHelper.spec tests.

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12361-5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/570.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #570


commit 494f5e9749fcdb82b4c7052c413e2bc4af494d7a
Author: filmaj 
Date:   2017-06-16T23:07:13Z

Filling out more addHelper specs.

commit 34e4a00aec170741fea2a744eb089fa36100867b
Author: filmaj 
Date:   2017-06-16T23:31:40Z

finished laying out pending specs for main addhelper function.

commit fa4d7c59c2069540080450362f9cd6b7c7e6e484
Author: filmaj 
Date:   2017-06-17T00:00:58Z

further pending tests and some todos.

commit ba6702c88f09497b6ee5eb0e2564fdb5a3478153
Author: filmaj 
Date:   2017-06-19T13:56:00Z

already have tests for checking targets passed in to platform-add lined up 
elsewhere.

commit ab8cd73e1810eb241caa6ac595f25c7bb42101c2
Author: filmaj 
Date:   2017-06-19T14:33:05Z

filled out a few tests, more comments to describe testing approach.

commit 3dbc8073ab020b98059d0920793ac979dc1d8b60
Author: Audrey So 
Date:   2017-06-26T22:37:00Z

CB-12361 : updated addHelper tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org