[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Thanks for the PR and the quick responses! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/262/commits/c3d7e55ad428bd154fa6bf5bcd38ee53b152) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/175/) 316 tests run, 34 skipped, 1 failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...
Github user stalniy commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 @filmaj done! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 @stalniy I'm happy to merge this in, but can you rebase your branch with latest master first? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/262/commits/f4d4c8cd8903fbe1d80d9bd793b7105fed325ad1) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/174/) 316 tests run, 28 skipped, 0 failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...
Github user stalniy commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 @infil00p fixed. Sorry for the long fix. Could you please merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...
Github user stalniy commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Agree. "No Image Selected" is better. I will change this, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Based on what I'm seeing here, it really shouldn't say "Camera cancelled" because you're selecting an image from the gallery, not taking a picture. They both should say "Selection cancelled" or "No Image selected". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/262/commits/2bd0bedfb5ae3e8df935cc6b218f70c7a85cfed3) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/163/) 316 tests run, 28 skipped, 0 failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
