[GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...

[swbradshaw]

Github user swbradshaw commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-215291931
  
@morioma  - Take a look at #197 again. I completely rewrote the 
implementation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...

[morioma]

Github user morioma commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-207511327
  
I prefer this one to 
https://github.com/apache/cordova-plugin-camera/pull/197, because that one has 
code duplication for calculating rotation.
I am thinking getting rid of the ```getImageOrientation``` function all 
together and use the ```getRotatedBitmap``` from ```processResultFromCamera``` 
which based on the EXIF helper.

Additionally, the issue may not just for android 4.4. Latest Android 6.0.1 
on a Galaxy S6 edge suffers the same issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...

[fmiboy]

Github user fmiboy commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-179682916
  
Hello guys,
Currently I have image orientation correct when I use PNG type and on 
Android 4.4.4 but Android 5 orientation doesn't work at all.
Any idea when there will be fix?

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-176528759
  
Thanks for submitting a PR! The ALLMEDIA thing definitely sounds like a bug 
and your change there looks good.

However, I'm not 100% sure about the changes you made to 
`getImageOrientation()`. The issue is that when we get an image URI, it may or 
may not map to an actual file location depending on the application that 
provided the URI. For example, Google Photos can provide URIs that point to 
images in the cloud and not on the physical device. In this case, using the 
content resolver is the correct method for getting the orientation because the 
content resolver knows how to handle those situations. Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...

[horozco]

GitHub user horozco opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/158

[CB-10388] - Added correctOrientation support for android 4.4

Jira issue: https://issues.apache.org/jira/browse/CB-10388

- Currently If You pass the correctOrientation param as true, the 
sourceType as PHOTOLIBRARY or SAVEDPHOTOALBUM, the media type as ALLMEDIA and 
the selected file is an image the correctOrientation function is not being 
called. Also even if the function is called the code is not detecting the URI 
and doesn’t rotate the picture. These changes fixed both issues.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/horozco/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #158


commit e2823f48d632e12f89960fe83ebc90ba7d0a5a6a
Author: Hernan Orozco 
Date:   2016-01-21T21:02:11Z

[CB-10388] - Added correctOrientation support for android 4.4

- Currently If You pass the correctOrientation param as true, the
sourceType as PHOTOLIBRARY or SAVEDPHOTOALBUM, the media type as
ALLMEDIA and the selected file is an image the correctOrientation
function is not being called. Also even if the function is called the
code is not detecting the uri and doesn’t rotate the picture. These
changes fixed both issues.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org