[GitHub] cordova-plugin-contacts pull request: Making sure the photoCursor ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Making sure the photoCursor ...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/61#issuecomment-149217460 Tested, works fine. The JIRA issue: https://issues.apache.org/jira/browse/CB-9823 @gleerman, i'm going to merge this, but still want to ask you to file an Apache CLA as described here: http://www.apache.org/licenses/#clas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Making sure the photoCursor ...
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/61#issuecomment-122083722 This close() is missing! This pr should be merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Making sure the photoCursor ...
Github user recursion1122 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/61#issuecomment-104730019 This seems to occur with at least moderate consistency on Samsung Galaxy S5 devices running Android 5.x. I tested it on two different devices and both of them consistently crash and this error is thrown from at least one of the devices. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Making sure the photoCursor ...
GitHub user gleerman opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/61 Making sure the photoCursor is always closed You can merge this pull request into a Git repository by running: $ git pull https://github.com/gleerman/cordova-plugin-contacts bugfix/photocursor_close Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit 927025cb0a65dbd5d8dad2a7cb48a1a32ad4745f Author: Gaetan gaetan.leer...@gmail.com Date: 2015-05-04T13:19:36Z Making sure the photoCursor is always closed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Making sure the photoCursor ...
Github user rotem925 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/61#issuecomment-98825642 Yea, it fails for me too. Always, though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
