[GitHub] cordova-plugin-file-transfer pull request: Master

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/147
  
Please change the title of the pull request to something more meaningful. 
Rebase and squash all the commits and file a JIRA issue here talking about the 
feature and its purpose: https://issues.apache.org/jira/browse/CB/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Master

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/147
  
There are some test failures as `options` might be undefined: 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15/label=mac-slave,platformName=android/testReport/junit/cordova-plugin-file-transfer-tests.tests%20%3E%3E.FileTransfer.methods/download/filetransfer_spec_4_should_download_a_file/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Master

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/147#issuecomment-222163490
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/147/commits/b833cd3a84e1b097a260c9996fe8fd2d986cf5ab)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=windows-slave,platformName=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=windows-slave,platformName=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=windows-slave,platformName=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=windows-slave,platformName=windows-8.1-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=windows-slave,platformName=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=windows-slave,platformName=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=windows-slave,platformName=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=mac-slave,platformName=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=mac-slave,platformName=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=mac-slave,platformName=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=mac-slave,platformName=ios/artifact/)
 |
| [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=mac-slave,platformName=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=mac-slave,platformName=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=mac-slave,platformName=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15//label=mac-slave,platformName=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Master

[PaoloMessina]

Github user PaoloMessina commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/147#issuecomment-222150059
  
I'm not able with travis, and how it work on test.
Once installed the plugin work correctly, maybe can i fix something in 
thhis pull request to pass this test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Master

[PaoloMessina]

GitHub user PaoloMessina opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/147

Master

windows, android, ios new feature, download file in POST or GET and, if 
POST can passing data to server in json format.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PaoloMessina/cordova-plugin-file-transfer 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #147


commit 5607ee2e0ff8ca35e3d97e0fb4b8a2ce3f47f9fd
Author: Paolo Messina 
Date:   2016-05-16T13:33:22Z

ios - post feature

ios - post feature

commit 8fe113c9d76622da0a9726556f685c9c4cb0576c
Author: Paolo Messina 
Date:   2016-05-16T13:43:43Z

ios - cosmetic code change

ios - cosmetic code change

commit 6b6eeebcba74913d95d1f5682fdf9d9f1e249d6d
Author: Paolo Messina 
Date:   2016-05-16T14:42:40Z

Android - post feature

Android - post feature

commit b833cd3a84e1b097a260c9996fe8fd2d986cf5ab
Author: PaoloMessina 
Date:   2016-05-27T13:24:12Z

windows - postData to get file in post

windows - postData to get file in post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org