[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171461428
  
Looks like I'm seeing [this JIRA 
issue](https://issues.apache.org/jira/browse/CB-10338), which is preventing me 
from testing this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-geolocation/pull/66


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171495075
  
GPS randomly started working. I was able to test this properly after all on 
the device.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171492706
  
Okay, I feel confident that I've tested the code path. The above JIRA 
doesn't block the native code from executing, and I was able to step through 
the javascript to make sure it was returning correctly and see the permission 
request popup. I've tested this on cordova-android's master and cordova-android 
4.0.0 by running mobilespec auto and manual tests. Did so on a Marshmallow 
device (with the above JIRA note) and on a Lollipop emulator (that did not 
experience the JIRA issue). I'm going to merge this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171374468
  
@sgrebnov Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171207462
  
PS. Kudos to @riknoll for very good code documentation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171206449
  
Manual tests should be valid, I used them while testing (but I used only 
real devices while testing).
The code looks good so I'm going to verify it on real devices (w/ 
cordova-android@5.0 and pre-5.0) and merge later today


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171007189
  
Not sure testing this on an emulator is particularly useful. I have tests 
failing, but that might just be because it's an emulator. If I track down a 
physical lollipop device, I'll give this a shot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

[jasongin]

Github user jasongin commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171023399
  
The code looks good, I'm just a little concerned about testing.

@sgrebnov Since you've been working on the geolocation plugin recently, do 
you know anything about the state of the manual tests in mobilespec?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-geolocation/pull/66

CB-10319 android: Adding reflective helper methods for permission requests

Adds reflection helper class as was discussed on the mailing list. I ran 
the mobilespec auto tests with cordova-android's master branch and 
cordova-android 3.7.2 and seemed to get the same output as the vanilla 
mobilespec. I couldn't get the manual tests to work, so I did not run those. 
All tests were run on a nexus 6 running Marshmallow; I might do some extra 
testing on an emulator with a lower API level in a bit. @infil00p @jasongin 
please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation 
reflection

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-geolocation/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #66


commit 9420f405f64fded667eb8335fc9cddc2401d6ff3
Author: riknoll 
Date:   2016-01-11T19:06:37Z

CB-10319 android: Adding reflective helper methods for permission requests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org