[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 The code changes in iOS are delaying this. That being said, I don't know if blindly adding Application URIs in an InAppBrowser is a good idea in this case. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user Kaelink commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 That might be interesting for some of you but, while waiting for the pull to be merged, I found a fork that solved the issue here: https://github.com/Onegini/cordova-plugin-inappbrowser --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user wilsolutions commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 Hi, please, can we get this in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 From what I have read, it seems this is an Android problem -- so I'm not sure why the code changes in iOS are needed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 Attn: @shazron @infil00p --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user benbotto commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 Any plan on accepting this pull request? This issue is more than two years old now, and there's still an inconsistency between iOS and Android that needs to be worked around. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/99/commits/e36829ad7042d1dd389b4bc9af6b67c8b306c48e) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=windows-10-store/artifact/) | | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=ios-9.3/artifact/) | | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=ios-10.0/artifact/) | | [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=android-4.4/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=android-4.4/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=android-4.4/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=android-4.4/artifact/) | | [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=android-5.1/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=android-5.1/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=android-5.1/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/135//PLATFORM=android-5.1/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user steinwelberg commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 We merged the original master branch into our branch again to make it completely up-to-date. I see that there we introduced other changes which should maybe not be included into this pull request, If that is what is keeping it from being merged I'm happy to create a new pull request with just the changes required to make the in app browser trigger the intent to handle a custom app scheme. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user benbotto commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 Seconding @moneytree-doug's statement that this is important for OAuth, or any protocol that requires redirects back to the app. @ljcljc's fork corrects the problem, and we're using that in our Android builds. That version doesn't work correctly in iOS 10.2, however, so now we have custom builds for Android and iOS. Using InAppBrowser, Opening a URL with a custom scheme works fine in iOS. Please make it work in Android, too! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user moneytree-doug commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 @JPustkuchen For example, I forked off the library so to use it as a plugin for cordova then you would do this: ```cordova plugin add https://github.com/moneytree/cordova-plugin-inappbrowser.git``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user ljcljc commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 @JPustkuchen Sure. You can checkout my repository, which I forked from @osvso , using cordova to install it. [https://github.com/ljcljc/cordova-plugin-inappbrowser](url) This is his change to the original version. [https://github.com/apache/cordova-plugin-inappbrowser/pull/99/commits/01968d06004645fb6289d35c1ba31eb048c8620d](url) Then, you can launch custom scheme within inappbrowser, and that should work fine. No other configuration needed. Let me know if you have any questions using it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user ljcljc commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 @moneytree-doug I finally figure it out. It works great. No other configurations needed. @osvso Thanks for your excellent work! Save my day! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user ljcljc commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 @moneytree-doug Thanks for your reply. Could you explain in detail how it works? This is the link of @osvso [https://github.com/apache/cordova-plugin-inappbrowser/pull/99/commits/01968d06004645fb6289d35c1ba31eb048c8620d](url) And, do I need to specify 'CustomSchema' in config.xml? Or it works automatically without any further configuration? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user moneytree-doug commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 @ljcljc I used @osvso 's library and it worked. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user ljcljc commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 I have met with the same problem, has anyone fix this issue yet? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user moneytree-doug commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 I think this is an important feature for OAuth, has anyone figured out a work around? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
