[GitHub] cordova-plugin-inappbrowser pull request: Allow for navigateTo met...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/126#issuecomment-181561290
  
Yeah, this pull-request is invalid, even if the feature request makes 
sense, this does not do it.
please close!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Allow for navigateTo met...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/126#issuecomment-181525114
  
I think we should close this PR as this won't work on other platforms and 
you can also do the following:
```
ref.executeScript({code: 'location.href="http://some-page.html;'})
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Allow for navigateTo met...

[byrning]

Github user byrning closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/126


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Allow for navigateTo met...

[byrning]

GitHub user byrning opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/126

Allow for navigateTo method

Adding this method allows for one to navigate to another URL while the 
inappbrowser is already open.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/byrning/cordova-plugin-inappbrowser patch-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #126


commit 3289785f4a54e062668091521139533b5e31060e
Author: byrning 
Date:   2015-11-20T17:15:40Z

Allow for navigateTo method

Adding this method allows for one to navigate to another URL while the 
inappbrowser is already open.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Allow for navigateTo met...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/126#issuecomment-158486504
  
This will not work. There would need to be a native implementation to back 
this, and it would need to exist in all platforms.

Try this:
`var navigateTo = function(url) {
return cordova.InAppBrowser.open(url,'_blank');
};`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org