[GitHub] cordova-plugin-inappbrowser pull request: CB-10009 Improve InAppBr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/129


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10009 Improve InAppBr...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/129#issuecomment-170513142
  
Re-based on top of master and merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GitHub] cordova-plugin-inappbrowser pull request: CB-10009 Improve InAppBr...

[Jesse]

Great!
I don't know how those last buttons made it in, but they were UGLY!


@purplecabbage
risingj.com

On Mon, Jan 11, 2016 at 3:26 AM, sgrebnov  wrote:

> Github user sgrebnov commented on the pull request:
>
>
> https://github.com/apache/cordova-plugin-inappbrowser/pull/129#issuecomment-170513142
>
> Re-based on top of master and merged
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-inappbrowser pull request: CB-10009 Improve InAppBr...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/129#issuecomment-170176424
  
Looks like a good one to merge!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10009 Improve InAppBr...

[sgrebnov]

GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/129

CB-10009 Improve InAppBrowser toolbar look and feel on Windows

https://issues.apache.org/jira/browse/CB-10009

Solution is based on `Segoe UI Symbol` which is available on all windows 
devices (tested) and contains required icons.

**Original version:**


![appbar-original](https://cloud.githubusercontent.com/assets/981580/11870489/5759ae40-a4d9-11e5-99ac-4464130edd07.png)

**Proposed:**


![appbar-disabled](https://cloud.githubusercontent.com/assets/981580/11870504/73fdbe06-a4d9-11e5-9d6b-b2ce2b4fe855.png)




![appbar-hower](https://cloud.githubusercontent.com/assets/981580/11870498/69f164c6-a4d9-11e5-8875-99d2c2cde7c4.png)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser 
CB-10009

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #129


commit af04bf439c897c8f40257d2215acbf31ee706b06
Author: sgrebnov 
Date:   2015-12-17T13:10:47Z

CB-10009 Improve InAppBrowser toolbar look and feel on Windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org