[GitHub] cordova-plugin-inappbrowser pull request: CB-10428 Fix syntax erro...

[sgrebnov]

GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/141

CB-10428 Fix syntax error when browserifying inAppBrowser plugin

https://issues.apache.org/jira/browse/CB-10428

Wrapped module in anonymous function

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser 
CB-10428

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #141


commit d3f56b7fd23dfdc9e283769af641007aeb2f0868
Author: sgrebnov 
Date:   2016-01-26T09:06:49Z

CB-10428 Fix syntax error when browserifying inAppBrowser plugin




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10428 Fix syntax erro...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/141#issuecomment-174916119
  
Use  `?w=1` param to ignore space changes:
https://github.com/apache/cordova-plugin-inappbrowser/pull/141/files?w=1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10428 Fix syntax erro...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/141


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10428 Fix syntax erro...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/141#issuecomment-175004173
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org