[GitHub] cordova-plugin-inappbrowser pull request: Fix syntax error when br...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/127#issuecomment-176041352
  
@alexbuijs thank you for proposed patch, but we can't remove this line as 
it is required for InAppBrowser to work correct when app is emulated using 
Ripple emulator. The problem has been fixed here: 
https://github.com/apache/cordova-plugin-inappbrowser/commit/2e0dc26eaa023e9d553a78c4acf25af751cc8021?w=1
Please consider closing this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Fix syntax error when br...

[alexbuijs]

Github user alexbuijs closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/127


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Fix syntax error when br...

[alexbuijs]

Github user alexbuijs commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/127#issuecomment-176042868
  
I understand, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Fix syntax error when br...

[alexbuijs]

GitHub user alexbuijs opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/127

Fix syntax error when browserifying

When browserifying this plugin, aliasify throws an error:
```
events.js:141
  throw er; // Unhandled 'error' event
  ^

SyntaxError: 'return' outside of function (25:4) (while aliasify was 
processing plugins/cordova-plugin-inappbrowser/www/inappbrowser.js) while 
parsing file: plugins/cordova-plugin-inappbrowser/www/inappbrowser.js
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alexbuijs/cordova-plugin-inappbrowser patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #127


commit 14f8e0e8c93bb57c22c39b575048effe9ac21041
Author: Alex Buijs 
Date:   2015-11-25T14:04:56Z

Fix syntax error when browserifying

When browserifying this plugin, aliasify throws an error:
```
events.js:141
  throw er; // Unhandled 'error' event
  ^

SyntaxError: 'return' outside of function (25:4) (while aliasify was 
processing plugins/cordova-plugin-inappbrowser/www/inappbrowser.js) while 
parsing file: plugins/cordova-plugin-inappbrowser/www/inappbrowser.js
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org