[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-163120168 @emarashliev, looks like the issue has been fixed in #47 - could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...
Github user solarsaturn9 commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-66492739 Additionally, CDV_IsIPad is deprecated and produces an error when building. Not sure how to report this seeing as how I don't know a good alternative solution to submit a pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-58969444 Sorry everyone but I had to do a major re-factor to support unit-testing the different configurations of splash screens (effectively over 200 plus tests in all). iPhone 6 support added in https://issues.apache.org/jira/browse/CB-7043 (items 47-53). Thanks for the PR and getting it going. This needs to be re-applied to the re-factored code if still applicable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-55661782 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47830696 Ah, I gotcha, It's because the shouldAutorotate selector has no setter in CDVViewController. @shazron - any opinion on this? with swizzling it will work with existing cordova-ios, but it would be easy to make a setter for shouldAutorotate settable, or alternatively make supportedOrientations public. I'm leaning towards accepting this as-is since it works and only swizzles a UIViewController selector. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...
Github user emarashliev commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47504184 Hi @agrieve, it's necessary because we have to disable auto rotation during the splash screen is shown. And then after splash screen is hidden we have to restore default auto rotation state. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
