[GitHub] cordova-windows pull request: CB-10193 Add BOM to www files at bui...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/134


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10193 Add BOM to www files at bui...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-windows/pull/134

CB-10193 Add BOM to www files at build stage instead of prepare

This PR moves adding BOM to JS files from prepare to build stage. This 
should fix the potential problem (as explained in [mailing list 
discussion](http://markmail.org/thread/cg5s2jvxvyyqcqpd)) when www files 
already contain BOM signatures at the time when 'after_prepare' hook ([or 
simulated 'pre_package' 
hook](https://github.com/apache/cordova-lib/commit/4478eaf0783a2f73962e5911a0c26cc4db1da241))
 is fired. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-10193

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #134


commit fda7cd19f6915d216b04ea93deb8d1dd9f0d2f29
Author: Vladimir Kotikov 
Date:   2015-12-12T09:02:38Z

CB-10193 Add BOM to www files at build stage instead of prepare




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10193 Add BOM to www files at bui...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/134#issuecomment-168987357
  
lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org