[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[biasmv]

Github user biasmv commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-184110837
  
That's fantastic! Thanks for merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/139


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-183633182
  
Tested and merged, @biasmv  Marco - thx for the patch!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-182766890
  
I'll test new version and merge later today


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[biasmv]

Github user biasmv commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-182249434
  
Hi,

just to follow up on this. I've changed the code to use relative paths. We 
have been using this version for a while for testing our plugin and it has been 
working really well. 

Is there anything to be done before this can be merged?

Best,
Marco




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[TimBarham]

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-177957240
  
I've taken a look too, and I agree this seems the best approach. Changes 
look good to me, except I agree with your comment @sgrebnov that we should use 
a relative path rather than absolute.

Regarding the red "x" on the folder name: this seems to be a limitation of 
a `jsproj` (that they don't fully support links, at least in the VS UI). If you 
create an equivalent link in a `csproj`, you don't get the red "x". If it 
indeed builds fine, then we can live with that.

However, there is one way we can avoid the red "x": actually create any 
folder defined in the `target` path (if there is one). It would be empty, but 
would make for less confusion in the VS UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[biasmv]

Github user biasmv commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-178005303
  
Thanks for taking a look! I agree that it would be better to use relative 
paths. At the moment, csproj files are also referenced using absolute paths, so 
one would have to convert them to relative paths, too before being able to move 
around the generated projects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-176733241
  
I've tried this approach and it seems to work very well. The only two 
things I've noticed are:
1. Generated `Include` is absolute, this could be a problem for remote 
build tools and when you move the app or send someone else. But I think this 
could be easily fixed.
```

x64/foo.dll
Always

```
2. Includes to files which are outside the VS project are showed like 
linked folder is missing so this may confuse people

![image](https://cloud.githubusercontent.com/assets/981580/12675912/d74da02a-c69e-11e5-871b-844b37729d8a.png)

But in general this works well and should simplify working with 
arch-specific native dependencies a lot. File is correctly placed in generated 
package so there should no be any runtime issues


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-176740857
  
Here is my +1, but it will be great if someone else can take a look on this 
change as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[biasmv]

Github user biasmv commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-175489700
  
Cool, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-175442601
  
Hi @biasmv - I'll take a look and respond today or tomorrow, thank you for 
clarification


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[biasmv]

Github user biasmv commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-174499126
  
@sgrebnov: I've verified that it's still possible to have files in non-root 
folder locations. I've inserted the following into my project (which is 
essentially what would be generated by resource-file with the patch):

```

   somesubdirectory/file.txt
   Always

```

The file is correctly placed in somesubdirectory and not the output 
directory root folder. So the patch does not prevent the resource element to be 
used that way.

The suggested use of the target attribute would still mean that the files 
land in different locations depending on the architecture. I'd need to change 
the C# library to somehow load the unmanaged dll from from a different 
location, depending on what device it's running on. I'd prefer if I could just 
copy the file with the correct architecture to the output directory without 
having to do any runtime checks.

Also, since I'm referencing the file from the appxmanifest as part of an 
extension (see the original ticket 
https://issues.apache.org/jira/browse/CB-10326), I'd need to change the path in 
the appxmanifest depending on the architecture currently being built. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-174453773
  
I like the idea, but I think we will miss `target` attribute support as 
resource-file will be always copied to root (pls correct me if I'm wrong). In 
some cases you will want to use `resource-file` to specify some asset which is 
available for the app in runtime (image/json/xml/etc).


https://cordova.apache.org/docs/en/dev/plugin_ref/spec.html#link-resource-file-and-header-file-elements

Also, I believe using target attribute you will be able to get it working, 
for example 

```



```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-174454890
  
@nikhilkh - looks like the doc describing `target` support on windows and 
corresponding example exist in dev version only.We should make it released.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-173989565
  
I don't completely understand why you are packaging '.dll' as a resource 
file? Can you explain your scenario?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[biasmv]

GitHub user biasmv opened a pull request:

https://github.com/apache/cordova-windows/pull/139

don't copy resource-files at plugin install

Instead, reference the file in the plugin directory. This allows to have 
multiple
source files map to the same destination file inside the build directory and
choose the appropriate file based on the build configuration, e.g. 
architecture.

This implements a fix for CB-10326

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/biasmv/cordova-windows master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit e3425d97fd6bdd23823ba5430dca780405e803f6
Author: Marco Biasini 
Date:   2016-01-18T10:24:29Z

don't copy resource-files at plugin install

Instead, reference the file in the plugin directory. This allows to have 
multiple
source files map to the same destination file inside the build directory and
choose the appropriate file based on the build configuration, e.g. 
architecture.

This implements a fix for CB-10326




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org