[GitHub] cordova-windows pull request #188: Fix issues where MSBuild cannot be found ...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/188#discussion_r71791061
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -93,6 +93,20 @@ module.exports.findAllAvailableVersions = function () {
 return !!item;
 });
 });
+}
+
+module.exports.findAllAvailableVersions = function () {
+// CB-11548 use VSINSTALLDIR environment if defined to find MSBuild. 
If VSINSTALLDIR
+// is not specified or incorrect - fall back to default discovery 
mechanism.
--- End diff --

It is quite likely that `VSINSTALLDIR` is specified and *correct*, but just 
doesn't contain the msbuild path we're looking for (this will be the case for 
previous versions of VS, for example). So I think it would be clearer to say 
here something like "not specified or doesn't contain the MSBuild path we are 
looking for".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #188: Fix issues where MSBuild cannot be found ...

[jicongw]

GitHub user jicongw opened a pull request:

https://github.com/apache/cordova-windows/pull/188

Fix issues where MSBuild cannot be found due to VS installation chang…

…e. Let Cordova Windows look for MSBuild under VSINSTALLDIR process 
environment variable. Also, make Cordova Windows more resilient to MSBuild 
version change. This commit contains work by Vladimir and Jason. Code is 
reviewed by Vladimir and Tim Barham. Commits are squashed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jicongw/cordova-windows CB-11548

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #188


commit b765a6adb40040a6fe3549b6fc8618233fe3e16d
Author: Jason Wang (DEVDIV) 
Date:   2016-07-21T20:47:49Z

Fix issues where MSBuild cannot be found due to VS installation change. Let 
Cordova Windows look for MSBuild under VSINSTALLDIR process environment 
variable. Also, make Cordova Windows more resilient to MSBuild version change. 
This commit contains work by Vladimir and Jason. Code is reviewed by Vladimir 
and Tim Barham. Commits are squashed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org