Re: [VOTE] Cordova-iOS 5.1.1 Release

2019-12-01 Thread Bryan Ellis
The vote has now closed. The results are:


Positive Binding Votes: 5

* Bryan Ellis

* Jesse MacFadyen

* Julio Cesar Sanchez

* Tim Brust
* Ken Naito


Negative Binding Votes: 0

Positive Non-Binding Votes: 1
* Niklas Merz

The vote has passed.


Thanks everyone!


On Mon, Dec 2, 2019 at 8:55 AM Ken Naito  wrote:

> +1
>
> * coho verify-archive OK
> * coho verify-tags OK
> * The last commit a5a009c4c882879901d55e04b596bc57fa84a8b4 is green.
>
> Ken.
>
>
> On 2019/11/29 2:25, Bryan Ellis wrote:
> > Please review and vote on this iOS Release v5.1.1
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1
> >
> > The package was published from its corresponding git tag:
> >  cordova-ios: 5.1.1 (86a87fed74)
> >
> > Note that you can test it out via:
> >
> >  cordova platform add https://github.com/apache/cordova-ios#5.1.1
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * NPM Tests
> > * Build Tests
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


Re: [VOTE] Cordova-iOS 5.1.1 Release

2019-12-01 Thread Ken Naito

+1

* coho verify-archive OK
* coho verify-tags OK
* The last commit a5a009c4c882879901d55e04b596bc57fa84a8b4 is green.

Ken.


On 2019/11/29 2:25, Bryan Ellis wrote:

Please review and vote on this iOS Release v5.1.1
by replying to this email (and keep discussion on the DISCUSS thread)

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1

The package was published from its corresponding git tag:
 cordova-ios: 5.1.1 (86a87fed74)

Note that you can test it out via:

 cordova platform add https://github.com/apache/cordova-ios#5.1.1

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* NPM Audit
* NPM Tests
* Build Tests




-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] Cordova-iOS 5.1.1 Release

2019-12-01 Thread Tim Brust
I vote +1:

- CI is green
- coho verify-archive
- I could successful add the platform with WKWebViewOnly enabled

On Thu, Nov 28, 2019 at 5:25 PM Bryan Ellis  wrote:

> Please review and vote on this iOS Release v5.1.1
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1
>
> The package was published from its corresponding git tag:
> cordova-ios: 5.1.1 (86a87fed74)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-ios#5.1.1
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * NPM Audit
> * NPM Tests
> * Build Tests
>


-- 
Tim Brust, Product Engineer

tim.br...@sinnerschrader.com
T +49 40 398855 315

SinnerSchrader Deutschland GmbH | SinnerSchrader Group
Völckersstraße 38, 22765 Hamburg, Germany

Amtsgericht Hamburg HRB-Nr. 63663
Geschäftsführer: Matthias Schrader (Sprecher),
Jürgen Alker, Dr. Axel Averdung, Holger Blank,
Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson

Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag

https://www.sinnerschrader.com | NEXT AGENCY


Re: [VOTE] Cordova-iOS 5.1.1 Release

2019-11-30 Thread julio cesar sanchez
I vote +1

ran npm test
ran npm audit
created an app with the new preference and ran it without problems

El sáb., 30 nov. 2019 a las 17:47, Jesse ()
escribió:

> +1
>
> - ci is green
> - coho verify-archive
> - ran tests locally, npm audit
>
> On Thu, Nov 28, 2019 at 11:46 PM Niklas Merz 
> wrote:
>
> > I vote +1 (non-binding)
> > * CI is greeen for tag
> > * Confirmed sigs & hashes with `coho verify-archive` [1]
> > * Verified sha1s match tags with `coho@nightly verify-tags`
> > * Created a new cordova project, added the platform and launched
> > successfully on iPhone
> >
> > - Ursprüngliche Nachricht -
> > Von: "Bryan Ellis" 
> > An: dev@cordova.apache.org
> > CC:
> > Betreff: [VOTE] Cordova-iOS 5.1.1 Release
> > Datum: Do, 28. Nov 2019 18:25
> >
> > Please review and vote on this iOS Release v5.1.1
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1
> >
> > The package was published from its corresponding git tag:
> > cordova-ios: 5.1.1 (86a87fed74)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-ios#5.1.1
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * NPM Tests
> > * Build Tests
> >
> >
> > Sitz der Gesellschaft: GEDYS IntraWare GmbH, Brückenmühle 93, 36100
> > Petersberg, Deutschland
> > Tel.: +49 661 9642-0 | Fax: +49 661 9642-99 | i...@gedys-intraware.de |
> > www.gedys-intraware.de
> > Registereintragung: Amtsgericht Fulda HRB 5156 | Ust.-ID: DE 188 682 194
> > gemäß Paragraph 27a UstG  | Geschäftsführung: Joachim Weber, Ralf
> > Geishauser, Frank Hohl
> > AGB | Impressum | Datenschutzbestimmungen
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: [VOTE] Cordova-iOS 5.1.1 Release

2019-11-30 Thread Jesse
+1

- ci is green
- coho verify-archive
- ran tests locally, npm audit

On Thu, Nov 28, 2019 at 11:46 PM Niklas Merz 
wrote:

> I vote +1 (non-binding)
> * CI is greeen for tag
> * Confirmed sigs & hashes with `coho verify-archive` [1]
> * Verified sha1s match tags with `coho@nightly verify-tags`
> * Created a new cordova project, added the platform and launched
> successfully on iPhone
>
> - Ursprüngliche Nachricht -
> Von: "Bryan Ellis" 
> An: dev@cordova.apache.org
> CC:
> Betreff: [VOTE] Cordova-iOS 5.1.1 Release
> Datum: Do, 28. Nov 2019 18:25
>
> Please review and vote on this iOS Release v5.1.1
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1
>
> The package was published from its corresponding git tag:
> cordova-ios: 5.1.1 (86a87fed74)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-ios#5.1.1
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * NPM Audit
> * NPM Tests
> * Build Tests
>
>
> Sitz der Gesellschaft: GEDYS IntraWare GmbH, Brückenmühle 93, 36100
> Petersberg, Deutschland
> Tel.: +49 661 9642-0 | Fax: +49 661 9642-99 | i...@gedys-intraware.de |
> www.gedys-intraware.de
> Registereintragung: Amtsgericht Fulda HRB 5156 | Ust.-ID: DE 188 682 194
> gemäß Paragraph 27a UstG  | Geschäftsführung: Joachim Weber, Ralf
> Geishauser, Frank Hohl
> AGB | Impressum | Datenschutzbestimmungen
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


RE: [VOTE] Cordova-iOS 5.1.1 Release

2019-11-28 Thread Niklas Merz
I vote +1 (non-binding)
* CI is greeen for tag
* Confirmed sigs & hashes with `coho verify-archive` [1]
* Verified sha1s match tags with `coho@nightly verify-tags`
* Created a new cordova project, added the platform and launched 
successfully on iPhone
 
- Ursprüngliche Nachricht -
Von: "Bryan Ellis" 
An: dev@cordova.apache.org
CC:
Betreff: [VOTE] Cordova-iOS 5.1.1 Release
Datum: Do, 28. Nov 2019 18:25
 
Please review and vote on this iOS Release v5.1.1
by replying to this email (and keep discussion on the DISCUSS thread)

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1

The package was published from its corresponding git tag:
cordova-ios: 5.1.1 (86a87fed74)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-ios#5.1.1

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* NPM Audit
* NPM Tests
* Build Tests
 

Sitz der Gesellschaft: GEDYS IntraWare GmbH, Brückenmühle 93, 36100 Petersberg, 
Deutschland
Tel.: +49 661 9642-0 | Fax: +49 661 9642-99 | i...@gedys-intraware.de | 
www.gedys-intraware.de
Registereintragung: Amtsgericht Fulda HRB 5156 | Ust.-ID: DE 188 682 194 gemäß 
Paragraph 27a UstG  | Geschäftsführung: Joachim Weber, Ralf Geishauser, Frank 
Hohl
AGB | Impressum | Datenschutzbestimmungen

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[VOTE] Cordova-iOS 5.1.1 Release

2019-11-28 Thread Bryan Ellis
Please review and vote on this iOS Release v5.1.1
by replying to this email (and keep discussion on the DISCUSS thread)

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1

The package was published from its corresponding git tag:
cordova-ios: 5.1.1 (86a87fed74)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-ios#5.1.1

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* NPM Audit
* NPM Tests
* Build Tests