Re: [VOTE] Splashscreen Plugin Release 5.0.4
The vote has now closed. The results are: Positive Binding Votes: 3 Niklas Merz Norman Breau Bryan Ellis Negative Binding Votes: 0 The vote has passed. Am 05.06.20 um 13:21 schrieb Bryan Ellis: > +1 > > * Confirmed verification of the archive signature & hashes > * Verified the sha hash of the release tag > * Verfied that adding plugin on Cordova-iOS 6.x results with a warning about > the supported platform version. > * Verfied that adding plugin on Cordova-iOS 5.x results with no warning about > the supported platform version. > * Test build of plugin on Cordova-iOS 5.x. > * CI is "red" but I have confirmed that this is caused by the "Cordova iOS 6" > release and is not blocking. > https://github.com/apache/cordova-plugin-splashscreen/pull/267 > The PR link above shows confirmation that if the CI with iOS 5.1.1 > would still be passing. > (This patch release is targeting for iOS 5.x and lower) > > >> On Jun 4, 2020, at 22:00, Norman Breau wrote: >> >> I vote +1: >> >> * Ran npm test (on linux) >> * Ran verify-tags >> * Ran verify-archive >> >> On 2020-06-03 3:21 p.m., Niklas Merz wrote: >>> (sending again because previous email was attached to discuss thread) >>> >>> Please review and vote on the release of this plugins release >>> by replying to this email (and keep discussion on the DISCUSS thread) >>> >>> The plugins have been published to dist/dev: >>> https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-splaschreen-5.0.4/ >>> >>> The packages were published from their corresponding git tags: >>> cordova-plugin-splashscreen: 5.0.4 (5bc7d0d63f) >>> >>> Upon a successful vote I will upload the archives to dist/, upload them >>> to npm, and post the corresponding blog post. >>> >>> Voting guidelines: >>> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md >>> How to vote on a plugins release at >>> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting >>> >>> Voting will go on for a minimum of 48 hours. >>> >>> I vote +1: >>> * Ran coho audit-license-headers over the relevant repos >>> * Ran coho check-license to ensure all dependencies and subdependencies >>> have Apache-compatible licenses >>> * Did the tests with Xcode like instructed >>> >>> Please note some CI test could fail but I think the test setup is >>> faulty. Works locally in Xcode for me. Let me know in DISCUSS. >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Splashscreen Plugin Release 5.0.4
+1 * Confirmed verification of the archive signature & hashes * Verified the sha hash of the release tag * Verfied that adding plugin on Cordova-iOS 6.x results with a warning about the supported platform version. * Verfied that adding plugin on Cordova-iOS 5.x results with no warning about the supported platform version. * Test build of plugin on Cordova-iOS 5.x. * CI is "red" but I have confirmed that this is caused by the "Cordova iOS 6" release and is not blocking. https://github.com/apache/cordova-plugin-splashscreen/pull/267 The PR link above shows confirmation that if the CI with iOS 5.1.1 would still be passing. (This patch release is targeting for iOS 5.x and lower) > On Jun 4, 2020, at 22:00, Norman Breau wrote: > > I vote +1: > > * Ran npm test (on linux) > * Ran verify-tags > * Ran verify-archive > > On 2020-06-03 3:21 p.m., Niklas Merz wrote: >> (sending again because previous email was attached to discuss thread) >> >> Please review and vote on the release of this plugins release >> by replying to this email (and keep discussion on the DISCUSS thread) >> >> The plugins have been published to dist/dev: >> https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-splaschreen-5.0.4/ >> >> The packages were published from their corresponding git tags: >> cordova-plugin-splashscreen: 5.0.4 (5bc7d0d63f) >> >> Upon a successful vote I will upload the archives to dist/, upload them >> to npm, and post the corresponding blog post. >> >> Voting guidelines: >> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md >> How to vote on a plugins release at >> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting >> >> Voting will go on for a minimum of 48 hours. >> >> I vote +1: >> * Ran coho audit-license-headers over the relevant repos >> * Ran coho check-license to ensure all dependencies and subdependencies >> have Apache-compatible licenses >> * Did the tests with Xcode like instructed >> >> Please note some CI test could fail but I think the test setup is >> faulty. Works locally in Xcode for me. Let me know in DISCUSS. >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Splashscreen Plugin Release 5.0.4
I vote +1: * Ran npm test (on linux) * Ran verify-tags * Ran verify-archive On 2020-06-03 3:21 p.m., Niklas Merz wrote: (sending again because previous email was attached to discuss thread) Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-splaschreen-5.0.4/ The packages were published from their corresponding git tags: cordova-plugin-splashscreen: 5.0.4 (5bc7d0d63f) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md How to vote on a plugins release at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Did the tests with Xcode like instructed Please note some CI test could fail but I think the test setup is faulty. Works locally in Xcode for me. Let me know in DISCUSS. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[VOTE] Splashscreen Plugin Release 5.0.4
(sending again because previous email was attached to discuss thread) Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-splaschreen-5.0.4/ The packages were published from their corresponding git tags: cordova-plugin-splashscreen: 5.0.4 (5bc7d0d63f) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md How to vote on a plugins release at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Did the tests with Xcode like instructed Please note some CI test could fail but I think the test setup is faulty. Works locally in Xcode for me. Let me know in DISCUSS. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[VOTE] Splashscreen Plugin Release 5.0.4
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-splaschreen-5.0.4/ The packages were published from their corresponding git tags: cordova-plugin-splashscreen: 5.0.4 (5bc7d0d63f) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md How to vote on a plugins release at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Did the tests with Xcode like instructed Please note some CI test could fail but I think the test setup is faulty. Works locally in Xcode for me. Let me know in DISCUSS. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
