Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-07-01 Thread Steven Gill
Blog post for review: https://github.com/apache/cordova-docs/pull/617

On Mon, Jun 6, 2016 at 1:19 PM, Joe Bowser <bows...@gmail.com> wrote:

> So, I guess we should probably just go and do this.  I would have liked to
> get the new AndroidManifest changes into the template.  I have a PR waiting
> as well.
>
> https://github.com/apache/cordova-android/pull/309
>
> On Tue, May 31, 2016 at 1:34 PM, Nikhil Khandelwal <nikhi...@microsoft.com
> >
> wrote:
>
> > Support for incremental prepare (PR #295) has been merged. We should be
> > ready for a release.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Thursday, May 26, 2016 2:52 PM
> > To: dev <dev@cordova.apache.org>
> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> >
> > Do we have an N PR yet? I've seen the proposal, but not the PR.
> >
> > On Thu, May 26, 2016 at 2:47 PM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> >
> > > Can we merge the android N PR too?
> > >
> > > On Wed, May 25, 2016 at 2:50 PM, Joe Bowser <bows...@gmail.com> wrote:
> > >
> > > > On Wed, May 25, 2016 at 1:47 PM, Homer, Tony <tony.ho...@intel.com>
> > > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > Would like #307 to be merged in first
> > > > >
> > > > >
> > > > Done! Yay for tests!
> > > >
> > > > BTW, We need to re-write those to migrate to the new Android JUnit
> > > > test framework (It's more deleting code than adding).
> > > >
> > > >
> > > >
> > > >
> > > > > On 5/25/16, 3:31 PM, "Carlos Santana" <csantan...@gmail.com>
> wrote:
> > > > >
> > > > > >+1
> > > > > >
> > > > > >- Carlos
> > > > > >@csantanapr
> > > > > >
> > > > > >> On May 25, 2016, at 3:08 PM, Shazron <shaz...@gmail.com> wrote:
> > > > > >>
> > > > > >> +1
> > > > > >>
> > > > > >> Release often
> > > > > >>
> > > > > >>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser
> > > > > >>> <bows...@gmail.com>
> > > > > wrote:
> > > > > >>>
> > > > > >>> Hey
> > > > > >>>
> > > > > >>> I know that we haven't done a minor release for a few months
> > > > > >>> for
> > > > > Android,
> > > > > >>> and I think that we have enough worthwhile changes in Android
> > > > > >>> that
> > > we
> > > > > >>> should probably do a release soon.  If possible, I would like
> > > > > >>> for
> > > us
> > > > > to do
> > > > > >>> a 5.2.0 release with the versioning fix, and the other build
> > > > > >>> script
> > > > > fixes
> > > > > >>> that have been done recently.  There's not a lot of commits,
> > > > > >>> but I
> > > do
> > > > > think
> > > > > >>> what we do have is worthy of being released.
> > > > > >>>
> > > > > >>> What do people think?
> > > > > >>>
> > > > > >>> Joe
> > > > > >>>
> > > > > >
> > > > > >-
> > > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > > >For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-06-06 Thread Joe Bowser
So, I guess we should probably just go and do this.  I would have liked to
get the new AndroidManifest changes into the template.  I have a PR waiting
as well.

https://github.com/apache/cordova-android/pull/309

On Tue, May 31, 2016 at 1:34 PM, Nikhil Khandelwal <nikhi...@microsoft.com>
wrote:

> Support for incremental prepare (PR #295) has been merged. We should be
> ready for a release.
>
> -Nikhil
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Thursday, May 26, 2016 2:52 PM
> To: dev <dev@cordova.apache.org>
> Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>
> Do we have an N PR yet? I've seen the proposal, but not the PR.
>
> On Thu, May 26, 2016 at 2:47 PM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
> > Can we merge the android N PR too?
> >
> > On Wed, May 25, 2016 at 2:50 PM, Joe Bowser <bows...@gmail.com> wrote:
> >
> > > On Wed, May 25, 2016 at 1:47 PM, Homer, Tony <tony.ho...@intel.com>
> > wrote:
> > >
> > > > +1
> > > >
> > > > Would like #307 to be merged in first
> > > >
> > > >
> > > Done! Yay for tests!
> > >
> > > BTW, We need to re-write those to migrate to the new Android JUnit
> > > test framework (It's more deleting code than adding).
> > >
> > >
> > >
> > >
> > > > On 5/25/16, 3:31 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
> > > >
> > > > >+1
> > > > >
> > > > >- Carlos
> > > > >@csantanapr
> > > > >
> > > > >> On May 25, 2016, at 3:08 PM, Shazron <shaz...@gmail.com> wrote:
> > > > >>
> > > > >> +1
> > > > >>
> > > > >> Release often
> > > > >>
> > > > >>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser
> > > > >>> <bows...@gmail.com>
> > > > wrote:
> > > > >>>
> > > > >>> Hey
> > > > >>>
> > > > >>> I know that we haven't done a minor release for a few months
> > > > >>> for
> > > > Android,
> > > > >>> and I think that we have enough worthwhile changes in Android
> > > > >>> that
> > we
> > > > >>> should probably do a release soon.  If possible, I would like
> > > > >>> for
> > us
> > > > to do
> > > > >>> a 5.2.0 release with the versioning fix, and the other build
> > > > >>> script
> > > > fixes
> > > > >>> that have been done recently.  There's not a lot of commits,
> > > > >>> but I
> > do
> > > > think
> > > > >>> what we do have is worthy of being released.
> > > > >>>
> > > > >>> What do people think?
> > > > >>>
> > > > >>> Joe
> > > > >>>
> > > > >
> > > > >-
> > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > >For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > >
> > > >
> > > >
> > >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>


RE: [DISCUSS] Cordova-Android 5.2.0 Release

2016-06-01 Thread Nikhil Khandelwal
As part of this release should we add a deprecation warning for --ant build 
support for Cordova-android?

As we make changes for the next major release of cordova-android we will likely 
not be able to support the ant build for much longer. It's best to start 
messaging it's end of life.

-Nikhil

-Original Message-
From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] 
Sent: Tuesday, May 31, 2016 1:35 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Cordova-Android 5.2.0 Release

Support for incremental prepare (PR #295) has been merged. We should be ready 
for a release.

-Nikhil

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Thursday, May 26, 2016 2:52 PM
To: dev <dev@cordova.apache.org>
Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release

Do we have an N PR yet? I've seen the proposal, but not the PR.

On Thu, May 26, 2016 at 2:47 PM, Steven Gill <stevengil...@gmail.com> wrote:

> Can we merge the android N PR too?
>
> On Wed, May 25, 2016 at 2:50 PM, Joe Bowser <bows...@gmail.com> wrote:
>
> > On Wed, May 25, 2016 at 1:47 PM, Homer, Tony <tony.ho...@intel.com>
> wrote:
> >
> > > +1
> > >
> > > Would like #307 to be merged in first
> > >
> > >
> > Done! Yay for tests!
> >
> > BTW, We need to re-write those to migrate to the new Android JUnit 
> > test framework (It's more deleting code than adding).
> >
> >
> >
> >
> > > On 5/25/16, 3:31 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
> > >
> > > >+1
> > > >
> > > >- Carlos
> > > >@csantanapr
> > > >
> > > >> On May 25, 2016, at 3:08 PM, Shazron <shaz...@gmail.com> wrote:
> > > >>
> > > >> +1
> > > >>
> > > >> Release often
> > > >>
> > > >>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser 
> > > >>> <bows...@gmail.com>
> > > wrote:
> > > >>>
> > > >>> Hey
> > > >>>
> > > >>> I know that we haven't done a minor release for a few months 
> > > >>> for
> > > Android,
> > > >>> and I think that we have enough worthwhile changes in Android 
> > > >>> that
> we
> > > >>> should probably do a release soon.  If possible, I would like 
> > > >>> for
> us
> > > to do
> > > >>> a 5.2.0 release with the versioning fix, and the other build 
> > > >>> script
> > > fixes
> > > >>> that have been done recently.  There's not a lot of commits, 
> > > >>> but I
> do
> > > think
> > > >>> what we do have is worthy of being released.
> > > >>>
> > > >>> What do people think?
> > > >>>
> > > >>> Joe
> > > >>>
> > > >
> > > >-
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > >For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > >
> > >
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


RE: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-31 Thread Nikhil Khandelwal
Support for incremental prepare (PR #295) has been merged. We should be ready 
for a release.

-Nikhil

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Thursday, May 26, 2016 2:52 PM
To: dev <dev@cordova.apache.org>
Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release

Do we have an N PR yet? I've seen the proposal, but not the PR.

On Thu, May 26, 2016 at 2:47 PM, Steven Gill <stevengil...@gmail.com> wrote:

> Can we merge the android N PR too?
>
> On Wed, May 25, 2016 at 2:50 PM, Joe Bowser <bows...@gmail.com> wrote:
>
> > On Wed, May 25, 2016 at 1:47 PM, Homer, Tony <tony.ho...@intel.com>
> wrote:
> >
> > > +1
> > >
> > > Would like #307 to be merged in first
> > >
> > >
> > Done! Yay for tests!
> >
> > BTW, We need to re-write those to migrate to the new Android JUnit 
> > test framework (It's more deleting code than adding).
> >
> >
> >
> >
> > > On 5/25/16, 3:31 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
> > >
> > > >+1
> > > >
> > > >- Carlos
> > > >@csantanapr
> > > >
> > > >> On May 25, 2016, at 3:08 PM, Shazron <shaz...@gmail.com> wrote:
> > > >>
> > > >> +1
> > > >>
> > > >> Release often
> > > >>
> > > >>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser 
> > > >>> <bows...@gmail.com>
> > > wrote:
> > > >>>
> > > >>> Hey
> > > >>>
> > > >>> I know that we haven't done a minor release for a few months 
> > > >>> for
> > > Android,
> > > >>> and I think that we have enough worthwhile changes in Android 
> > > >>> that
> we
> > > >>> should probably do a release soon.  If possible, I would like 
> > > >>> for
> us
> > > to do
> > > >>> a 5.2.0 release with the versioning fix, and the other build 
> > > >>> script
> > > fixes
> > > >>> that have been done recently.  There's not a lot of commits, 
> > > >>> but I
> do
> > > think
> > > >>> what we do have is worthy of being released.
> > > >>>
> > > >>> What do people think?
> > > >>>
> > > >>> Joe
> > > >>>
> > > >
> > > >-
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > >For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > >
> > >
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-26 Thread Joe Bowser
Do we have an N PR yet? I've seen the proposal, but not the PR.

On Thu, May 26, 2016 at 2:47 PM, Steven Gill  wrote:

> Can we merge the android N PR too?
>
> On Wed, May 25, 2016 at 2:50 PM, Joe Bowser  wrote:
>
> > On Wed, May 25, 2016 at 1:47 PM, Homer, Tony 
> wrote:
> >
> > > +1
> > >
> > > Would like #307 to be merged in first
> > >
> > >
> > Done! Yay for tests!
> >
> > BTW, We need to re-write those to migrate to the new Android JUnit test
> > framework (It's more deleting code than adding).
> >
> >
> >
> >
> > > On 5/25/16, 3:31 PM, "Carlos Santana"  wrote:
> > >
> > > >+1
> > > >
> > > >- Carlos
> > > >@csantanapr
> > > >
> > > >> On May 25, 2016, at 3:08 PM, Shazron  wrote:
> > > >>
> > > >> +1
> > > >>
> > > >> Release often
> > > >>
> > > >>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser 
> > > wrote:
> > > >>>
> > > >>> Hey
> > > >>>
> > > >>> I know that we haven't done a minor release for a few months for
> > > Android,
> > > >>> and I think that we have enough worthwhile changes in Android that
> we
> > > >>> should probably do a release soon.  If possible, I would like for
> us
> > > to do
> > > >>> a 5.2.0 release with the versioning fix, and the other build script
> > > fixes
> > > >>> that have been done recently.  There's not a lot of commits, but I
> do
> > > think
> > > >>> what we do have is worthy of being released.
> > > >>>
> > > >>> What do people think?
> > > >>>
> > > >>> Joe
> > > >>>
> > > >
> > > >-
> > > >To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > >For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > >
> > >
> >
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-26 Thread Steven Gill
Can we merge the android N PR too?

On Wed, May 25, 2016 at 2:50 PM, Joe Bowser  wrote:

> On Wed, May 25, 2016 at 1:47 PM, Homer, Tony  wrote:
>
> > +1
> >
> > Would like #307 to be merged in first
> >
> >
> Done! Yay for tests!
>
> BTW, We need to re-write those to migrate to the new Android JUnit test
> framework (It's more deleting code than adding).
>
>
>
>
> > On 5/25/16, 3:31 PM, "Carlos Santana"  wrote:
> >
> > >+1
> > >
> > >- Carlos
> > >@csantanapr
> > >
> > >> On May 25, 2016, at 3:08 PM, Shazron  wrote:
> > >>
> > >> +1
> > >>
> > >> Release often
> > >>
> > >>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser 
> > wrote:
> > >>>
> > >>> Hey
> > >>>
> > >>> I know that we haven't done a minor release for a few months for
> > Android,
> > >>> and I think that we have enough worthwhile changes in Android that we
> > >>> should probably do a release soon.  If possible, I would like for us
> > to do
> > >>> a 5.2.0 release with the versioning fix, and the other build script
> > fixes
> > >>> that have been done recently.  There's not a lot of commits, but I do
> > think
> > >>> what we do have is worthy of being released.
> > >>>
> > >>> What do people think?
> > >>>
> > >>> Joe
> > >>>
> > >
> > >-
> > >To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > >For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> >
> >
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-25 Thread Joe Bowser
On Wed, May 25, 2016 at 1:47 PM, Homer, Tony  wrote:

> +1
>
> Would like #307 to be merged in first
>
>
Done! Yay for tests!

BTW, We need to re-write those to migrate to the new Android JUnit test
framework (It's more deleting code than adding).




> On 5/25/16, 3:31 PM, "Carlos Santana"  wrote:
>
> >+1
> >
> >- Carlos
> >@csantanapr
> >
> >> On May 25, 2016, at 3:08 PM, Shazron  wrote:
> >>
> >> +1
> >>
> >> Release often
> >>
> >>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser 
> wrote:
> >>>
> >>> Hey
> >>>
> >>> I know that we haven't done a minor release for a few months for
> Android,
> >>> and I think that we have enough worthwhile changes in Android that we
> >>> should probably do a release soon.  If possible, I would like for us
> to do
> >>> a 5.2.0 release with the versioning fix, and the other build script
> fixes
> >>> that have been done recently.  There's not a lot of commits, but I do
> think
> >>> what we do have is worthy of being released.
> >>>
> >>> What do people think?
> >>>
> >>> Joe
> >>>
> >
> >-
> >To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-25 Thread Homer, Tony
+1 

Would like #307 to be merged in first

On 5/25/16, 3:31 PM, "Carlos Santana"  wrote:

>+1
>
>- Carlos
>@csantanapr
>
>> On May 25, 2016, at 3:08 PM, Shazron  wrote:
>> 
>> +1
>> 
>> Release often
>> 
>>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser  wrote:
>>> 
>>> Hey
>>> 
>>> I know that we haven't done a minor release for a few months for Android,
>>> and I think that we have enough worthwhile changes in Android that we
>>> should probably do a release soon.  If possible, I would like for us to do
>>> a 5.2.0 release with the versioning fix, and the other build script fixes
>>> that have been done recently.  There's not a lot of commits, but I do think
>>> what we do have is worthy of being released.
>>> 
>>> What do people think?
>>> 
>>> Joe
>>> 
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>For additional commands, e-mail: dev-h...@cordova.apache.org
>



Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-25 Thread Carlos Santana
+1

- Carlos
@csantanapr

> On May 25, 2016, at 3:08 PM, Shazron  wrote:
> 
> +1
> 
> Release often
> 
>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser  wrote:
>> 
>> Hey
>> 
>> I know that we haven't done a minor release for a few months for Android,
>> and I think that we have enough worthwhile changes in Android that we
>> should probably do a release soon.  If possible, I would like for us to do
>> a 5.2.0 release with the versioning fix, and the other build script fixes
>> that have been done recently.  There's not a lot of commits, but I do think
>> what we do have is worthy of being released.
>> 
>> What do people think?
>> 
>> Joe
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-25 Thread Shazron
+1

Release often

On Wed, May 25, 2016 at 10:33 AM, Joe Bowser  wrote:

> Hey
>
> I know that we haven't done a minor release for a few months for Android,
> and I think that we have enough worthwhile changes in Android that we
> should probably do a release soon.  If possible, I would like for us to do
> a 5.2.0 release with the versioning fix, and the other build script fixes
> that have been done recently.  There's not a lot of commits, but I do think
> what we do have is worthy of being released.
>
> What do people think?
>
> Joe
>


RE: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-25 Thread Nikhil Khandelwal
+1. It will be great to get this PR merged now that cordova-common has been 
released: https://github.com/apache/cordova-android/pull/295/files

-Nikhil 

-Original Message-
From: Simon MacDonald [mailto:simon.macdon...@gmail.com] 
Sent: Wednesday, May 25, 2016 10:38 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release

+1
On May 25, 2016 1:33 PM, "Joe Bowser" <bows...@gmail.com> wrote:

> Hey
>
> I know that we haven't done a minor release for a few months for 
> Android, and I think that we have enough worthwhile changes in Android 
> that we should probably do a release soon.  If possible, I would like 
> for us to do a 5.2.0 release with the versioning fix, and the other 
> build script fixes that have been done recently.  There's not a lot of 
> commits, but I do think what we do have is worthy of being released.
>
> What do people think?
>
> Joe
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-25 Thread Simon MacDonald
+1
On May 25, 2016 1:33 PM, "Joe Bowser"  wrote:

> Hey
>
> I know that we haven't done a minor release for a few months for Android,
> and I think that we have enough worthwhile changes in Android that we
> should probably do a release soon.  If possible, I would like for us to do
> a 5.2.0 release with the versioning fix, and the other build script fixes
> that have been done recently.  There's not a lot of commits, but I do think
> what we do have is worthy of being released.
>
> What do people think?
>
> Joe
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-03-01 Thread Steven Gill
Please review the blog post. https://github.com/apache/cordova-docs/pull/529



On Fri, Feb 26, 2016 at 2:00 PM, Steven Gill <stevengil...@gmail.com> wrote:

> Alright, I ended up just doing a rebase from master instead of
> cherry-picking. I think it should be all good now. Third vote sent.
>
> On Fri, Feb 26, 2016 at 9:00 AM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
>> Hmm. Alright. I thought I got them all but obviously not. I'll
>> reinvestigate today.
>> On Feb 26, 2016 3:58 AM, "Alexander Sorokin (Akvelon)" <
>> v-als...@microsoft.com> wrote:
>>
>>> Sorry to say that but it looks like only a half of the changes made it
>>> to the archive this time.
>>>
>>> Here's what is missing:
>>> * CB-10138 Adds missing plugin metadata to `plugin_list` module.
>>> * CB-10443 Pass original options instead of remaining
>>> * CB-10443 Fix `this.root` null reference
>>> * CB-10421 Fixes exception when calling run script with `--help` option
>>> * updated `.gitignore`
>>> * CB-10406 Fixes an exception, thrown when building using Ant.
>>> * CB-10157 Uninstall app from device/emulator only when signed apk is
>>> already installed
>>>
>>> -Original Message-
>>> From: Steven Gill [mailto:stevengil...@gmail.com]
>>> Sent: Thursday, February 25, 2016 6:45 PM
>>> To: dev@cordova.apache.org
>>> Subject: RE: [DISCUSS] Cordova-Android 5.2.0 Release
>>>
>>> Ahh your right. Looks like since 5.1.x existed I needed to manually
>>> cherry-pick changes into it instead of relying on coho prepare-release
>>> command.  I'll send a new vote today.
>>> On Feb 25, 2016 6:19 AM, "Alexander Sorokin (Akvelon)" <
>>> v-als...@microsoft.com> wrote:
>>>
>>> > I think there's something wrong with the package: it doesn't contain
>>> > any of the changes described in the release notes, only increased
>>> version.
>>> >
>>> > -Original Message-
>>> > From: Steven Gill [mailto:stevengil...@gmail.com]
>>> > Sent: Thursday, February 25, 2016 5:59 AM
>>> > To: dev@cordova.apache.org
>>> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>>> >
>>> > I added them today :D
>>> >
>>> > On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal
>>> > <nikhi...@microsoft.com
>>> > >
>>> > wrote:
>>> >
>>> > > These commands look great - it will be good to add them to release
>>> > > process docs if they are not already there.
>>> > >
>>> > > -Nikhil
>>> > >
>>> > > -Original Message-
>>> > > From: Steven Gill [mailto:stevengil...@gmail.com]
>>> > > Sent: Wednesday, February 24, 2016 10:03 AM
>>> > > To: dev@cordova.apache.org
>>> > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>>> > >
>>> > > Definitely. Already committed the update.
>>> > >
>>> > > My new strategy with bundled/checked in dependencies
>>> > >
>>> > > * update package.json dep version if required
>>> > > * rm -rf node_modules
>>> > > * npm install --production (skips dev dependencies)
>>> > > * git add node_modules/* (checkin all modules needed for platform
>>> > > add git
>>> > > url)
>>> > > * git commit
>>> > > * npm install (Readd dev dependencies for ability to run tests
>>> > > locally)
>>> > >
>>> > >
>>> > >
>>> > > On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) <
>>> > > v-vlk...@microsoft.com> wrote:
>>> > >
>>> > > > Steve, do you plan to update bundled `cordova-common` as a part of
>>> > > > this release?
>>> > > >
>>> > > > -
>>> > > > Best regards, Vladimir
>>> > > >
>>> > > > -Original Message-
>>> > > > From: Steven Gill [mailto:stevengil...@gmail.com]
>>> > > > Sent: Wednesday, February 24, 2016 8:12 PM
>>> > > > To: dev@cordova.apache.org
>>> > > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>>> > > >
>>> > > > Issue:
>>> > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi
>>

Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-26 Thread Steven Gill
Alright, I ended up just doing a rebase from master instead of
cherry-picking. I think it should be all good now. Third vote sent.

On Fri, Feb 26, 2016 at 9:00 AM, Steven Gill <stevengil...@gmail.com> wrote:

> Hmm. Alright. I thought I got them all but obviously not. I'll
> reinvestigate today.
> On Feb 26, 2016 3:58 AM, "Alexander Sorokin (Akvelon)" <
> v-als...@microsoft.com> wrote:
>
>> Sorry to say that but it looks like only a half of the changes made it to
>> the archive this time.
>>
>> Here's what is missing:
>> * CB-10138 Adds missing plugin metadata to `plugin_list` module.
>> * CB-10443 Pass original options instead of remaining
>> * CB-10443 Fix `this.root` null reference
>> * CB-10421 Fixes exception when calling run script with `--help` option
>> * updated `.gitignore`
>> * CB-10406 Fixes an exception, thrown when building using Ant.
>> * CB-10157 Uninstall app from device/emulator only when signed apk is
>> already installed
>>
>> -Original Message-
>> From: Steven Gill [mailto:stevengil...@gmail.com]
>> Sent: Thursday, February 25, 2016 6:45 PM
>> To: dev@cordova.apache.org
>> Subject: RE: [DISCUSS] Cordova-Android 5.2.0 Release
>>
>> Ahh your right. Looks like since 5.1.x existed I needed to manually
>> cherry-pick changes into it instead of relying on coho prepare-release
>> command.  I'll send a new vote today.
>> On Feb 25, 2016 6:19 AM, "Alexander Sorokin (Akvelon)" <
>> v-als...@microsoft.com> wrote:
>>
>> > I think there's something wrong with the package: it doesn't contain
>> > any of the changes described in the release notes, only increased
>> version.
>> >
>> > -Original Message-
>> > From: Steven Gill [mailto:stevengil...@gmail.com]
>> > Sent: Thursday, February 25, 2016 5:59 AM
>> > To: dev@cordova.apache.org
>> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>> >
>> > I added them today :D
>> >
>> > On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal
>> > <nikhi...@microsoft.com
>> > >
>> > wrote:
>> >
>> > > These commands look great - it will be good to add them to release
>> > > process docs if they are not already there.
>> > >
>> > > -Nikhil
>> > >
>> > > -Original Message-
>> > > From: Steven Gill [mailto:stevengil...@gmail.com]
>> > > Sent: Wednesday, February 24, 2016 10:03 AM
>> > > To: dev@cordova.apache.org
>> > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>> > >
>> > > Definitely. Already committed the update.
>> > >
>> > > My new strategy with bundled/checked in dependencies
>> > >
>> > > * update package.json dep version if required
>> > > * rm -rf node_modules
>> > > * npm install --production (skips dev dependencies)
>> > > * git add node_modules/* (checkin all modules needed for platform
>> > > add git
>> > > url)
>> > > * git commit
>> > > * npm install (Readd dev dependencies for ability to run tests
>> > > locally)
>> > >
>> > >
>> > >
>> > > On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) <
>> > > v-vlk...@microsoft.com> wrote:
>> > >
>> > > > Steve, do you plan to update bundled `cordova-common` as a part of
>> > > > this release?
>> > > >
>> > > > -
>> > > > Best regards, Vladimir
>> > > >
>> > > > -Original Message-
>> > > > From: Steven Gill [mailto:stevengil...@gmail.com]
>> > > > Sent: Wednesday, February 24, 2016 8:12 PM
>> > > > To: dev@cordova.apache.org
>> > > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>> > > >
>> > > > Issue:
>> > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi
>> > > > ss
>> > > > ue
>> > > > s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%40
>> > > > 06
>> > > > 4d
>> > > > .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86
>> > > > f1
>> > > > 41
>> > > > af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRY
>> > > > xX
>> > > > dH
>> > > > fE%3d
>> > > >
>> > > >

RE: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-26 Thread Steven Gill
Hmm. Alright. I thought I got them all but obviously not. I'll
reinvestigate today.
On Feb 26, 2016 3:58 AM, "Alexander Sorokin (Akvelon)" <
v-als...@microsoft.com> wrote:

> Sorry to say that but it looks like only a half of the changes made it to
> the archive this time.
>
> Here's what is missing:
> * CB-10138 Adds missing plugin metadata to `plugin_list` module.
> * CB-10443 Pass original options instead of remaining
> * CB-10443 Fix `this.root` null reference
> * CB-10421 Fixes exception when calling run script with `--help` option
> * updated `.gitignore`
> * CB-10406 Fixes an exception, thrown when building using Ant.
> * CB-10157 Uninstall app from device/emulator only when signed apk is
> already installed
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Thursday, February 25, 2016 6:45 PM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Cordova-Android 5.2.0 Release
>
> Ahh your right. Looks like since 5.1.x existed I needed to manually
> cherry-pick changes into it instead of relying on coho prepare-release
> command.  I'll send a new vote today.
> On Feb 25, 2016 6:19 AM, "Alexander Sorokin (Akvelon)" <
> v-als...@microsoft.com> wrote:
>
> > I think there's something wrong with the package: it doesn't contain
> > any of the changes described in the release notes, only increased
> version.
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Thursday, February 25, 2016 5:59 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> >
> > I added them today :D
> >
> > On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal
> > <nikhi...@microsoft.com
> > >
> > wrote:
> >
> > > These commands look great - it will be good to add them to release
> > > process docs if they are not already there.
> > >
> > > -Nikhil
> > >
> > > -Original Message-
> > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > Sent: Wednesday, February 24, 2016 10:03 AM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> > >
> > > Definitely. Already committed the update.
> > >
> > > My new strategy with bundled/checked in dependencies
> > >
> > > * update package.json dep version if required
> > > * rm -rf node_modules
> > > * npm install --production (skips dev dependencies)
> > > * git add node_modules/* (checkin all modules needed for platform
> > > add git
> > > url)
> > > * git commit
> > > * npm install (Readd dev dependencies for ability to run tests
> > > locally)
> > >
> > >
> > >
> > > On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) <
> > > v-vlk...@microsoft.com> wrote:
> > >
> > > > Steve, do you plan to update bundled `cordova-common` as a part of
> > > > this release?
> > > >
> > > > -
> > > > Best regards, Vladimir
> > > >
> > > > -Original Message-
> > > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > > Sent: Wednesday, February 24, 2016 8:12 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> > > >
> > > > Issue:
> > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi
> > > > ss
> > > > ue
> > > > s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%40
> > > > 06
> > > > 4d
> > > > .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86
> > > > f1
> > > > 41
> > > > af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRY
> > > > xX
> > > > dH
> > > > fE%3d
> > > >
> > > > I'm going to make this version 5.1.1. I'll update here if I decide
> > > > to go with 5.2.0 instead.
> > > >
> > > > On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser <bows...@gmail.com>
> > wrote:
> > > >
> > > > > OK, are we sure we didn't add any new minor features?
> > > > >
> > > > > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill
> > > > > <stevengil...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Well we should be following semver.
> > > > > >

RE: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-26 Thread Alexander Sorokin (Akvelon)
Sorry to say that but it looks like only a half of the changes made it to the 
archive this time.

Here's what is missing:
* CB-10138 Adds missing plugin metadata to `plugin_list` module.
* CB-10443 Pass original options instead of remaining
* CB-10443 Fix `this.root` null reference
* CB-10421 Fixes exception when calling run script with `--help` option
* updated `.gitignore`
* CB-10406 Fixes an exception, thrown when building using Ant. 
* CB-10157 Uninstall app from device/emulator only when signed apk is already 
installed

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Thursday, February 25, 2016 6:45 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Cordova-Android 5.2.0 Release

Ahh your right. Looks like since 5.1.x existed I needed to manually cherry-pick 
changes into it instead of relying on coho prepare-release command.  I'll send 
a new vote today.
On Feb 25, 2016 6:19 AM, "Alexander Sorokin (Akvelon)" < 
v-als...@microsoft.com> wrote:

> I think there's something wrong with the package: it doesn't contain 
> any of the changes described in the release notes, only increased version.
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Thursday, February 25, 2016 5:59 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>
> I added them today :D
>
> On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal 
> <nikhi...@microsoft.com
> >
> wrote:
>
> > These commands look great - it will be good to add them to release 
> > process docs if they are not already there.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Wednesday, February 24, 2016 10:03 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> >
> > Definitely. Already committed the update.
> >
> > My new strategy with bundled/checked in dependencies
> >
> > * update package.json dep version if required
> > * rm -rf node_modules
> > * npm install --production (skips dev dependencies)
> > * git add node_modules/* (checkin all modules needed for platform 
> > add git
> > url)
> > * git commit
> > * npm install (Readd dev dependencies for ability to run tests
> > locally)
> >
> >
> >
> > On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) < 
> > v-vlk...@microsoft.com> wrote:
> >
> > > Steve, do you plan to update bundled `cordova-common` as a part of 
> > > this release?
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > Sent: Wednesday, February 24, 2016 8:12 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> > >
> > > Issue:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi
> > > ss
> > > ue
> > > s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%40
> > > 06
> > > 4d
> > > .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86
> > > f1
> > > 41
> > > af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRY
> > > xX
> > > dH
> > > fE%3d
> > >
> > > I'm going to make this version 5.1.1. I'll update here if I decide 
> > > to go with 5.2.0 instead.
> > >
> > > On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser <bows...@gmail.com>
> wrote:
> > >
> > > > OK, are we sure we didn't add any new minor features?
> > > >
> > > > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill 
> > > > <stevengil...@gmail.com>
> > > > wrote:
> > > >
> > > > > Well we should be following semver.
> > > > >
> > > > >
> > > > >- Bug fixes and other minor changes: Patch release, 
> > > > > increment the
> > > last
> > > > >number, e.g. 1.0.1
> > > > >- New features which don't break existing features: Minor
> release,
> > > > >increment the middle number, e.g. 1.1.0
> > > > >- Changes which break backwards compatibility: Major 
> > > > > release,
> > > > increment
> > > > >the first number, e.g. 2.0.0
> > > > >
> > > > >
> > > > > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana 

RE: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-25 Thread Steven Gill
Ahh your right. Looks like since 5.1.x existed I needed to manually
cherry-pick changes into it instead of relying on coho prepare-release
command.  I'll send a new vote today.
On Feb 25, 2016 6:19 AM, "Alexander Sorokin (Akvelon)" <
v-als...@microsoft.com> wrote:

> I think there's something wrong with the package: it doesn't contain any
> of the changes described in the release notes, only increased version.
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Thursday, February 25, 2016 5:59 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>
> I added them today :D
>
> On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal <nikhi...@microsoft.com
> >
> wrote:
>
> > These commands look great - it will be good to add them to release
> > process docs if they are not already there.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Wednesday, February 24, 2016 10:03 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> >
> > Definitely. Already committed the update.
> >
> > My new strategy with bundled/checked in dependencies
> >
> > * update package.json dep version if required
> > * rm -rf node_modules
> > * npm install --production (skips dev dependencies)
> > * git add node_modules/* (checkin all modules needed for platform add
> > git
> > url)
> > * git commit
> > * npm install (Readd dev dependencies for ability to run tests
> > locally)
> >
> >
> >
> > On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) <
> > v-vlk...@microsoft.com> wrote:
> >
> > > Steve, do you plan to update bundled `cordova-common` as a part of
> > > this release?
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > Sent: Wednesday, February 24, 2016 8:12 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> > >
> > > Issue:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> > > ue
> > > s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%4006
> > > 4d
> > > .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86f1
> > > 41
> > > af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRYxX
> > > dH
> > > fE%3d
> > >
> > > I'm going to make this version 5.1.1. I'll update here if I decide
> > > to go with 5.2.0 instead.
> > >
> > > On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser <bows...@gmail.com>
> wrote:
> > >
> > > > OK, are we sure we didn't add any new minor features?
> > > >
> > > > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill
> > > > <stevengil...@gmail.com>
> > > > wrote:
> > > >
> > > > > Well we should be following semver.
> > > > >
> > > > >
> > > > >- Bug fixes and other minor changes: Patch release, increment
> > > > > the
> > > last
> > > > >number, e.g. 1.0.1
> > > > >- New features which don't break existing features: Minor
> release,
> > > > >increment the middle number, e.g. 1.1.0
> > > > >- Changes which break backwards compatibility: Major release,
> > > > increment
> > > > >the first number, e.g. 2.0.0
> > > > >
> > > > >
> > > > > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana
> > > > > <csantan...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > +1 to wait for cordova-common, then to platforms
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Tue, Feb 16, 2016 at 7:48 PM Steven Gill
> > > > > > <stevengil...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Any issues with me starting this release?
> > > > > > >
> > > > > > > I think I will wait for the cordova-common release to finish
> > > > > > > so I can bundle it in.
> > > > > > >
> > > > > > > Changes:
> > > > > > > 

RE: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-25 Thread Alexander Sorokin (Akvelon)
I think there's something wrong with the package: it doesn't contain any of the 
changes described in the release notes, only increased version.

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Thursday, February 25, 2016 5:59 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release

I added them today :D

On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal <nikhi...@microsoft.com>
wrote:

> These commands look great - it will be good to add them to release 
> process docs if they are not already there.
>
> -Nikhil
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Wednesday, February 24, 2016 10:03 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>
> Definitely. Already committed the update.
>
> My new strategy with bundled/checked in dependencies
>
> * update package.json dep version if required
> * rm -rf node_modules
> * npm install --production (skips dev dependencies)
> * git add node_modules/* (checkin all modules needed for platform add 
> git
> url)
> * git commit
> * npm install (Readd dev dependencies for ability to run tests 
> locally)
>
>
>
> On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) < 
> v-vlk...@microsoft.com> wrote:
>
> > Steve, do you plan to update bundled `cordova-common` as a part of 
> > this release?
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Wednesday, February 24, 2016 8:12 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> >
> > Issue:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> > ue 
> > s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%4006
> > 4d
> > .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86f1
> > 41 
> > af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRYxX
> > dH
> > fE%3d
> >
> > I'm going to make this version 5.1.1. I'll update here if I decide 
> > to go with 5.2.0 instead.
> >
> > On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser <bows...@gmail.com> wrote:
> >
> > > OK, are we sure we didn't add any new minor features?
> > >
> > > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill 
> > > <stevengil...@gmail.com>
> > > wrote:
> > >
> > > > Well we should be following semver.
> > > >
> > > >
> > > >- Bug fixes and other minor changes: Patch release, increment 
> > > > the
> > last
> > > >number, e.g. 1.0.1
> > > >- New features which don't break existing features: Minor release,
> > > >increment the middle number, e.g. 1.1.0
> > > >- Changes which break backwards compatibility: Major release,
> > > increment
> > > >the first number, e.g. 2.0.0
> > > >
> > > >
> > > > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana 
> > > > <csantan...@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 to wait for cordova-common, then to platforms
> > > > >
> > > > >
> > > > >
> > > > > On Tue, Feb 16, 2016 at 7:48 PM Steven Gill 
> > > > > <stevengil...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Any issues with me starting this release?
> > > > > >
> > > > > > I think I will wait for the cordova-common release to finish 
> > > > > > so I can bundle it in.
> > > > > >
> > > > > > Changes:
> > > > > > * CB-10510: Add an optional timeout to emu start script
> > > > > > * CB-10498: Resume event should be sticky if it has a plugin 
> > > > > > result
> > > > > > * fix HtmlNotFoundTest so that it passes when file not found 
> > > > > > is
> > > handled
> > > > > > correctly This Closes #256
> > > > > > * CB-10472 NullPointerException:
> > > > > > org.apache.cordova.PluginManager.onSaveInstanceState check 
> > > > > > if
> > > > > pluginManager
> > > > > > is null before using it This closes #255
> > > > > > * CB-10138 Adds missing plugin metadata to plugin_list module.
> > > > > > This
> > > > > closes
> > > > > > #254
> > > > > > * CB-10443 Pass original options instead of remaining
> > > > > > * CB-10443 Fix `this.root` null reference
> > > > > > * CB-10421 Fixes exception when calling run script with 
> > > > > > --help option
> > > > > > * updated .gitignore
> > > > > > * CB-10406 Fixes an exception, thrown when building using Ant.
> > > > > > This
> > > > > closes
> > > > > > #250
> > > > > > * CB-10157 Uninstall app from device/emulator only when 
> > > > > > signed apk is already installed
> > > > > >
> > > > >
> > > >
> > >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-24 Thread Steven Gill
I added them today :D

On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal <nikhi...@microsoft.com>
wrote:

> These commands look great - it will be good to add them to release process
> docs if they are not already there.
>
> -Nikhil
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Wednesday, February 24, 2016 10:03 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>
> Definitely. Already committed the update.
>
> My new strategy with bundled/checked in dependencies
>
> * update package.json dep version if required
> * rm -rf node_modules
> * npm install --production (skips dev dependencies)
> * git add node_modules/* (checkin all modules needed for platform add git
> url)
> * git commit
> * npm install (Readd dev dependencies for ability to run tests locally)
>
>
>
> On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) <
> v-vlk...@microsoft.com> wrote:
>
> > Steve, do you plan to update bundled `cordova-common` as a part of
> > this release?
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Wednesday, February 24, 2016 8:12 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> >
> > Issue:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%40064d
> > .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86f141
> > af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRYxXdH
> > fE%3d
> >
> > I'm going to make this version 5.1.1. I'll update here if I decide to
> > go with 5.2.0 instead.
> >
> > On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser <bows...@gmail.com> wrote:
> >
> > > OK, are we sure we didn't add any new minor features?
> > >
> > > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill
> > > <stevengil...@gmail.com>
> > > wrote:
> > >
> > > > Well we should be following semver.
> > > >
> > > >
> > > >- Bug fixes and other minor changes: Patch release, increment
> > > > the
> > last
> > > >number, e.g. 1.0.1
> > > >- New features which don't break existing features: Minor release,
> > > >increment the middle number, e.g. 1.1.0
> > > >- Changes which break backwards compatibility: Major release,
> > > increment
> > > >the first number, e.g. 2.0.0
> > > >
> > > >
> > > > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana
> > > > <csantan...@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 to wait for cordova-common, then to platforms
> > > > >
> > > > >
> > > > >
> > > > > On Tue, Feb 16, 2016 at 7:48 PM Steven Gill
> > > > > <stevengil...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Any issues with me starting this release?
> > > > > >
> > > > > > I think I will wait for the cordova-common release to finish
> > > > > > so I can bundle it in.
> > > > > >
> > > > > > Changes:
> > > > > > * CB-10510: Add an optional timeout to emu start script
> > > > > > * CB-10498: Resume event should be sticky if it has a plugin
> > > > > > result
> > > > > > * fix HtmlNotFoundTest so that it passes when file not found
> > > > > > is
> > > handled
> > > > > > correctly This Closes #256
> > > > > > * CB-10472 NullPointerException:
> > > > > > org.apache.cordova.PluginManager.onSaveInstanceState check if
> > > > > pluginManager
> > > > > > is null before using it This closes #255
> > > > > > * CB-10138 Adds missing plugin metadata to plugin_list module.
> > > > > > This
> > > > > closes
> > > > > > #254
> > > > > > * CB-10443 Pass original options instead of remaining
> > > > > > * CB-10443 Fix `this.root` null reference
> > > > > > * CB-10421 Fixes exception when calling run script with --help
> > > > > > option
> > > > > > * updated .gitignore
> > > > > > * CB-10406 Fixes an exception, thrown when building using Ant.
> > > > > > This
> > > > > closes
> > > > > > #250
> > > > > > * CB-10157 Uninstall app from device/emulator only when signed
> > > > > > apk is already installed
> > > > > >
> > > > >
> > > >
> > >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>


RE: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-24 Thread Nikhil Khandelwal
These commands look great - it will be good to add them to release process docs 
if they are not already there.

-Nikhil

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Wednesday, February 24, 2016 10:03 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release

Definitely. Already committed the update.

My new strategy with bundled/checked in dependencies

* update package.json dep version if required
* rm -rf node_modules
* npm install --production (skips dev dependencies)
* git add node_modules/* (checkin all modules needed for platform add git
url)
* git commit
* npm install (Readd dev dependencies for ability to run tests locally)



On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) < 
v-vlk...@microsoft.com> wrote:

> Steve, do you plan to update bundled `cordova-common` as a part of 
> this release?
>
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Wednesday, February 24, 2016 8:12 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>
> Issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%40064d
> .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86f141
> af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRYxXdH
> fE%3d
>
> I'm going to make this version 5.1.1. I'll update here if I decide to 
> go with 5.2.0 instead.
>
> On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser <bows...@gmail.com> wrote:
>
> > OK, are we sure we didn't add any new minor features?
> >
> > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill 
> > <stevengil...@gmail.com>
> > wrote:
> >
> > > Well we should be following semver.
> > >
> > >
> > >- Bug fixes and other minor changes: Patch release, increment 
> > > the
> last
> > >number, e.g. 1.0.1
> > >- New features which don't break existing features: Minor release,
> > >increment the middle number, e.g. 1.1.0
> > >- Changes which break backwards compatibility: Major release,
> > increment
> > >the first number, e.g. 2.0.0
> > >
> > >
> > > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana 
> > > <csantan...@gmail.com>
> > > wrote:
> > >
> > > > +1 to wait for cordova-common, then to platforms
> > > >
> > > >
> > > >
> > > > On Tue, Feb 16, 2016 at 7:48 PM Steven Gill 
> > > > <stevengil...@gmail.com>
> > > > wrote:
> > > >
> > > > > Any issues with me starting this release?
> > > > >
> > > > > I think I will wait for the cordova-common release to finish 
> > > > > so I can bundle it in.
> > > > >
> > > > > Changes:
> > > > > * CB-10510: Add an optional timeout to emu start script
> > > > > * CB-10498: Resume event should be sticky if it has a plugin 
> > > > > result
> > > > > * fix HtmlNotFoundTest so that it passes when file not found 
> > > > > is
> > handled
> > > > > correctly This Closes #256
> > > > > * CB-10472 NullPointerException:
> > > > > org.apache.cordova.PluginManager.onSaveInstanceState check if
> > > > pluginManager
> > > > > is null before using it This closes #255
> > > > > * CB-10138 Adds missing plugin metadata to plugin_list module.
> > > > > This
> > > > closes
> > > > > #254
> > > > > * CB-10443 Pass original options instead of remaining
> > > > > * CB-10443 Fix `this.root` null reference
> > > > > * CB-10421 Fixes exception when calling run script with --help 
> > > > > option
> > > > > * updated .gitignore
> > > > > * CB-10406 Fixes an exception, thrown when building using Ant.
> > > > > This
> > > > closes
> > > > > #250
> > > > > * CB-10157 Uninstall app from device/emulator only when signed 
> > > > > apk is already installed
> > > > >
> > > >
> > >
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-24 Thread Steven Gill
Definitely. Already committed the update.

My new strategy with bundled/checked in dependencies

* update package.json dep version if required
* rm -rf node_modules
* npm install --production (skips dev dependencies)
* git add node_modules/* (checkin all modules needed for platform add git
url)
* git commit
* npm install (Readd dev dependencies for ability to run tests locally)



On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> Steve, do you plan to update bundled `cordova-common` as a part of this
> release?
>
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Wednesday, February 24, 2016 8:12 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>
> Issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86f141af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRYxXdHfE%3d
>
> I'm going to make this version 5.1.1. I'll update here if I decide to go
> with 5.2.0 instead.
>
> On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser <bows...@gmail.com> wrote:
>
> > OK, are we sure we didn't add any new minor features?
> >
> > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> >
> > > Well we should be following semver.
> > >
> > >
> > >- Bug fixes and other minor changes: Patch release, increment the
> last
> > >number, e.g. 1.0.1
> > >- New features which don't break existing features: Minor release,
> > >increment the middle number, e.g. 1.1.0
> > >- Changes which break backwards compatibility: Major release,
> > increment
> > >the first number, e.g. 2.0.0
> > >
> > >
> > > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana
> > > <csantan...@gmail.com>
> > > wrote:
> > >
> > > > +1 to wait for cordova-common, then to platforms
> > > >
> > > >
> > > >
> > > > On Tue, Feb 16, 2016 at 7:48 PM Steven Gill
> > > > <stevengil...@gmail.com>
> > > > wrote:
> > > >
> > > > > Any issues with me starting this release?
> > > > >
> > > > > I think I will wait for the cordova-common release to finish so
> > > > > I can bundle it in.
> > > > >
> > > > > Changes:
> > > > > * CB-10510: Add an optional timeout to emu start script
> > > > > * CB-10498: Resume event should be sticky if it has a plugin
> > > > > result
> > > > > * fix HtmlNotFoundTest so that it passes when file not found is
> > handled
> > > > > correctly This Closes #256
> > > > > * CB-10472 NullPointerException:
> > > > > org.apache.cordova.PluginManager.onSaveInstanceState check if
> > > > pluginManager
> > > > > is null before using it This closes #255
> > > > > * CB-10138 Adds missing plugin metadata to plugin_list module.
> > > > > This
> > > > closes
> > > > > #254
> > > > > * CB-10443 Pass original options instead of remaining
> > > > > * CB-10443 Fix `this.root` null reference
> > > > > * CB-10421 Fixes exception when calling run script with --help
> > > > > option
> > > > > * updated .gitignore
> > > > > * CB-10406 Fixes an exception, thrown when building using Ant.
> > > > > This
> > > > closes
> > > > > #250
> > > > > * CB-10157 Uninstall app from device/emulator only when signed
> > > > > apk is already installed
> > > > >
> > > >
> > >
> >
>


RE: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-24 Thread Vladimir Kotikov (Akvelon)
Steve, do you plan to update bundled `cordova-common` as a part of this release?

-
Best regards, Vladimir

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Wednesday, February 24, 2016 8:12 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release

Issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86f141af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRYxXdHfE%3d

I'm going to make this version 5.1.1. I'll update here if I decide to go with 
5.2.0 instead.

On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser <bows...@gmail.com> wrote:

> OK, are we sure we didn't add any new minor features?
>
> On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
> > Well we should be following semver.
> >
> >
> >- Bug fixes and other minor changes: Patch release, increment the last
> >number, e.g. 1.0.1
> >- New features which don't break existing features: Minor release,
> >increment the middle number, e.g. 1.1.0
> >- Changes which break backwards compatibility: Major release,
> increment
> >the first number, e.g. 2.0.0
> >
> >
> > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana 
> > <csantan...@gmail.com>
> > wrote:
> >
> > > +1 to wait for cordova-common, then to platforms
> > >
> > >
> > >
> > > On Tue, Feb 16, 2016 at 7:48 PM Steven Gill 
> > > <stevengil...@gmail.com>
> > > wrote:
> > >
> > > > Any issues with me starting this release?
> > > >
> > > > I think I will wait for the cordova-common release to finish so 
> > > > I can bundle it in.
> > > >
> > > > Changes:
> > > > * CB-10510: Add an optional timeout to emu start script
> > > > * CB-10498: Resume event should be sticky if it has a plugin 
> > > > result
> > > > * fix HtmlNotFoundTest so that it passes when file not found is
> handled
> > > > correctly This Closes #256
> > > > * CB-10472 NullPointerException:
> > > > org.apache.cordova.PluginManager.onSaveInstanceState check if
> > > pluginManager
> > > > is null before using it This closes #255
> > > > * CB-10138 Adds missing plugin metadata to plugin_list module. 
> > > > This
> > > closes
> > > > #254
> > > > * CB-10443 Pass original options instead of remaining
> > > > * CB-10443 Fix `this.root` null reference
> > > > * CB-10421 Fixes exception when calling run script with --help 
> > > > option
> > > > * updated .gitignore
> > > > * CB-10406 Fixes an exception, thrown when building using Ant. 
> > > > This
> > > closes
> > > > #250
> > > > * CB-10157 Uninstall app from device/emulator only when signed 
> > > > apk is already installed
> > > >
> > >
> >
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-24 Thread Steven Gill
Issue: https://issues.apache.org/jira/browse/CB-10687

I'm going to make this version 5.1.1. I'll update here if I decide to go
with 5.2.0 instead.

On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser  wrote:

> OK, are we sure we didn't add any new minor features?
>
> On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill 
> wrote:
>
> > Well we should be following semver.
> >
> >
> >- Bug fixes and other minor changes: Patch release, increment the last
> >number, e.g. 1.0.1
> >- New features which don't break existing features: Minor release,
> >increment the middle number, e.g. 1.1.0
> >- Changes which break backwards compatibility: Major release,
> increment
> >the first number, e.g. 2.0.0
> >
> >
> > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana 
> > wrote:
> >
> > > +1 to wait for cordova-common, then to platforms
> > >
> > >
> > >
> > > On Tue, Feb 16, 2016 at 7:48 PM Steven Gill 
> > > wrote:
> > >
> > > > Any issues with me starting this release?
> > > >
> > > > I think I will wait for the cordova-common release to finish so I can
> > > > bundle it in.
> > > >
> > > > Changes:
> > > > * CB-10510: Add an optional timeout to emu start script
> > > > * CB-10498: Resume event should be sticky if it has a plugin result
> > > > * fix HtmlNotFoundTest so that it passes when file not found is
> handled
> > > > correctly This Closes #256
> > > > * CB-10472 NullPointerException:
> > > > org.apache.cordova.PluginManager.onSaveInstanceState check if
> > > pluginManager
> > > > is null before using it This closes #255
> > > > * CB-10138 Adds missing plugin metadata to plugin_list module. This
> > > closes
> > > > #254
> > > > * CB-10443 Pass original options instead of remaining
> > > > * CB-10443 Fix `this.root` null reference
> > > > * CB-10421 Fixes exception when calling run script with --help option
> > > > * updated .gitignore
> > > > * CB-10406 Fixes an exception, thrown when building using Ant. This
> > > closes
> > > > #250
> > > > * CB-10157 Uninstall app from device/emulator only when signed apk is
> > > > already installed
> > > >
> > >
> >
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-17 Thread Steven Gill
Well we should be following semver.


   - Bug fixes and other minor changes: Patch release, increment the last
   number, e.g. 1.0.1
   - New features which don't break existing features: Minor release,
   increment the middle number, e.g. 1.1.0
   - Changes which break backwards compatibility: Major release, increment
   the first number, e.g. 2.0.0


On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana 
wrote:

> +1 to wait for cordova-common, then to platforms
>
>
>
> On Tue, Feb 16, 2016 at 7:48 PM Steven Gill 
> wrote:
>
> > Any issues with me starting this release?
> >
> > I think I will wait for the cordova-common release to finish so I can
> > bundle it in.
> >
> > Changes:
> > * CB-10510: Add an optional timeout to emu start script
> > * CB-10498: Resume event should be sticky if it has a plugin result
> > * fix HtmlNotFoundTest so that it passes when file not found is handled
> > correctly This Closes #256
> > * CB-10472 NullPointerException:
> > org.apache.cordova.PluginManager.onSaveInstanceState check if
> pluginManager
> > is null before using it This closes #255
> > * CB-10138 Adds missing plugin metadata to plugin_list module. This
> closes
> > #254
> > * CB-10443 Pass original options instead of remaining
> > * CB-10443 Fix `this.root` null reference
> > * CB-10421 Fixes exception when calling run script with --help option
> > * updated .gitignore
> > * CB-10406 Fixes an exception, thrown when building using Ant. This
> closes
> > #250
> > * CB-10157 Uninstall app from device/emulator only when signed apk is
> > already installed
> >
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-17 Thread Carlos Santana
+1 to wait for cordova-common, then to platforms



On Tue, Feb 16, 2016 at 7:48 PM Steven Gill  wrote:

> Any issues with me starting this release?
>
> I think I will wait for the cordova-common release to finish so I can
> bundle it in.
>
> Changes:
> * CB-10510: Add an optional timeout to emu start script
> * CB-10498: Resume event should be sticky if it has a plugin result
> * fix HtmlNotFoundTest so that it passes when file not found is handled
> correctly This Closes #256
> * CB-10472 NullPointerException:
> org.apache.cordova.PluginManager.onSaveInstanceState check if pluginManager
> is null before using it This closes #255
> * CB-10138 Adds missing plugin metadata to plugin_list module. This closes
> #254
> * CB-10443 Pass original options instead of remaining
> * CB-10443 Fix `this.root` null reference
> * CB-10421 Fixes exception when calling run script with --help option
> * updated .gitignore
> * CB-10406 Fixes an exception, thrown when building using Ant. This closes
> #250
> * CB-10157 Uninstall app from device/emulator only when signed apk is
> already installed
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-17 Thread Joe Bowser
It should be 5.2.0.  I think we should reserve .1 releases for security
fixes and release screw-ups only.

On Wed, Feb 17, 2016 at 10:07 AM, Steven Gill 
wrote:

> Thoughts on this? Some people on slack are asking if they should be 5.1.1
> instead of 5.2.0.
>
> On Tue, Feb 16, 2016 at 4:47 PM, Steven Gill 
> wrote:
>
> > Any issues with me starting this release?
> >
> > I think I will wait for the cordova-common release to finish so I can
> > bundle it in.
> >
> > Changes:
> > * CB-10510: Add an optional timeout to emu start script
> > * CB-10498: Resume event should be sticky if it has a plugin result
> > * fix HtmlNotFoundTest so that it passes when file not found is handled
> > correctly This Closes #256
> > * CB-10472 NullPointerException:
> > org.apache.cordova.PluginManager.onSaveInstanceState check if
> pluginManager
> > is null before using it This closes #255
> > * CB-10138 Adds missing plugin metadata to plugin_list module. This
> closes
> > #254
> > * CB-10443 Pass original options instead of remaining
> > * CB-10443 Fix `this.root` null reference
> > * CB-10421 Fixes exception when calling run script with --help option
> > * updated .gitignore
> > * CB-10406 Fixes an exception, thrown when building using Ant. This
> closes
> > #250
> > * CB-10157 Uninstall app from device/emulator only when signed apk is
> > already installed
> >
>


Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-02-17 Thread Steven Gill
Thoughts on this? Some people on slack are asking if they should be 5.1.1
instead of 5.2.0.

On Tue, Feb 16, 2016 at 4:47 PM, Steven Gill  wrote:

> Any issues with me starting this release?
>
> I think I will wait for the cordova-common release to finish so I can
> bundle it in.
>
> Changes:
> * CB-10510: Add an optional timeout to emu start script
> * CB-10498: Resume event should be sticky if it has a plugin result
> * fix HtmlNotFoundTest so that it passes when file not found is handled
> correctly This Closes #256
> * CB-10472 NullPointerException:
> org.apache.cordova.PluginManager.onSaveInstanceState check if pluginManager
> is null before using it This closes #255
> * CB-10138 Adds missing plugin metadata to plugin_list module. This closes
> #254
> * CB-10443 Pass original options instead of remaining
> * CB-10443 Fix `this.root` null reference
> * CB-10421 Fixes exception when calling run script with --help option
> * updated .gitignore
> * CB-10406 Fixes an exception, thrown when building using Ant. This closes
> #250
> * CB-10157 Uninstall app from device/emulator only when signed apk is
> already installed
>