[GitHub] cordova-plugin-geolocation issue #83: CB-11962: (ios) Added variable NSLocat...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/83
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-geolocation/pull/83/commits/79fc000a503d07ffdf395d30f5e2731b9790df63)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #640: Make more comprehensible the french documentation

[ponsfrilus]

Github user ponsfrilus commented on the issue:

https://github.com/apache/cordova-docs/pull/640
  
@dblotsky @stevengill @akofman thanks guy. I already tried on crowdin 
before I found the github page. Crowdin seems to me to be ardous... Anyhow will 
give it another try when I get some time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #160: When "Content-Type" has "multipart/...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/160
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request #160: When "Content-Type" has "mul...

[asapping99]

GitHub user asapping99 opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/160

When "Content-Type" has "multipart/form-data", should not contain a 
"Content-Length" in the boundary area.



### Platforms affected
platform : ios

### What does this PR do?
"https://www.w3.org/Protocols/rfc1341/7_2_Multipart.html; in the article 
"Multipart Form" of the site, there is no content that ey included the 
"Content-Length" to the "boundary" region, "boundary "in the region," 
Content-Type "," Content-Disposition "and it has been seen to have put," 
Content-Transfer-Encoding "only. Therefore, it is unnecessary source, there is 
a possibility that the bug occurs, it is assumed that the suit is to delete.

### What testing has been done on this change?
Bug you do not check the "Content-Length" of the boundary in the area 
occurred in the services currently under development. Once you apply the 
source, it was Mashi normal operation.

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

…Content-Length" in the boundary area.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/asapping99/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #160


commit 217c1a5ef96caae8ffe7e03f22086a7bc416164a
Author: asapping99 
Date:   2016-10-06T06:39:39Z

When "Content-Type" has "multipart/form-data", should not contain a 
"Content-Length" in the boundary area.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...

[davidbarre]

Github user davidbarre commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/170
  
Hi @TanaseButcaru,

Do you continue to upgrade your unoffical plugin with version 2.3 ?
Or do you consider that version 2.3 of official plugin fix this issues ?

Thanks

--
David



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request #112: FileProxy.js makeNativeURL() will cau...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/112


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request #195: CB-11848 windows: Remove duplicate sl...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/195


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/340
  
If someone knew nothing about Android, and they just fiddled with their 
icons, would this change, or would we have to delete their old drawable for 
this to work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Nightly build #169 for cordova has failed

[Shazron]

cordova-cli test failing:

> cordova@6.4.0-nightly.2016.10.6.4759c467 test
/home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-cli
> node node_modules/jasmine-node/bin/jasmine-node --captureExceptions
--color spec

.Error: Cannot find module 'dependency-ls'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object.
(/home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-lib/cordova-fetch/index.js:24:13)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)


Not sure what's going on -- but I suspect `npm link` (npm@3) shenanigans


On Wed, Oct 5, 2016 at 7:52 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> Nightly build #169 for cordova has failed.
>
> Please check failure details on build details page at
> https://builds.apache.org/job/cordova-nightly/169/
> You can also take a look at build console: https://builds.apache.org/job/
> cordova-nightly/169/consoleFull
>
> -
> Jenkins for Apache Cordova
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/340
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/340?src=pr) is 
35.15% (diff: 100%)
> Merging 
[#340](https://codecov.io/gh/apache/cordova-android/pull/340?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #340   diff @@
==
  Files12 12  
  Lines  1007   1007  
  Methods 198198  
  Messages  0  0  
  Branches168168  
==
  Hits354354  
  Misses  653653  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[37384c5...9785501](https://codecov.io/gh/apache/cordova-android/compare/37384c583d5a2e5b9b5c5d2cbf150f07f329d16c...97855018e9aeb955f3dd7e31c91fb6b8f67e0c29?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/339
  
OK, so, WTF was that? It appears that we have a test suite problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

[adzellman]

GitHub user adzellman opened a pull request:

https://github.com/apache/cordova-ios/pull/265

CB-11952 - Introduce buildFlag option

### Platforms affected
iOS

### What does this PR do?

- adds buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting

### What testing has been done on this change?

- Added unit tests for build.js
- I have tried this out with by passing various legal and illegal flags 
using the --buildFlag option. I used the xcodebuild man page to develop test 
cases.

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adzellman/aemm-ios CB-11952

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #265


commit e393738fe1f26824555bd090d1e08a725ed75f88
Author: Andrew Zellman 
Date:   2016-10-05T22:14:59Z

CB-11952 - Introduce buildFlag option
- adds buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap

[dpogue]

Github user dpogue commented on the issue:

https://github.com/apache/cordova-android/pull/340
  
If they were specifying icons via config.xml, this should just work.
If they had the platform already installed and had modified files, this 
shouldn't affect those existing files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #339: CB-11964: Do a clean when installing a pl...

[infil00p]

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-android/pull/339

CB-11964: Do a clean when installing a plugin to et around the bug

This is a quick fix for the problem, and it might fix some other build 
errors.  I'm not sure about doing it here, because it might break more stuff, 
but hey, that's what PRs and CI are for. :)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-android PluginInstallClean

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #339


commit 9faf99c1b47abc020cf080d04a179254e60acff4
Author: Joe Bowser 
Date:   2016-10-06T18:41:28Z

CB-11964: Do a clean when installing a plugin to et around the bug




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #340: CB-8722 - Move app icons from drawable to...

[dpogue]

GitHub user dpogue opened a pull request:

https://github.com/apache/cordova-android/pull/340

CB-8722 - Move app icons from drawable to mipmap

https://issues.apache.org/jira/browse/CB-8722

Reasoning behind the change: 
https://androidbycode.wordpress.com/2015/02/14/goodbye-launcher-drawables-hello-mipmaps/

/cc @infil00p 
This probably counts as a breaking change, so we might want to get this 
into 6.0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpogue/cordova-android mipmap

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #340


commit 97855018e9aeb955f3dd7e31c91fb6b8f67e0c29
Author: Darryl Pogue 
Date:   2016-10-06T19:55:26Z

CB-8722 - Move icons from drawable to mipmap




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #496: CB-11936 - Support four new App Transport Sec...

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-lib/pull/496

CB-11936 - Support four new App Transport Security (ATS) keys

### Platforms affected
iOS

### What does this PR do?
This PR is to support the feature in 
https://github.com/apache/cordova-ios/pull/264

### What testing has been done on this change?

Extensive unit tests in the cordova-ios platform.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-lib CB-11936

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #496


commit a5c780aa19802c0c429a33f0ebe2610d22e0f4a6
Author: Shazron Abdullah 
Date:   2016-10-06T17:29:29Z

CB-11936 - Support four new App Transport Security (ATS) keys




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-dialogs issue #88: /!\ Alert on startapp

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-dialogs/pull/88
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-dialogs/pull/88/commits/6606fcb6389be8973eeed1d30166fb7e34505496)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/42//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #496: CB-11936 - Support four new App Transport Security (...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/496
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/496?src=pr) is 80.38% 
(diff: 100%)
> Merging [#496](https://codecov.io/gh/apache/cordova-lib/pull/496?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #496   diff @@
==
  Files67 67  
  Lines  5184   5184  
  Methods 835835  
  Messages  0  0  
  Branches   1005   1005  
==
  Hits   4167   4167  
  Misses 1017   1017  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[97e98ed...a5c780a](https://codecov.io/gh/apache/cordova-lib/compare/97e98ed9ae4d55f815bc0ee6300d1ce9f3fde55a...a5c780aa19802c0c429a33f0ebe2610d22e0f4a6?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #496: CB-11936 - Support four new App Transport Sec...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/496


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #190: CB-11955 (osx) Added Initial OSX pla...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/190
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/190/commits/804cec3e3f15544ef105630b358f3ded8b2aaa52)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #496: CB-11936 - Support four new App Transport Security (...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-lib/pull/496
  
This needs to go into the next cordova-common release, that will go into 
the cordova-ios platform, before cordova-ios 4.3.0 is released.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #648: CB-11936 - Add docs for the four new App Transport ...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-docs/pull/648
  
Only pull in for *cordova-ios 4.3.0* release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #263: CB-11952 - Introduce buildFlag option

[adzellman]

Github user adzellman closed the pull request at:

https://github.com/apache/cordova-ios/pull/263


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #263: CB-11952 - Introduce buildFlag option

[adzellman]

Github user adzellman commented on the issue:

https://github.com/apache/cordova-ios/pull/263
  
I'm going to clean this up and submit a new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #264: CB-11936 - Support four new App Transport Security (...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/264
  
The tests are expected to fail. 

Depends on https://github.com/apache/cordova-lib/pull/496 cordova-common 
being pulled into this repo first. Once that is done, rebase, squash, and the 
tests should pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #190: CB-11955 (osx) Added Initial ...

[pwlin]

GitHub user pwlin opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/190

CB-11955 (osx) Added Initial OSX platform support

### Platforms affected
OSX

### What does this PR do?
It adds preliminary support for OSX platform

### What testing has been done on this change?
Running `npm test` on this changes shows no error.

### Checklist
- [ x] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

- Added src/osx plugin folder structure.
- Added OSX platform to plugin.xml and package.json files.
- Added _system target functionality for OSX.
- Modified README.md to include information about OSX support.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pwlin/cordova-plugin-inappbrowser 
CB-11955cordova-plugin-inappbrowser

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #190


commit 804cec3e3f15544ef105630b358f3ded8b2aaa52
Author: pwlin 
Date:   2016-10-06T16:39:10Z

CB-11955 Added Initial OSX platform support

- Added src/osx plugin folder structure.
- Added OSX platform to plugin.xml and package.json files.
- Added _system target functionality for OSX.
- Modified README.md to include information about OSX support.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-dialogs issue #88: /!\ Alert on startapp

[jcesarmobile]

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-dialogs/pull/88
  
Hi.
You have created a pull request by mistake.
Can you please close it and ask on stack overflow or cordova slack?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request #130: Fix CB-3785 - enable EventListener interface s...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/130


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/339
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/339?src=pr) is 
34.85% (diff: 45.45%)
> Merging 
[#339](https://codecov.io/gh/apache/cordova-android/pull/339?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will decrease coverage by **0.30%**

```diff
@@ master   #339   diff @@
==
  Files12 13 +1   
  Lines  1007   1142   +135   
  Methods 198219+21   
  Messages  0  0  
  Branches168186+18   
==
+ Hits354398+44   
- Misses  653744+91   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[37384c5...333b30f](https://codecov.io/gh/apache/cordova-android/compare/37384c583d5a2e5b9b5c5d2cbf150f07f329d16c...333b30f3961fc269cda064c7f8ff3812fdc4a9ca?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
do you have a usecase example when remove might be useful?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
`remove` wouldn't be a revert right. Since you have no way to store what 
got overwritten/merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request #136: handleEvent for addEventListener

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/136


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js issue #136: handleEvent for addEventListener

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-js/pull/136
  
This has been implemented in #130 
Please close.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js issue #130: Fix CB-3785 - enable EventListener interface support

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-js/pull/130
  
Thanks @rayshan! Sorry it took so long to merge. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
@ktop so if I remove an `edit-config` tag from my `config.xml`, it won't 
actually remove it from `AndroidManifest.xml`. Guessing the solution for users 
in this case would be to rm and re-add the android platform. That seems fine to 
me. 

This is only for merging and overwriting. For adding new elements, we 
should use `config-file` still?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/265
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-ios/pull/265?src=pr) is 59.92% 
(diff: 97.67%)
> Merging [#265](https://codecov.io/gh/apache/cordova-ios/pull/265?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) 
will increase coverage by **3.41%**

```diff
@@ master   #265   diff @@
==
  Files12 12  
  Lines  1230   1280+50   
  Methods 198200 +2   
  Messages  0  0  
  Branches193216+23   
==
+ Hits695767+72   
+ Misses  535513-22   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[636113f...e393738](https://codecov.io/gh/apache/cordova-ios/compare/636113f047ee2c7dae742dff2beafae2121ceb62...e393738fe1f26824555bd090d1e08a725ed75f88?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

[Steven Gill]

Hey Everyone!

So I decided to dig into this and wanted to summarize my findings. Please
correct me if I'm wrong.

1)  is a new tag that allows us to *merge* or *overwrite*
elements in config files. it only supports editing *one* element per block
of edit-config. If you need multiple edits, you will have to use multiple
edit-configs.

edit-config is available in plugin.xml and soon to be available in
config.xml.

For plugins, edit-config can handle conflicts with other plugin's
edit-config tags. It does this by warning the user about the conflict and
not installing the plugin. It recommends users use --force when installing
to give preference to the new plugin's edit-config tag. Tags that are
overwritten or merged will store a copy of the original in platform.json,
so we can easily revert back if we need to.

For config.xml, edit-config takes precedence over plugin's edit-config.
This way, a user can override a change a plugin is trying to make. There is
*no* ability to *revert* edit-config changes. Essentially need to rm and
add the platform.

2)  is used in plugin.xml to *add* new elements to config
files. No reverting. Can add *multiple* lines at once. Not available in
config.xml

The crazy thing is, this discussion started out as a way for users to
*add* elements
to their config files from config.xml. So we really need to add config-file
support to config.xml. New issue for this:
https://issues.apache.org/jira/browse/CB-11968. Anyone want to work on it?

In the future, lets try to bring a summary like this back to the list and
have a cordova-discuss thread about it.

* original discussion (not merged):
https://github.com/apache/cordova-lib/pull/432
* edit-config plugin.xml pr + discussion (merged & shipped):
https://github.com/apache/cordova-lib/pull/449
* edit-config config.xml pr + discussion (about to merge):
https://github.com/apache/cordova-lib/pull/492 &
https://github.com/apache/cordova-lib/pull/493
* issues: (edit-config plugin.xml)
https://issues.apache.org/jira/browse/CB-11023 & (edit-config config.xml)
https://issues.apache.org/jira/browse/CB-11908 & (config-file config.xml)
https://issues.apache.org/jira/browse/CB-11968







On Fri, Sep 2, 2016 at 6:16 PM, Simon MacDonald 
wrote:

> I'm confused what's not being covered? The edit-config tag which can be
> used from either plugin.xml or config.xml should be able to add new tags
> into an xml document as well as edit existing tags/attributes in an xml
> document.
>
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
> On Fri, Sep 2, 2016 at 5:00 PM, Joe Bowser  wrote:
>
> > Reviving this thread:
> >
> > So, it seems that a lot of us thought that the plugin.xml changes would
> fix
> > our problem, in fact they haven't because of what Julio just mentioned.
> > Right now a lot of the PRs that we're getting are to add extra settings.
> > I'm tempted to just merge them since we still don't have a solution to
> > this.  Does someone want to come up with something, or should I just do
> it.
> >
> > On Thu, Jul 21, 2016 at 2:34 PM, julio cesar sanchez <
> > jcesarmob...@gmail.com
> > > wrote:
> >
> > > That issue is about adding an attribute to an existing element of the
> > > AndroidManifest from plugin.xml, this topic is about adding the whole
> > > functionality of writing/editing the .xml/.plist files from config.xml
> > > instead of using a "silly" plugin
> > >
> > > 2016-07-21 23:24 GMT+02:00 Jesse :
> > >
> > > > CB-11023 is what it was submitted under. afaik
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > @purplecabbage
> > > > risingj.com
> > > >
> > > > On Thu, Jul 21, 2016 at 2:22 PM, julio cesar sanchez <
> > > > jcesarmob...@gmail.com
> > > > > wrote:
> > > >
> > > > > We still don't have an issue for this, right?
> > > > >
> > > > > I've been searching and found those three:
> > > > >
> > > > > https://issues.apache.org/jira/browse/CB-7232 (iOS)
> > > > > https://issues.apache.org/jira/browse/CB-11604 (Android)
> > > > > https://issues.apache.org/jira/browse/CB-10832 (Windows)
> > > > >
> > > > >
> > > > >
> > > > > 2016-04-29 17:13 GMT+02:00 Karen Tran :
> > > > >
> > > > > > Can I get someone to review my PR?
> > > > > > https://github.com/apache/cordova-lib/pull/432
> > > > > >
> > > > > > Thanks,
> > > > > > Karen Tran
> > > > > >
> > > > > > On Thu, Apr 21, 2016 at 11:02 AM, Vladimir Kotikov (Akvelon) <
> > > > > > v-vlk...@microsoft.com> wrote:
> > > > > >
> > > > > > > Exactly. Multiple tags is also possible with this syntax.
> > > > > > >
> > > > > > > -
> > > > > > > Best regards, Vladimir
> > > > > > >
> > > > > > > -Original Message-
> > > > > > > From: Karen Tran [mailto:ktop...@gmail.com]
> > > > > > > Sent: Thursday, April 21, 2016 5:20 PM
> > > > > > > To: dev@cordova.apache.org
> > > > > > > Subject: Re: [Android] Need a solution to config.xml and
> > > > > > > AndroidManifest.xml feature requests
> > > > > > >
> > > > > 

[GitHub] cordova-js issue #130: Fix CB-3785 - enable EventListener interface support

[rayshan]

Github user rayshan commented on the issue:

https://github.com/apache/cordova-js/pull/130
  
Yay! No worries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #493: CB-11908 Handle edit-config in config.xml on ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/493


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #492: CB-11908 Add edit-config to config.xml

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/492


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #491: CB-11776 Add test case for different edit-config tar...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/491
  
Thanks @ktop! Merged!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #491: CB-11776 Add test case for different edit-con...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/491


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #487: CB-11777: Restore plugins before preparing

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/487
  
Nice investigating @dpogue! 

Good point about the hook order changing. My gut says it should be fine. 
Would that be a considered a major change is the question. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] Cordova-common@1.5.0 Release

[Steven Gill]

Please review and vote on this cordova-common Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-11969

Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11969/

The packages were published from their corresponding git tags:

cordova-lib: common-1.5.0 (0b56f9c6e5)

Upon a successful vote I will upload the archives to dist/, publish
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran npm test

[GitHub] cordova-lib issue #487: CB-11777: Restore plugins before preparing

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/487
  
Guess this won't matter if we rip restore out of prepare!

https://github.com/cordova/cordova-discuss/pull/54


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
I'm going to merge this in for now so I can get the common release out. But 
it is definitely worth discussing some of these points. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #170 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #170 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/170/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
Thanks for sending this pr @ktop! I've merged it in. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #336: CB-11907: Upgrading the Gradle Plugins so they w...

[alsorokin]

Github user alsorokin commented on the issue:

https://github.com/apache/cordova-android/pull/336
  
Looks like updating the gradle has introduced a nasty bug:
https://issues.apache.org/jira/browse/CB-11964


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-dialogs pull request #88: /!/Alert on startapp

[jedofus]

GitHub user jedofus opened a pull request:

https://github.com/apache/cordova-plugin-dialogs/pull/88

/!/Alert on startapp

Hello , i have problem since i updated platform ios on cordova .
i use this code on my onDeviceready() 
`   if (navigator.notification) { // Override default HTML alert 
with native dialog
window.alert = function (message) {
  navigator.notification.alert(
  message,// message
  null,   // callback
  getText('application-title'), // title
  getText('ok')// buttonName
  );
 };
}`
no problem before update. But after update ios platform and this plugin , i 
always have an alert with message "1" . I do not know how to remove this alert 
. Can anyone solve my problem?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cordova-plugin-dialogs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-dialogs/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit 5ecb3506e0de87d0465713857af132e68c543f00
Author: Kevin Boosten 
Date:   2016-08-16T07:34:00Z

Make sure the alert buttonLabel is a string

commit 02a424255b601a64fc2c5d5c4f5ff4b31a0cd5c5
Author: Jesse MacFadyen 
Date:   2016-09-09T20:38:33Z

Added test for [windows] CB-11281 when called without defaultText

commit 542e7f7c9f9b5a6d9af48f71549c7d988f91145a
Author: Steve Gill 
Date:   2016-09-09T23:08:04Z

CB-11832 Incremented plugin version.

commit 9a19139eefb0981a178f531cd502bfdd08233c83
Author: Steve Gill 
Date:   2016-09-09T23:27:11Z

Merge branch 'master' of 
https://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs

commit 5ebefa82d5220b4525602b3c38e9198095f80d8c
Author: Jesse MacFadyen 
Date:   2016-09-09T23:05:38Z

Add enter key handling and map to default button.

commit 68ceff4d0ef5c5de9144d09d7a05712c439951c1
Author: Jesse MacFadyen 
Date:   2016-09-09T23:27:49Z

Fix dumb linting error

commit d34092cd37c386b02d836c9cac5c14b38415e111
Author: Jesse MacFadyen 
Date:   2016-09-09T23:34:23Z

Close #86

commit 137fa7c84cc909577584a9f55ca1f37e9db031b7
Author: Jesse MacFadyen 
Date:   2016-09-10T00:26:06Z

Merge branch 'master' of https://github.com/Boosten/cordova-plugin-dialogs

commit 2b732482a5cf9dc4814dcb22cf5fc6a94ee652ba
Author: Jesse MacFadyen 
Date:   2016-09-10T00:37:07Z

Replace empty buttonLabel with 'OK'

commit baee8130920a74514fd809808b1939b3fbfa94af
Author: Jesse MacFadyen 
Date:   2016-09-10T00:45:36Z

Close #43

commit 6606fcb6389be8973eeed1d30166fb7e34505496
Author: Shazron Abdullah 
Date:   2016-09-28T08:33:44Z

CB-11917 - Remove pull request template checklist item: "iCLA has been 
submitted…"

 This closes #87




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org