[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

2017-05-19 Thread MeirBon 
Github user MeirBon commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/201
  
I have created a new [pull 
request](https://github.com/apache/cordova-plugin-inappbrowser/pull/221), 
because this one didn't follow the guidelines. I have also created an issue on 
[Jira](https://issues.apache.org/jira/browse/CB-12834). I think this pull 
request can be closed and we should move on from mine. 

I have used your changes @jonasof and hope we can get this merged. I 
haven't had time to look into making the storage permissions optional, might 
look into that some other time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #221: CB-12834: (android) Fix bug w...

2017-05-19 Thread MeirBon 
GitHub user MeirBon opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/221

CB-12834: (android) Fix bug when opening a download link

### Platforms affected
Android

### What does this PR do?
It adds a dialog to request permissions when a file is downloaded in the 
inappbrowser. I have committed the changes using the given format, original 
changes are from [this pull 
request](https://github.com/apache/cordova-plugin-inappbrowser/pull/201)

### What testing has been done on this change?
Multiple Android devices have been tested. Different download links, 
cancelling the download then re-downloading.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MeirBon/cordova-plugin-inappbrowser 
download-permissions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #221


commit d246092d1a066160aa4f3a4e5424b255d1550076
Author: Mèir Noordermeer 
Date:   2017-05-19T09:26:29Z

CB-12834: (android) Fix bug when opening a download link




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

2017-05-19 Thread ivanrb 
Github user ivanrb commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/201
  
@MeirBon @jonasof Thanks for your collaboration =D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #221: CB-12834: (android) Fix bug when ope...

2017-05-19 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/221
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/221/commits/d246092d1a066160aa4f3a4e5424b255d1550076)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/145/)

 36 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

2017-05-19 Thread Gorebar 
Github user Gorebar commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/201
  
@MeirBon @jonasof @ivanrb Nice Job!! Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #349 for cordova has succeeded!

2017-05-19 Thread Apache Jenkins Server 
Nightly build #349 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/349/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #67: CB-12024: Browser platform support

2017-05-19 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/67
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/67/commits/e09ada003bb1e413596639038cec2de42948003f)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/55/)

 24 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #67: CB-12024: Browser platform support

2017-05-19 Thread dudeofawesome 
Github user dudeofawesome commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/67
  
@filmaj I've rebased with master and made the requested changes to the 
README.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #67: CB-12024: Browser platform support

2017-05-19 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/67
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/67/commits/2a3014ec5ffe17fd5e9f420a5e0e3a008995f31e)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/54/)

 24 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org