Re: [VOTE] Release Apache CouchDB 3.2.0

2021-09-29 Thread Dave Cottlehuber
On Mon, 27 Sep 2021, at 22:59, Nick Vatamaniuc wrote:
> Dear community,
>
> I would like to propose that we release Apache CouchDB 3.2.0.
>
> Candidate release notes:
>
> https://docs.couchdb.org/en/latest/whatsnew/3.2.html
>
> We encourage the whole community to download and test these release
> artefacts so that any critical issues can be resolved before the
> release is made. Everyone is free to vote on this release, so dig
> right in! (Only PMC members have binding votes, but they depend on
> community feedback to gauge if an official release is ready to be
> made.)
>
> The release artefacts we are voting on are available here:
>
> https://dist.apache.org/repos/dist/dev/couchdb/source/3.2.0/rc.1/
>
> There, you will find a tarball, a GPG signature, and SHA256/SHA512 checksums.
>
> Please follow the test procedure here:
>
> 
> https://cwiki.apache.org/confluence/display/COUCHDB/Testing+a+Source+Release
>
> Please remember that "RC1" is an annotation. If the vote passes, these
> artefacts will be released as Apache CouchDB 3.2.0.
>
> Please cast your votes now.
>
> Thanks,
> -Nick

-1

But with Jan and Nick's help we have a nice little patch for this:

https://github.com/apache/couchdb/pull/3770

- FreeBSD 13.0-RELEASE p4 amd64
- elixir 1.12.3
- erlang 24.0.6
- spidermonkey 78
- python3.8.12
- default CC (clang 11.0.1)

After applying the patch I get this error from prometheus tests:

couch_prometheus_e2e_tests:109: deny_prometheus_http...*failed*
in function couch_prometheus_e2e_tests:'-deny_prometheus_http/1-fun-1-'/1 
(test/eunit/couch_prometheus_e2e_tests.erl, line 109)
in call from eunit_test:run_testfun/1 (eunit_test.erl, line 71)
in call from eunit_proc:run_test/1 (eunit_proc.erl, line 522)
in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 347)
in call from eunit_proc:handle_test/2 (eunit_proc.erl, line 505)
in call from eunit_proc:tests_inorder/3 (eunit_proc.erl, line 447)
in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 337)
in call from eunit_proc:run_group/2 (eunit_proc.erl, line 561)
**error:{assertEqual,[{module,couch_prometheus_e2e_tests},
  {line,109},
  {expression,"Response"},
  {expected,{error,{conn_failed,{error,econnrefused,
  {value,{error,req_timedout}}]}
  output:<<"">>

couch_prometheus_e2e_tests:80: node_see_updated_metrics...ok
[done in 31.151 s]
  [done in 32.485 s]

A+
Dave


Re: [VOTE] Release Apache CouchDB 3.2.0

2021-09-29 Thread Joan Touzet



On 29/09/2021 01:03, Nick Vatamaniuc wrote:
> Thanks for checking, Joan.
> 
> What version of Erlang was it?

20.3.8.25.

> I recall we excluded erl_interface from rebar and enc (port compiler)
> so we could compile on Erlang 23+, but I don't think we ever updated
> the windows flags:
> 
> A few instances:
> 
>  
> https://github.com/apache/couchdb-rebar/blob/ee85b6920474e6e1b9c1802b092e022720b6b676/src/rebar_port_compiler.erl#L723-L724

This alone wasn't enough, unfortunately.

>  
> https://github.com/davisp/erlang-native-compiler/commit/0302390774db4104bfb46383d2819ed06ce78d1f#diff-fb2f03770e7203b48a9f4581e5bf983c213191888b048438f33e52acfcc42232R745-R746
> 
> Would removing those lines help? Sadly I don't have a Windows dev
> setup to give it a try.

The enc inside of jiffy is the checked-in binary; we haven't fixed that
part of the build yet. So this is going to take more doing than I can do
quickly.

Will look at more after I get some sleep.

> 
> -Nick
> 
> 
> On Tue, Sep 28, 2021 at 8:02 PM Joan Touzet  wrote:
>>
>> Unfortunately, I must vote -1 for 3.2.0. On Windows, I cannot compile
>> the Jiffy we are including in 3.2 anymore due to a linking error:
>>
>>> LINK : fatal error LNK1181: cannot open input file 'erl_interface.lib'
>>
>> This is the same system that just finished compiling and testing 3.1.2,
>> no other changes.
>>
>> I don't have more time for this tonight, so I'll have to investigate
>> tomorrow or later this week.
>>
>> -Joan
>>
>> On 28/09/2021 07:19, Juanjo Rodríguez wrote:
>>> +1
>>>
>>> Tested on Ubuntu 20.04, Erlang 22 and Elixir 1.9.1
>>> Signature: Ok
>>> Checksums: Ok
>>> Tests: (configure --spidermonkey-version 68 make check): Pass
>>>
>>> Additional info: Also pass LightCouch Java Client and Cloudant Sync for
>>> Android test suites.
>>>
>>> Thanks!!
>>>
>>>
>>> El mar, 28 sept 2021 a las 1:00, Nick Vatamaniuc ()
>>> escribió:
>>>
 Dear community,

 I would like to propose that we release Apache CouchDB 3.2.0.

 Candidate release notes:

 https://docs.couchdb.org/en/latest/whatsnew/3.2.html

 We encourage the whole community to download and test these release
 artefacts so that any critical issues can be resolved before the
 release is made. Everyone is free to vote on this release, so dig
 right in! (Only PMC members have binding votes, but they depend on
 community feedback to gauge if an official release is ready to be
 made.)

 The release artefacts we are voting on are available here:

 https://dist.apache.org/repos/dist/dev/couchdb/source/3.2.0/rc.1/

 There, you will find a tarball, a GPG signature, and SHA256/SHA512
 checksums.

 Please follow the test procedure here:


 https://cwiki.apache.org/confluence/display/COUCHDB/Testing+a+Source+Release

 Please remember that "RC1" is an annotation. If the vote passes, these
 artefacts will be released as Apache CouchDB 3.2.0.

 Please cast your votes now.

 Thanks,
 -Nick

>>>