Re: [PR] RAT-343: Enhance documentation about new configuration options [creadur-rat]
solomax commented on PR #199: URL: https://github.com/apache/creadur-rat/pull/199#issuecomment-1892969743 @ottlinger Thanks for the additional examples! Everything is very clear :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-348) Update gitignore processor dependency
[ https://issues.apache.org/jira/browse/RAT-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806981#comment-17806981 ] ASF subversion and git services commented on RAT-348: - Commit 42a4f78bfbeba3195dc1bded1e5653b527e5d469 in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=42a4f78b ] RAT-348: Use try-with-resources when reading ignore files > Update gitignore processor dependency > - > > Key: RAT-348 > URL: https://issues.apache.org/jira/browse/RAT-348 > Project: Apache Rat > Issue Type: Improvement > Components: scan >Affects Versions: 0.16 >Reporter: Niels Basjes >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.16.1 > > > Update to latest available version to be able to parse special expressions in > gitignore files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-343) Custom licensenses not working in contrast to v0.15
[ https://issues.apache.org/jira/browse/RAT-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806975#comment-17806975 ] ASF subversion and git services commented on RAT-343: - Commit 7e31d4218de89f07b7dbd4427d44220803f6254a in creadur-rat's branch refs/heads/feature/RAT-343_improveDocs from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=7e31d421 ] RAT-343: Fix typo > Custom licensenses not working in contrast to v0.15 > --- > > Key: RAT-343 > URL: https://issues.apache.org/jira/browse/RAT-343 > Project: Apache Rat > Issue Type: Bug > Components: license-meta-data, scan, site >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > Due to the changes introduced in 0.16 projects with custom license > definitions do not seem to work anymore as reported by [~solomax] with > OpenMeetings: > [https://github.com/apache/openmeetings/blob/master/pom.xml#L1393] > Verify that the documentation provided in > [https://creadur.apache.org/rat/apache-rat-plugin/examples/custom-license.html] > is correct and ideally add an example usage to > [CreadurExamples|https://github.com/ottlinger/creadur-rat-examples] to > prevent future regressions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-352) Enable use of wildcard expressions in exclude file
[ https://issues.apache.org/jira/browse/RAT-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806967#comment-17806967 ] Philipp Ottlinger commented on RAT-352: --- [~nchammas] sorry - I just read your comment on RAT-323. > Enable use of wildcard expressions in exclude file > -- > > Key: RAT-352 > URL: https://issues.apache.org/jira/browse/RAT-352 > Project: Apache Rat > Issue Type: Improvement > Components: cli >Reporter: Nicholas Chammas >Priority: Minor > > Due to the widespread use of git, I would find it much more intuitive if > .rat-excludes worked like .gitignore. I think most people on the Spark > project would agree (though, fair disclosure, I haven't polled them). > Would it make sense to add a CLI option instructing RAT to interpret entries > in the exclude file as wildcard expressions (as opposed to regular > expressions) that work more or less like .gitignore? > This feature request is somewhat related to RAT-265. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-352) Enable use of wildcard expressions in exclude file
[ https://issues.apache.org/jira/browse/RAT-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806966#comment-17806966 ] Philipp Ottlinger commented on RAT-352: --- Thanks for taking the time to report the issue - at the moment we are working on 0.16.1 to fix a breaking change with custom license definitions. Thinking about your request - would it make sense to provide a CLI option that reads a .gitignore instead of a .ratexclude file to allow for your feature request? In 0.16 we integrated an external library that improves exclusion parsing as part of the Maven-based RAT runs. Maybe this feature can be adapted/enhanced to support your use case? Feel free to fork and play around - patches welcome! > Enable use of wildcard expressions in exclude file > -- > > Key: RAT-352 > URL: https://issues.apache.org/jira/browse/RAT-352 > Project: Apache Rat > Issue Type: Improvement > Components: cli >Reporter: Nicholas Chammas >Priority: Minor > > Due to the widespread use of git, I would find it much more intuitive if > .rat-excludes worked like .gitignore. I think most people on the Spark > project would agree (though, fair disclosure, I haven't polled them). > Would it make sense to add a CLI option instructing RAT to interpret entries > in the exclude file as wildcard expressions (as opposed to regular > expressions) that work more or less like .gitignore? > This feature request is somewhat related to RAT-265. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (RAT-352) Enable use of wildcard expressions in exclude file
Nicholas Chammas created RAT-352: Summary: Enable use of wildcard expressions in exclude file Key: RAT-352 URL: https://issues.apache.org/jira/browse/RAT-352 Project: Apache Rat Issue Type: Improvement Components: cli Reporter: Nicholas Chammas Due to the widespread use of git, I would find it much more intuitive if .rat-excludes worked like .gitignore. I think most people on the Spark project would agree (though, fair disclosure, I haven't polled them). Would it make sense to add a CLI option instructing RAT to interpret entries in the exclude file as wildcard expressions (as opposed to regular expressions) that work more or less like .gitignore? This feature request is somewhat related to RAT-265. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-323) Harmonize UIs
[ https://issues.apache.org/jira/browse/RAT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806930#comment-17806930 ] Nicholas Chammas commented on RAT-323: -- Big +1 for enabling the CLI to use SCM ignores as excludes. The Apache Spark project uses RAT via the CLI, and I am currently trying to clean up the configured excludes there because it's a [total mess|https://github.com/apache/spark/blob/c0ff0f579daa21dcc6004058537d275a0dd2920f/dev/.rat-excludes]. This is partly because RAT is not using the project's existing .gitignore files, and partly because people expect .rat-excludes to work the same way as .gitignore. > Harmonize UIs > - > > Key: RAT-323 > URL: https://issues.apache.org/jira/browse/RAT-323 > Project: Apache Rat > Issue Type: Improvement > Components: cli >Affects Versions: 0.16 >Reporter: Claude Warren >Priority: Major > Original Estimate: 168h > Remaining Estimate: 168h > > The UIs (CLI, ANT and Maven) were all developed separately and have different > options. > There is an overlap in some functionality and the functionality of some UIs > is not found in others. > This task is to do two things: > # collect all the UI options, and ensure that they are all supported in the > ReportConfiguration class. > # modify the UIs so that the names of the options are the same (or as > similar as possible) across the three UIs. Renamed methods are to be > deprecated in favour of new methods. > > Example: > apache-rat-plugin has 3 options: parseSCMIgnoresAsExcludes, > useEclipseDefaultExcludes, useIdeaDefaultExcludes that change the file > filter. These are options that would be useful in all UIs and should be > moved to the ReportConfiguration so that any UI can set them. > By harmonization I mean that options like the above are extracted from the > specific UIs where they are implemented and moved to the ReportConfiguration > so that the implementations are in one place and can be shared across all UIs. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-343: Enhance documentation about new configuration options [creadur-rat]
ottlinger commented on PR #199: URL: https://github.com/apache/creadur-rat/pull/199#issuecomment-1892470369 @solomax does the current version contain all your answers or did we miss something? спасибо https://creadur.apache.org/rat0161/apache-rat-plugin/examples/custom-license.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-343) Custom licensenses not working in contrast to v0.15
[ https://issues.apache.org/jira/browse/RAT-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806896#comment-17806896 ] ASF subversion and git services commented on RAT-343: - Commit 5d93657f4450d8697ac02caca28a4207a79aed4b in creadur-rat's branch refs/heads/feature/RAT-343_improveDocs from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=5d93657f ] RAT-343: Explicitly mention that custom licenses need to have unique names > Custom licensenses not working in contrast to v0.15 > --- > > Key: RAT-343 > URL: https://issues.apache.org/jira/browse/RAT-343 > Project: Apache Rat > Issue Type: Bug > Components: license-meta-data, scan, site >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > Due to the changes introduced in 0.16 projects with custom license > definitions do not seem to work anymore as reported by [~solomax] with > OpenMeetings: > [https://github.com/apache/openmeetings/blob/master/pom.xml#L1393] > Verify that the documentation provided in > [https://creadur.apache.org/rat/apache-rat-plugin/examples/custom-license.html] > is correct and ideally add an example usage to > [CreadurExamples|https://github.com/ottlinger/creadur-rat-examples] to > prevent future regressions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-343) Custom licensenses not working in contrast to v0.15
[ https://issues.apache.org/jira/browse/RAT-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806895#comment-17806895 ] ASF subversion and git services commented on RAT-343: - Commit a39638746fa78e518b29cb71be45e2b080c771c7 in creadur-rat's branch refs/heads/feature/RAT-343_improveDocs from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=a3963874 ] Merge pull request #202 from Claudenw/feature/RAT-343_improveDocs updated examples > Custom licensenses not working in contrast to v0.15 > --- > > Key: RAT-343 > URL: https://issues.apache.org/jira/browse/RAT-343 > Project: Apache Rat > Issue Type: Bug > Components: license-meta-data, scan, site >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > Due to the changes introduced in 0.16 projects with custom license > definitions do not seem to work anymore as reported by [~solomax] with > OpenMeetings: > [https://github.com/apache/openmeetings/blob/master/pom.xml#L1393] > Verify that the documentation provided in > [https://creadur.apache.org/rat/apache-rat-plugin/examples/custom-license.html] > is correct and ideally add an example usage to > [CreadurExamples|https://github.com/ottlinger/creadur-rat-examples] to > prevent future regressions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-343: add examples [creadur-rat]
ottlinger merged PR #202: URL: https://github.com/apache/creadur-rat/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-343: add examples [creadur-rat]
ottlinger commented on PR #202: URL: https://github.com/apache/creadur-rat/pull/202#issuecomment-1892456318 Thanks, I fixed the build errors and did some minor changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-346) WARN in case user defined License family has the same name as existing one
[ https://issues.apache.org/jira/browse/RAT-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806879#comment-17806879 ] Philipp Ottlinger commented on RAT-346: --- Thanks for the confirmation - [~claude] anything to be added here or can we close the issue for now? > WARN in case user defined License family has the same name as existing one > -- > > Key: RAT-346 > URL: https://issues.apache.org/jira/browse/RAT-346 > Project: Apache Rat > Issue Type: Improvement > Components: scan >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > Could you please raise WARN in case user defined License family has the same > name as internal one? > It seems user defined one is `just ignored` in such case :( > h2. Architecture remark > I removed the API module because it consisted of a) class files that were not > being used in the code but that were misleading in name; and more importantly > b) because there were a number of test cases that would have been converted > to Junit5 only to be removed again later. > The harmonization is not necessarily the use of a single API module but > rather that the options in each of the UIs should be similarly constructed > (same basic phrasing) not have 2 UIs where one says > "--enable-default-licenses" (default off) and the other says > "--disable-default-licenses" (default on). Also there are options that have > been added to one UI that are general in nature (i.e. not part of managing > the specific platform the UI is on) and are not available in the other UIs. > I will remove the commented out code. I should have before I submitted this > pull request, but skipped it in favor of getting this code change infront of > more eyes quickly. > I also have to make a pass to update javadocs. > @jbonofre Most of the changes in this request are the migration to Junit 5. > The significant changes are the creation of the classes in the o.a.r..utils > directory, the addition of methods to set the associated properties in > ReportConfiguration along with the tests for those classes and changes. > The request was to warn on duplication so the solution submitted does the > following: > Creates a ReportingSet class that is a SortedSet implementation (wrapping > and delegating to a SortedSet). it intercepts the calls to add and addAll to > determine if the new elements are already in the set and take an action. > * If logging is enabled (not set to None on the very thing logging wrapper > Log) write a message about the collision to the log at the specific level. > * If the internal action (ReportingSet.Option) is set to IGNORE the change > is ignored, OVERWRITE the old entry is replaced, FAIL an exception is thrown. > Finally the ReportingSet has an instance variable called duplicateFmt that is > a Function that produces the information to display in the message. > The change to ReportConfiguration are to use ReportingSet to contain the > Licenses and LicenseFamilies, and supporting methods to configure (as noted > above). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-346) WARN in case user defined License family has the same name as existing one
[
https://issues.apache.org/jira/browse/RAT-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806878#comment-17806878
]
Maxim Solodovnik commented on RAT-346:
--
Hello [~pottlinger],
After I run {{mvn clean apache-rat:0.16.1-SNAPSHOT:check -U}}
I can see the following output:
{code}
[WARNING] Parameter 'licenses' is deprecated: No reason given
[WARNING] Duplicate LicenseFamily category: MIT (action: IGNORE)
[WARNING] Duplicate License The MIT License (MIT) of type MIT (action: IGNORE)
{code}
Everything seems to work as expected!
Thanks for the fix!
And sorry for the noise :(
> WARN in case user defined License family has the same name as existing one
> --
>
> Key: RAT-346
> URL: https://issues.apache.org/jira/browse/RAT-346
> Project: Apache Rat
> Issue Type: Improvement
> Components: scan
>Affects Versions: 0.16
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Major
> Fix For: 0.16.1
>
>
> Could you please raise WARN in case user defined License family has the same
> name as internal one?
> It seems user defined one is `just ignored` in such case :(
> h2. Architecture remark
> I removed the API module because it consisted of a) class files that were not
> being used in the code but that were misleading in name; and more importantly
> b) because there were a number of test cases that would have been converted
> to Junit5 only to be removed again later.
> The harmonization is not necessarily the use of a single API module but
> rather that the options in each of the UIs should be similarly constructed
> (same basic phrasing) not have 2 UIs where one says
> "--enable-default-licenses" (default off) and the other says
> "--disable-default-licenses" (default on). Also there are options that have
> been added to one UI that are general in nature (i.e. not part of managing
> the specific platform the UI is on) and are not available in the other UIs.
> I will remove the commented out code. I should have before I submitted this
> pull request, but skipped it in favor of getting this code change infront of
> more eyes quickly.
> I also have to make a pass to update javadocs.
> @jbonofre Most of the changes in this request are the migration to Junit 5.
> The significant changes are the creation of the classes in the o.a.r..utils
> directory, the addition of methods to set the associated properties in
> ReportConfiguration along with the tests for those classes and changes.
> The request was to warn on duplication so the solution submitted does the
> following:
> Creates a ReportingSet class that is a SortedSet implementation (wrapping
> and delegating to a SortedSet). it intercepts the calls to add and addAll to
> determine if the new elements are already in the set and take an action.
> * If logging is enabled (not set to None on the very thing logging wrapper
> Log) write a message about the collision to the log at the specific level.
> * If the internal action (ReportingSet.Option) is set to IGNORE the change
> is ignored, OVERWRITE the old entry is replaced, FAIL an exception is thrown.
> Finally the ReportingSet has an instance variable called duplicateFmt that is
> a Function that produces the information to display in the message.
> The change to ReportConfiguration are to use ReportingSet to contain the
> Licenses and LicenseFamilies, and supporting methods to configure (as noted
> above).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (RAT-346) WARN in case user defined License family has the same name as existing one
[ https://issues.apache.org/jira/browse/RAT-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806777#comment-17806777 ] Philipp Ottlinger edited comment on RAT-346 at 1/15/24 12:13 PM: - [~solomax] I just applied above changes (e.g. I removed all OM_ prefixes in your config) to an OM-clone: ✔ ~/openmeetings/openmeetings-web [master|✚ 1] 13:11 $ mvn apache-rat:check [INFO] Scanning for projects... [INFO] [INFO] --< org.apache.openmeetings:openmeetings-web >-- [INFO] Building Openmeetings Web 8.0.0-SNAPSHOT [INFO] from pom.xml [INFO] [ war ]- [INFO] [INFO] --- apache-rat:0.16.1-SNAPSHOT:check (default-cli) @ openmeetings-web --- [WARNING] Parameter 'licenses' is deprecated: No reason given [WARNING] Duplicate LicenseFamily category: MIT (action: IGNORE) [WARNING] Duplicate License The MIT License (MIT) of type MIT (action: IGNORE) maybe you did not have a latest SNAPSHOT? In order to rule out that change, could you be so kind to install a 0.16.1-SNAPSHOT from the current master of rat? Thanks was (Author: hugo.hirsch): [~solomax] I just applied above changes to an OM-clone: ✔ ~/openmeetings/openmeetings-web [master|✚ 1] 13:11 $ mvn apache-rat:check [INFO] Scanning for projects... [INFO] [INFO] --< org.apache.openmeetings:openmeetings-web >-- [INFO] Building Openmeetings Web 8.0.0-SNAPSHOT [INFO] from pom.xml [INFO] [ war ]- [INFO] [INFO] --- apache-rat:0.16.1-SNAPSHOT:check (default-cli) @ openmeetings-web --- [WARNING] Parameter 'licenses' is deprecated: No reason given [WARNING] Duplicate LicenseFamily category: MIT (action: IGNORE) [WARNING] Duplicate License The MIT License (MIT) of type MIT (action: IGNORE) maybe you did not have a latest SNAPSHOT? In order to rule out that change, could you be so kind to install a 0.16.1-SNAPSHOT from the current master of rat? Thanks > WARN in case user defined License family has the same name as existing one > -- > > Key: RAT-346 > URL: https://issues.apache.org/jira/browse/RAT-346 > Project: Apache Rat > Issue Type: Improvement > Components: scan >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > Could you please raise WARN in case user defined License family has the same > name as internal one? > It seems user defined one is `just ignored` in such case :( > h2. Architecture remark > I removed the API module because it consisted of a) class files that were not > being used in the code but that were misleading in name; and more importantly > b) because there were a number of test cases that would have been converted > to Junit5 only to be removed again later. > The harmonization is not necessarily the use of a single API module but > rather that the options in each of the UIs should be similarly constructed > (same basic phrasing) not have 2 UIs where one says > "--enable-default-licenses" (default off) and the other says > "--disable-default-licenses" (default on). Also there are options that have > been added to one UI that are general in nature (i.e. not part of managing > the specific platform the UI is on) and are not available in the other UIs. > I will remove the commented out code. I should have before I submitted this > pull request, but skipped it in favor of getting this code change infront of > more eyes quickly. > I also have to make a pass to update javadocs. > @jbonofre Most of the changes in this request are the migration to Junit 5. > The significant changes are the creation of the classes in the o.a.r..utils > directory, the addition of methods to set the associated properties in > ReportConfiguration along with the tests for those classes and changes. > The request was to warn on duplication so the solution submitted does the > following: > Creates a ReportingSet class that is a SortedSet implementation (wrapping > and delegating to a SortedSet). it intercepts the calls to add and addAll to > determine if the new elements are already in the set and take an action. > * If logging is enabled (not set to None on the very thing logging wrapper > Log) write a message about the collision to the log at the specific level. > * If the internal action (ReportingSet.Option) is set to IGNORE the change > is ignored, OVERWRITE the old entry is replaced, FAIL an exception is thrown. > Finally the ReportingSet has an instance variable called duplicateFmt that is > a Function that produces the information to display in the message. > The change to ReportConfi
[jira] [Comment Edited] (RAT-346) WARN in case user defined License family has the same name as existing one
[ https://issues.apache.org/jira/browse/RAT-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806777#comment-17806777 ] Philipp Ottlinger edited comment on RAT-346 at 1/15/24 12:12 PM: - [~solomax] I just applied above changes to an OM-clone: ✔ ~/openmeetings/openmeetings-web [master|✚ 1] 13:11 $ mvn apache-rat:check [INFO] Scanning for projects... [INFO] [INFO] --< org.apache.openmeetings:openmeetings-web >-- [INFO] Building Openmeetings Web 8.0.0-SNAPSHOT [INFO] from pom.xml [INFO] [ war ]- [INFO] [INFO] --- apache-rat:0.16.1-SNAPSHOT:check (default-cli) @ openmeetings-web --- [WARNING] Parameter 'licenses' is deprecated: No reason given [WARNING] Duplicate LicenseFamily category: MIT (action: IGNORE) [WARNING] Duplicate License The MIT License (MIT) of type MIT (action: IGNORE) maybe you did not have a latest SNAPSHOT? In order to rule out that change, could you be so kind to install a 0.16.1-SNAPSHOT from the current master of rat? Thanks was (Author: hugo.hirsch): [~solomax] I just applied above changes to an OM-clone: ✔ ~/workspace2016/githubConnected/openmeetings/openmeetings-web [master|✚ 1] 13:11 $ mvn apache-rat:check [INFO] Scanning for projects... [INFO] [INFO] --< org.apache.openmeetings:openmeetings-web >-- [INFO] Building Openmeetings Web 8.0.0-SNAPSHOT [INFO] from pom.xml [INFO] [ war ]- [INFO] [INFO] --- apache-rat:0.16.1-SNAPSHOT:check (default-cli) @ openmeetings-web --- [WARNING] Parameter 'licenses' is deprecated: No reason given [WARNING] Duplicate LicenseFamily category: MIT (action: IGNORE) [WARNING] Duplicate License The MIT License (MIT) of type MIT (action: IGNORE) maybe you did not have a latest SNAPSHOT? In order to rule out that change, could you be so kind to install a 0.16.1-SNAPSHOT from the current master of rat? Thanks > WARN in case user defined License family has the same name as existing one > -- > > Key: RAT-346 > URL: https://issues.apache.org/jira/browse/RAT-346 > Project: Apache Rat > Issue Type: Improvement > Components: scan >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > Could you please raise WARN in case user defined License family has the same > name as internal one? > It seems user defined one is `just ignored` in such case :( > h2. Architecture remark > I removed the API module because it consisted of a) class files that were not > being used in the code but that were misleading in name; and more importantly > b) because there were a number of test cases that would have been converted > to Junit5 only to be removed again later. > The harmonization is not necessarily the use of a single API module but > rather that the options in each of the UIs should be similarly constructed > (same basic phrasing) not have 2 UIs where one says > "--enable-default-licenses" (default off) and the other says > "--disable-default-licenses" (default on). Also there are options that have > been added to one UI that are general in nature (i.e. not part of managing > the specific platform the UI is on) and are not available in the other UIs. > I will remove the commented out code. I should have before I submitted this > pull request, but skipped it in favor of getting this code change infront of > more eyes quickly. > I also have to make a pass to update javadocs. > @jbonofre Most of the changes in this request are the migration to Junit 5. > The significant changes are the creation of the classes in the o.a.r..utils > directory, the addition of methods to set the associated properties in > ReportConfiguration along with the tests for those classes and changes. > The request was to warn on duplication so the solution submitted does the > following: > Creates a ReportingSet class that is a SortedSet implementation (wrapping > and delegating to a SortedSet). it intercepts the calls to add and addAll to > determine if the new elements are already in the set and take an action. > * If logging is enabled (not set to None on the very thing logging wrapper > Log) write a message about the collision to the log at the specific level. > * If the internal action (ReportingSet.Option) is set to IGNORE the change > is ignored, OVERWRITE the old entry is replaced, FAIL an exception is thrown. > Finally the ReportingSet has an instance variable called duplicateFmt that is > a Function that produces the information to display in the message. > The change to ReportConfiguration are to use
[jira] [Commented] (RAT-346) WARN in case user defined License family has the same name as existing one
[ https://issues.apache.org/jira/browse/RAT-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806777#comment-17806777 ] Philipp Ottlinger commented on RAT-346: --- [~solomax] I just applied above changes to an OM-clone: ✔ ~/workspace2016/githubConnected/openmeetings/openmeetings-web [master|✚ 1] 13:11 $ mvn apache-rat:check [INFO] Scanning for projects... [INFO] [INFO] --< org.apache.openmeetings:openmeetings-web >-- [INFO] Building Openmeetings Web 8.0.0-SNAPSHOT [INFO] from pom.xml [INFO] [ war ]- [INFO] [INFO] --- apache-rat:0.16.1-SNAPSHOT:check (default-cli) @ openmeetings-web --- [WARNING] Parameter 'licenses' is deprecated: No reason given [WARNING] Duplicate LicenseFamily category: MIT (action: IGNORE) [WARNING] Duplicate License The MIT License (MIT) of type MIT (action: IGNORE) maybe you did not have a latest SNAPSHOT? In order to rule out that change, could you be so kind to install a 0.16.1-SNAPSHOT from the current master of rat? Thanks > WARN in case user defined License family has the same name as existing one > -- > > Key: RAT-346 > URL: https://issues.apache.org/jira/browse/RAT-346 > Project: Apache Rat > Issue Type: Improvement > Components: scan >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > Could you please raise WARN in case user defined License family has the same > name as internal one? > It seems user defined one is `just ignored` in such case :( > h2. Architecture remark > I removed the API module because it consisted of a) class files that were not > being used in the code but that were misleading in name; and more importantly > b) because there were a number of test cases that would have been converted > to Junit5 only to be removed again later. > The harmonization is not necessarily the use of a single API module but > rather that the options in each of the UIs should be similarly constructed > (same basic phrasing) not have 2 UIs where one says > "--enable-default-licenses" (default off) and the other says > "--disable-default-licenses" (default on). Also there are options that have > been added to one UI that are general in nature (i.e. not part of managing > the specific platform the UI is on) and are not available in the other UIs. > I will remove the commented out code. I should have before I submitted this > pull request, but skipped it in favor of getting this code change infront of > more eyes quickly. > I also have to make a pass to update javadocs. > @jbonofre Most of the changes in this request are the migration to Junit 5. > The significant changes are the creation of the classes in the o.a.r..utils > directory, the addition of methods to set the associated properties in > ReportConfiguration along with the tests for those classes and changes. > The request was to warn on duplication so the solution submitted does the > following: > Creates a ReportingSet class that is a SortedSet implementation (wrapping > and delegating to a SortedSet). it intercepts the calls to add and addAll to > determine if the new elements are already in the set and take an action. > * If logging is enabled (not set to None on the very thing logging wrapper > Log) write a message about the collision to the log at the specific level. > * If the internal action (ReportingSet.Option) is set to IGNORE the change > is ignored, OVERWRITE the old entry is replaced, FAIL an exception is thrown. > Finally the ReportingSet has an instance variable called duplicateFmt that is > a Function that produces the information to display in the message. > The change to ReportConfiguration are to use ReportingSet to contain the > Licenses and LicenseFamilies, and supporting methods to configure (as noted > above). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-339) Dependency updates via dependabot performed for release 0.16.1
[ https://issues.apache.org/jira/browse/RAT-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806768#comment-17806768 ] ASF subversion and git services commented on RAT-339: - Commit 95630982bcda6460d1de827f36e0d05849e6271b in creadur-rat's branch refs/heads/master from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=95630982 ] Merge pull request #200 from apache/dependabot/maven/junit.version-5.10.1 RAT-339: Bump junit.version from 5.10.0 to 5.10.1 > Dependency updates via dependabot performed for release 0.16.1 > -- > > Key: RAT-339 > URL: https://issues.apache.org/jira/browse/RAT-339 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.16.1 > > > Updates via dependabot in RAT 0.16.1 > h2. (/) Update org.slf4j:slf4j-simple from 2.0.9 to 2.0.11 > * [https://github.com/apache/creadur-rat/pull/183] 2.0.10 > * [https://github.com/apache/creadur-rat/pull/187] 2.0.11 > h2. (/) Update org.apache.maven.plugins:maven-jxr-plugin from 3.3.1 to 3.3.2 > * [https://github.com/apache/creadur-rat/pull/185] > h2. (/) Update org.assertj:assertj-core from 3.24.2 to 3.25.1 > * [https://github.com/apache/creadur-rat/pull/186] > h2. (/) Update org.apache.maven.plugins:maven-surefire-plugin from 3.2.3 to > 3.2.5 > * [https://github.com/apache/creadur-rat/pull/188] > h2. (/) Update mavenPluginPluginVersion from 3.10.2 to 3.11.0 > * [https://github.com/apache/creadur-rat/pull/190] 3.11.0 with introduced > goalPrefix in plugin configuration > h2. (/) Update actions/cache from 3.3.2 to 3.3.3 > * [https://github.com/apache/creadur-rat/pull/191] > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > > h1. TODO before release > # * add changelog entries for each above PRs -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RAT-339) Dependency updates via dependabot performed for release 0.16.1
[ https://issues.apache.org/jira/browse/RAT-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-339: -- Description: Updates via dependabot in RAT 0.16.1 h2. (/) Update org.slf4j:slf4j-simple from 2.0.9 to 2.0.11 * [https://github.com/apache/creadur-rat/pull/183] 2.0.10 * [https://github.com/apache/creadur-rat/pull/187] 2.0.11 h2. (/) Update org.apache.maven.plugins:maven-jxr-plugin from 3.3.1 to 3.3.2 * [https://github.com/apache/creadur-rat/pull/185] h2. (/) Update org.assertj:assertj-core from 3.24.2 to 3.25.1 * [https://github.com/apache/creadur-rat/pull/186] h2. (/) Update org.apache.maven.plugins:maven-surefire-plugin from 3.2.3 to 3.2.5 * [https://github.com/apache/creadur-rat/pull/188] h2. (/) Update mavenPluginPluginVersion from 3.10.2 to 3.11.0 * [https://github.com/apache/creadur-rat/pull/190] 3.11.0 with introduced goalPrefix in plugin configuration h2. (/) Update actions/cache from 3.3.2 to 3.3.3 * [https://github.com/apache/creadur-rat/pull/191] h2. (/) Update junit from 5.10.0 to 5.10.1 * [https://github.com/apache/creadur-rat/pull/200] h2. (/) Update junit-platform-runner from 1.8.1 to 1.10.1 * [https://github.com/apache/creadur-rat/pull/201] h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h1. TODO before release # * add changelog entries for each above PRs was: Updates via dependabot in RAT 0.16.1 h2. (/) Update org.slf4j:slf4j-simple from 2.0.9 to 2.0.11 * [https://github.com/apache/creadur-rat/pull/183] 2.0.10 * [https://github.com/apache/creadur-rat/pull/187] 2.0.11 h2. (/) Update org.apache.maven.plugins:maven-jxr-plugin from 3.3.1 to 3.3.2 * [https://github.com/apache/creadur-rat/pull/185] h2. (/) Update org.assertj:assertj-core from 3.24.2 to 3.25.1 * [https://github.com/apache/creadur-rat/pull/186] h2. (/) Update org.apache.maven.plugins:maven-surefire-plugin from 3.2.3 to 3.2.5 * [https://github.com/apache/creadur-rat/pull/188] h2. (/) Update mavenPluginPluginVersion from 3.10.2 to 3.11.0 * [https://github.com/apache/creadur-rat/pull/190] 3.11.0 with introduced goalPrefix in plugin configuration h2. (/) Update actions/cache from 3.3.2 to 3.3.3 * [https://github.com/apache/creadur-rat/pull/191] h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h1. TODO before release # * add changelog entries for each above PRs > Dependency updates via dependabot performed for release 0.16.1 > -- > > Key: RAT-339 > URL: https://issues.apache.org/jira/browse/RAT-339 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.16.1 > > > Updates via dependabot in RAT 0.16.1 > h2. (/) Update org.slf4j:slf4j-simple from 2.0.9 to 2.0.11 > * [https://github.com/apache/creadur-rat/pull/183] 2.0.10 > * [https://github.com/apache/creadur-rat/pull/187] 2.0.11 > h2. (/) Update org.apache.maven.plugins:maven-jxr-plugin from 3.3.1 to 3.3.2 > * [https://github.com/apache/creadur-rat/pull/185] > h2. (/) Update org.assertj:assertj-core from 3.24.2 to 3.25.1 > * [https://github.com/apache/creadur-rat/pull/186] > h2. (/) Update org.apache.maven.plugins:maven-surefire-plugin from 3.2.3 to > 3.2.5 > * [https://github.com/apache/creadur-rat/pull/188] > h2. (/) Update mavenPluginPluginVersion from 3.10.2 to 3.11.0 > * [https://github.com/apache/creadur-rat/pull/190] 3.11.0 with introduced > goalPrefix in plugin configuration > h2. (/) Update actions/cache from 3.3.2 to 3.3.3 > * [https://github.com/apache/creadur-rat/pull/191] > h2. (/) Update junit from 5.10.0 to 5.10.1 > * [https://github.com/apache/creadur-rat/pull/200] > h2. (/) Update junit-platform-runner from 1.8.1 to 1.10.1 > * [https://github.com/apache/creadur-rat/pull/201] > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > > h1. TODO before release > # * add changelog entries for each above PRs -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-339: Bump junit.version from 5.10.0 to 5.10.1 [creadur-rat]
ottlinger merged PR #200: URL: https://github.com/apache/creadur-rat/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-339: Bump org.junit.platform:junit-platform-runner from 1.8.1 to 1.10.1 [creadur-rat]
ottlinger merged PR #201: URL: https://github.com/apache/creadur-rat/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] updated examples [creadur-rat]
Claudenw opened a new pull request, #202: URL: https://github.com/apache/creadur-rat/pull/202 I am unsure of how to format this text, and I don't have a viewer that displays it. Any assistance in editing/viewing would be appreciated, but I think the gist is here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
