[jira] [Updated] (RAT-362) plugin: .gitignore not correctly applied
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-362: -- Fix Version/s: 0.17 > plugin: .gitignore not correctly applied > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Arnout Engelen >Assignee: Jean-Baptiste Onofré >Priority: Minor > Fix For: 0.17 > > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RAT-362) plugin: .gitignore not correctly applied
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-362: -- Affects Version/s: 0.16.1 > plugin: .gitignore not correctly applied > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Arnout Engelen >Assignee: Jean-Baptiste Onofré >Priority: Minor > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RAT-345) Dependency updates via dependabot performed for release 0.17
[ https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-345: -- Description: h1. Updates via dependabot in RAT 0.17 h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 * https://github.com/apache/creadur-rat/pull/209 3.25.2 * https://github.com/apache/creadur-rat/pull/212 3.25.3 h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 * https://github.com/apache/creadur-rat/pull/213 h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 * https://github.com/apache/creadur-rat/pull/211 h2. (/) Update junit.version from 5.10.1 to 5.10.2 * https://github.com/apache/creadur-rat/pull/210 h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 * https://github.com/apache/creadur-rat/pull/214 h2. (/) Update h2. (/) Update h2. (/) Update h1. TODO before release * add changelog entries for each above PRs was: h1. Updates via dependabot in RAT 0.17 h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 * https://github.com/apache/creadur-rat/pull/209 3.25.2 * https://github.com/apache/creadur-rat/pull/212 3.25.3 h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 * https://github.com/apache/creadur-rat/pull/213 h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 * https://github.com/apache/creadur-rat/pull/211 h2. (/) Update junit.version from 5.10.1 to 5.10.2 * https://github.com/apache/creadur-rat/pull/210 h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h1. TODO before release * add changelog entries for each above PRs > Dependency updates via dependabot performed for release 0.17 > > > Key: RAT-345 > URL: https://issues.apache.org/jira/browse/RAT-345 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > h1. Updates via dependabot in RAT 0.17 > h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 > * https://github.com/apache/creadur-rat/pull/209 3.25.2 > * https://github.com/apache/creadur-rat/pull/212 3.25.3 > h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 > * https://github.com/apache/creadur-rat/pull/213 > h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 > * https://github.com/apache/creadur-rat/pull/211 > h2. (/) Update junit.version from 5.10.1 to 5.10.2 > * https://github.com/apache/creadur-rat/pull/210 > h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 > * https://github.com/apache/creadur-rat/pull/214 > h2. (/) Update > h2. (/) Update > h2. (/) Update > > h1. TODO before release > * add changelog entries for each above PRs -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-345: Bump nl.basjes.gitignore:gitignore-reader from 1.3.1 to 1.4.0 [creadur-rat]
ottlinger merged PR #214: URL: https://github.com/apache/creadur-rat/pull/214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-362) plugin: .gitignore not correctly applied
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818113#comment-17818113 ] Philipp Ottlinger commented on RAT-362: --- [~nielsbasjes] is this an issue from the gitignore library? Thanks > plugin: .gitignore not correctly applied > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Reporter: Arnout Engelen >Assignee: Jean-Baptiste Onofré >Priority: Minor > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
