Re: [PR] Bump actions/cache from 4.0.1 to 4.0.2 [creadur-whisker]
ottlinger merged PR #135: URL: https://github.com/apache/creadur-whisker/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (RAT-365) Site build fails under Java 18
[ https://issues.apache.org/jira/browse/RAT-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger closed RAT-365. - Resolution: Duplicate > Site build fails under Java 18 > -- > > Key: RAT-365 > URL: https://issues.apache.org/jira/browse/RAT-365 > Project: Apache Rat > Issue Type: Bug > Components: site >Affects Versions: 0.17 >Reporter: Claude Warren >Priority: Minor > > setting JAVA_HOME to point to a version 17 java system execute mvn site:site > fails with > Exit code: 1 > [ERROR] error: An internal exception has occurred. > [ERROR] (java.lang.NullPointerException: Cannot invoke > "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null) > [ERROR] Please file a bug against the javadoc tool via the Java bug reporting > page > [ERROR] (https://bugreport.java.com) after checking the Bug Database > (https://bugs.java.com) > [ERROR] for duplicates. Include error messages and the following diagnostic > in your report. Thank you. > [ERROR] java.lang.NullPointerException: Cannot invoke > "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.tool.JavadocLog.getDiagnosticSource(JavadocLog.java:618) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.tool.JavadocLog.print(JavadocLog.java:245) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.Messages.report(Messages.java:187) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.Messages.warning(Messages.java:133) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.seeTagToContent(HtmlDocletWriter.java:1068) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter$2.visitLink(HtmlDocletWriter.java:1545) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter$2.visitLink(HtmlDocletWriter.java:1397) > [ERROR] at > jdk.compiler/com.sun.tools.javac.tree.DCTree$DCLink.accept(DCTree.java:538) > [ERROR] at > jdk.compiler/com.sun.source.util.SimpleDocTreeVisitor.visit(SimpleDocTreeVisitor.java:79) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.commentTagsToContent(HtmlDocletWriter.java:1629) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.TagletWriterImpl.throwsTagOutput(TagletWriterImpl.java:410) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.ThrowsTaglet.throwsTagsOutput(ThrowsTaglet.java:214) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.ThrowsTaglet.inheritThrowsDocumentation(ThrowsTaglet.java:155) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.ThrowsTaglet.getAllBlockTagOutput(ThrowsTaglet.java:177) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.TagletWriter.getBlockTagOutput(TagletWriter.java:288) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.getBlockTagOutput(HtmlDocletWriter.java:365) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.getBlockTagOutput(HtmlDocletWriter.java:351) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.addTagsInfo(HtmlDocletWriter.java:337) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.MethodWriterImpl.addTags(MethodWriterImpl.java:175) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MethodBuilder.buildTagInfo(MethodBuilder.java:190) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MethodBuilder.buildMethodDoc(MethodBuilder.java:128) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MethodBuilder.build(MethodBuilder.java:106) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildMethodDetails(ClassBuilder.java:398) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildMemberDetails(ClassBuilder.java:346) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildClassDoc(ClassBuilder.java:149) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.build(ClassBuilder.java:113) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDoclet.generateClassFiles(HtmlDoclet.java:376) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.AbstractDoclet.generateClassFiles(AbstractDoclet.java:286) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDoclet.generateClassFiles(HtmlDoclet.java:199) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.Abs
[jira] [Commented] (RAT-365) Site build fails under Java 18
[ https://issues.apache.org/jira/browse/RAT-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829320#comment-17829320 ] Philipp Ottlinger commented on RAT-365: --- Issue already reported, seems to be within the JDK > Site build fails under Java 18 > -- > > Key: RAT-365 > URL: https://issues.apache.org/jira/browse/RAT-365 > Project: Apache Rat > Issue Type: Bug > Components: site >Affects Versions: 0.17 >Reporter: Claude Warren >Priority: Minor > > setting JAVA_HOME to point to a version 17 java system execute mvn site:site > fails with > Exit code: 1 > [ERROR] error: An internal exception has occurred. > [ERROR] (java.lang.NullPointerException: Cannot invoke > "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null) > [ERROR] Please file a bug against the javadoc tool via the Java bug reporting > page > [ERROR] (https://bugreport.java.com) after checking the Bug Database > (https://bugs.java.com) > [ERROR] for duplicates. Include error messages and the following diagnostic > in your report. Thank you. > [ERROR] java.lang.NullPointerException: Cannot invoke > "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.tool.JavadocLog.getDiagnosticSource(JavadocLog.java:618) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.tool.JavadocLog.print(JavadocLog.java:245) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.Messages.report(Messages.java:187) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.Messages.warning(Messages.java:133) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.seeTagToContent(HtmlDocletWriter.java:1068) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter$2.visitLink(HtmlDocletWriter.java:1545) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter$2.visitLink(HtmlDocletWriter.java:1397) > [ERROR] at > jdk.compiler/com.sun.tools.javac.tree.DCTree$DCLink.accept(DCTree.java:538) > [ERROR] at > jdk.compiler/com.sun.source.util.SimpleDocTreeVisitor.visit(SimpleDocTreeVisitor.java:79) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.commentTagsToContent(HtmlDocletWriter.java:1629) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.TagletWriterImpl.throwsTagOutput(TagletWriterImpl.java:410) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.ThrowsTaglet.throwsTagsOutput(ThrowsTaglet.java:214) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.ThrowsTaglet.inheritThrowsDocumentation(ThrowsTaglet.java:155) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.ThrowsTaglet.getAllBlockTagOutput(ThrowsTaglet.java:177) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.TagletWriter.getBlockTagOutput(TagletWriter.java:288) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.getBlockTagOutput(HtmlDocletWriter.java:365) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.getBlockTagOutput(HtmlDocletWriter.java:351) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.addTagsInfo(HtmlDocletWriter.java:337) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.MethodWriterImpl.addTags(MethodWriterImpl.java:175) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MethodBuilder.buildTagInfo(MethodBuilder.java:190) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MethodBuilder.buildMethodDoc(MethodBuilder.java:128) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MethodBuilder.build(MethodBuilder.java:106) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildMethodDetails(ClassBuilder.java:398) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildMemberDetails(ClassBuilder.java:346) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildClassDoc(ClassBuilder.java:149) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.build(ClassBuilder.java:113) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDoclet.generateClassFiles(HtmlDoclet.java:376) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.AbstractDoclet.generateClassFiles(AbstractDoclet.java:286) > [ERROR] at > jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDoclet.generateClassFiles(HtmlDocl
[jira] [Updated] (RAT-345) Dependency updates via dependabot performed for release 0.17
[ https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-345: -- Description: h1. Updates via dependabot in RAT 0.17 h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 * https://github.com/apache/creadur-rat/pull/209 3.25.2 * https://github.com/apache/creadur-rat/pull/212 3.25.3 h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 * https://github.com/apache/creadur-rat/pull/213 h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 * https://github.com/apache/creadur-rat/pull/211 h2. (/) Update junit.version from 5.10.1 to 5.10.2 * https://github.com/apache/creadur-rat/pull/210 h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 * https://github.com/apache/creadur-rat/pull/214 h2. (/) Update commons-compress from 1.25.0 to 1.26.1 * https://github.com/apache/creadur-rat/pull/215 1.26.0 * https://github.com/apache/creadur-rat/pull/220 1.26.1 h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 * https://github.com/apache/creadur-rat/pull/219 3.2.0 h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 * https://github.com/apache/creadur-rat/pull/218 h2. (/) Update actions/cache from 4.0.0 to 4.0.2 * https://github.com/apache/creadur-rat/pull/217 4.0.1 * https://github.com/apache/creadur-rat/pull/226 4.0.2 h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0 * https://github.com/apache/creadur-rat/pull/216 4.1.0 * https://github.com/apache/creadur-rat/pull/222 4.2.0 h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 * https://github.com/apache/creadur-rat/pull/225 h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h1. TODO before release * add changelog entries for each above PRs was: h1. Updates via dependabot in RAT 0.17 h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 * https://github.com/apache/creadur-rat/pull/209 3.25.2 * https://github.com/apache/creadur-rat/pull/212 3.25.3 h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 * https://github.com/apache/creadur-rat/pull/213 h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 * https://github.com/apache/creadur-rat/pull/211 h2. (/) Update junit.version from 5.10.1 to 5.10.2 * https://github.com/apache/creadur-rat/pull/210 h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 * https://github.com/apache/creadur-rat/pull/214 h2. (/) Update commons-compress from 1.25.0 to 1.26.1 * https://github.com/apache/creadur-rat/pull/215 1.26.0 * https://github.com/apache/creadur-rat/pull/220 1.26.1 h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 * https://github.com/apache/creadur-rat/pull/219 3.2.0 h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 * https://github.com/apache/creadur-rat/pull/218 h2. (/) Update actions/cache from 4.0.0 to 4.0.1 * https://github.com/apache/creadur-rat/pull/217 4.0.1 * https://github.com/apache/creadur-rat/pull/222 4.2.0 h2. (/) Update actions/setup-java from 4.0.0 to 4.1.0 * https://github.com/apache/creadur-rat/pull/216 h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 * https://github.com/apache/creadur-rat/pull/225 h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h1. TODO before release * add changelog entries for each above PRs > Dependency updates via dependabot performed for release 0.17 > > > Key: RAT-345 > URL: https://issues.apache.org/jira/browse/RAT-345 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > h1. Updates via dependabot in RAT 0.17 > h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 > * https://github.com/apache/creadur-rat/pull/209 3.25.2 > * https://github.com/apache/creadur-rat/pull/212 3.25.3 > h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 > * https://github.com/apache/creadur-rat/pull/213 > h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 > * https://github.com/apache/creadur-rat/pull/211 > h2. (/) Update junit.version from 5.10.1 to 5.10.2 > * https://github.com/apache/creadur-rat/pull/210 > h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 > * https://github.com/apache/creadur-rat/pull/214 > h2. (/) Update commons-compress from 1.25.0 to 1.26.1 > * https://github.com/apache/creadur-rat/pull/215 1.26.0 > * https://github.com/apache/creadur-rat/pull/220 1.26.1 > h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 > * https://github.com/apache/creadur-rat/pull/219 3.2.0 > h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 > * https://github.com/apache/creadur-rat/pull/218 > h2. (/) Update actions/cache from 4.0.0 to 4.0.2 > * https://github.com/apache/creadur-
[jira] [Commented] (RAT-345) Dependency updates via dependabot performed for release 0.17
[ https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829306#comment-17829306 ] ASF subversion and git services commented on RAT-345: - Commit d9c0326fdeaee22cc677784672ca2bb5f3a7e030 in creadur-rat's branch refs/heads/master from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=d9c0326f ] Merge pull request #226 from apache/dependabot/github_actions/actions/cache-4.0.2 RAT-345: Bump actions/cache from 4.0.1 to 4.0.2 > Dependency updates via dependabot performed for release 0.17 > > > Key: RAT-345 > URL: https://issues.apache.org/jira/browse/RAT-345 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > h1. Updates via dependabot in RAT 0.17 > h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 > * https://github.com/apache/creadur-rat/pull/209 3.25.2 > * https://github.com/apache/creadur-rat/pull/212 3.25.3 > h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 > * https://github.com/apache/creadur-rat/pull/213 > h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 > * https://github.com/apache/creadur-rat/pull/211 > h2. (/) Update junit.version from 5.10.1 to 5.10.2 > * https://github.com/apache/creadur-rat/pull/210 > h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 > * https://github.com/apache/creadur-rat/pull/214 > h2. (/) Update commons-compress from 1.25.0 to 1.26.1 > * https://github.com/apache/creadur-rat/pull/215 1.26.0 > * https://github.com/apache/creadur-rat/pull/220 1.26.1 > h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 > * https://github.com/apache/creadur-rat/pull/219 3.2.0 > h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 > * https://github.com/apache/creadur-rat/pull/218 > h2. (/) Update actions/cache from 4.0.0 to 4.0.2 > * https://github.com/apache/creadur-rat/pull/217 4.0.1 > * https://github.com/apache/creadur-rat/pull/226 4.0.2 > h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0 > * https://github.com/apache/creadur-rat/pull/216 4.1.0 > * https://github.com/apache/creadur-rat/pull/222 4.2.0 > h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 > * https://github.com/apache/creadur-rat/pull/225 > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > > h1. TODO before release > * add changelog entries for each above PRs -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-345: Bump actions/cache from 4.0.1 to 4.0.2 [creadur-rat]
ottlinger merged PR #226: URL: https://github.com/apache/creadur-rat/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-333: fix --force option will change the file permissions [creadur-rat]
Claudenw commented on PR #223: URL: https://github.com/apache/creadur-rat/pull/223#issuecomment-2010249205 Should be fixed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-77: output files with missing headers [creadur-rat]
Claudenw commented on PR #224: URL: https://github.com/apache/creadur-rat/pull/224#issuecomment-2010246398 @ottlinger Should be fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-323) Harmonize UIs
[ https://issues.apache.org/jira/browse/RAT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829260#comment-17829260 ] Claude Warren commented on RAT-323: --- I added a second pass through the configuration options came up with explicit names for each option. > Harmonize UIs > - > > Key: RAT-323 > URL: https://issues.apache.org/jira/browse/RAT-323 > Project: Apache Rat > Issue Type: Improvement > Components: Client - cli >Affects Versions: 0.16 >Reporter: Claude Warren >Priority: Major > Attachments: RAT_harmonize_UIs.csv, RAT_harmonize_UIs_rev2.csv > > Original Estimate: 168h > Remaining Estimate: 168h > > The UIs (CLI, ANT and Maven) were all developed separately and have different > options. > There is an overlap in some functionality and the functionality of some UIs > is not found in others. > This task is to do two things: > # collect all the UI options, and ensure that they are all supported in the > ReportConfiguration class. > # modify the UIs so that the names of the options are the same (or as > similar as possible) across the three UIs. Renamed methods are to be > deprecated in favour of new methods. > > Example: > apache-rat-plugin has 3 options: parseSCMIgnoresAsExcludes, > useEclipseDefaultExcludes, useIdeaDefaultExcludes that change the file > filter. These are options that would be useful in all UIs and should be > moved to the ReportConfiguration so that any UI can set them. > By harmonization I mean that options like the above are extracted from the > specific UIs where they are implemented and moved to the ReportConfiguration > so that the implementations are in one place and can be shared across all UIs. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RAT-323) Harmonize UIs
[ https://issues.apache.org/jira/browse/RAT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated RAT-323: -- Attachment: RAT_harmonize_UIs_rev2.csv > Harmonize UIs > - > > Key: RAT-323 > URL: https://issues.apache.org/jira/browse/RAT-323 > Project: Apache Rat > Issue Type: Improvement > Components: Client - cli >Affects Versions: 0.16 >Reporter: Claude Warren >Priority: Major > Attachments: RAT_harmonize_UIs.csv, RAT_harmonize_UIs_rev2.csv > > Original Estimate: 168h > Remaining Estimate: 168h > > The UIs (CLI, ANT and Maven) were all developed separately and have different > options. > There is an overlap in some functionality and the functionality of some UIs > is not found in others. > This task is to do two things: > # collect all the UI options, and ensure that they are all supported in the > ReportConfiguration class. > # modify the UIs so that the names of the options are the same (or as > similar as possible) across the three UIs. Renamed methods are to be > deprecated in favour of new methods. > > Example: > apache-rat-plugin has 3 options: parseSCMIgnoresAsExcludes, > useEclipseDefaultExcludes, useIdeaDefaultExcludes that change the file > filter. These are options that would be useful in all UIs and should be > moved to the ReportConfiguration so that any UI can set them. > By harmonization I mean that options like the above are extracted from the > specific UIs where they are implemented and moved to the ReportConfiguration > so that the implementations are in one place and can be shared across all UIs. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-77: output files with missing headers [creadur-rat]
ottlinger commented on PR #224: URL: https://github.com/apache/creadur-rat/pull/224#issuecomment-2010009537 @Claudenw pls update https://github.com/apache/creadur-rat/blob/master/apache-rat/src/site/apt/index.apt.vm as well as it generates into: https://creadur.apache.org/rat/apache-rat/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump actions/cache from 4.0.1 to 4.0.2 [creadur-tentacles]
dependabot[bot] opened a new pull request, #118: URL: https://github.com/apache/creadur-tentacles/pull/118 Bumps [actions/cache](https://github.com/actions/cache) from 4.0.1 to 4.0.2. Release notes Sourced from https://github.com/actions/cache/releases";>actions/cache's releases. v4.0.2 What's Changed Fix fail-on-cache-miss not working by https://github.com/cdce8p";>@cdce8p in https://redirect.github.com/actions/cache/pull/1327";>actions/cache#1327 Full Changelog: https://github.com/actions/cache/compare/v4.0.1...v4.0.2";>https://github.com/actions/cache/compare/v4.0.1...v4.0.2 Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md";>actions/cache's changelog. 4.0.2 Fixed restore fail-on-cache-miss not working. Commits https://github.com/actions/cache/commit/0c45773b623bea8c8e75f6c82b208c3cf94ea4f9";>0c45773 Merge pull request https://redirect.github.com/actions/cache/issues/1327";>#1327 from cdce8p/fix-fail-on-cache-miss https://github.com/actions/cache/commit/8a55f839aa4b4578e47bdc8a52828637cbb9a454";>8a55f83 Add test case for process exit https://github.com/actions/cache/commit/3884cace147bdf9307fcc52a277f421af7b30798";>3884cac Bump version https://github.com/actions/cache/commit/e29dad3e36390db18fc19fb666cb1302f4929002";>e29dad3 Fix fail-on-cache-miss not working See full diff in https://github.com/actions/cache/compare/v4.0.1...v4.0.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (RAT-365) Site build fails under Java 18
Claude Warren created RAT-365: - Summary: Site build fails under Java 18 Key: RAT-365 URL: https://issues.apache.org/jira/browse/RAT-365 Project: Apache Rat Issue Type: Bug Components: site Affects Versions: 0.17 Reporter: Claude Warren setting JAVA_HOME to point to a version 17 java system execute mvn site:site fails with Exit code: 1 [ERROR] error: An internal exception has occurred. [ERROR] (java.lang.NullPointerException: Cannot invoke "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null) [ERROR] Please file a bug against the javadoc tool via the Java bug reporting page [ERROR] (https://bugreport.java.com) after checking the Bug Database (https://bugs.java.com) [ERROR] for duplicates. Include error messages and the following diagnostic in your report. Thank you. [ERROR] java.lang.NullPointerException: Cannot invoke "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null [ERROR] at jdk.javadoc/jdk.javadoc.internal.tool.JavadocLog.getDiagnosticSource(JavadocLog.java:618) [ERROR] at jdk.javadoc/jdk.javadoc.internal.tool.JavadocLog.print(JavadocLog.java:245) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.Messages.report(Messages.java:187) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.Messages.warning(Messages.java:133) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.seeTagToContent(HtmlDocletWriter.java:1068) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter$2.visitLink(HtmlDocletWriter.java:1545) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter$2.visitLink(HtmlDocletWriter.java:1397) [ERROR] at jdk.compiler/com.sun.tools.javac.tree.DCTree$DCLink.accept(DCTree.java:538) [ERROR] at jdk.compiler/com.sun.source.util.SimpleDocTreeVisitor.visit(SimpleDocTreeVisitor.java:79) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.commentTagsToContent(HtmlDocletWriter.java:1629) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.TagletWriterImpl.throwsTagOutput(TagletWriterImpl.java:410) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.ThrowsTaglet.throwsTagsOutput(ThrowsTaglet.java:214) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.ThrowsTaglet.inheritThrowsDocumentation(ThrowsTaglet.java:155) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.ThrowsTaglet.getAllBlockTagOutput(ThrowsTaglet.java:177) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.taglets.TagletWriter.getBlockTagOutput(TagletWriter.java:288) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.getBlockTagOutput(HtmlDocletWriter.java:365) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.getBlockTagOutput(HtmlDocletWriter.java:351) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDocletWriter.addTagsInfo(HtmlDocletWriter.java:337) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.MethodWriterImpl.addTags(MethodWriterImpl.java:175) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MethodBuilder.buildTagInfo(MethodBuilder.java:190) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MethodBuilder.buildMethodDoc(MethodBuilder.java:128) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.MethodBuilder.build(MethodBuilder.java:106) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildMethodDetails(ClassBuilder.java:398) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildMemberDetails(ClassBuilder.java:346) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.buildClassDoc(ClassBuilder.java:149) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.builders.ClassBuilder.build(ClassBuilder.java:113) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDoclet.generateClassFiles(HtmlDoclet.java:376) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.AbstractDoclet.generateClassFiles(AbstractDoclet.java:286) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.HtmlDoclet.generateClassFiles(HtmlDoclet.java:199) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.AbstractDoclet.startGeneration(AbstractDoclet.java:212) [ERROR] at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.AbstractDoclet.run(AbstractDoclet.java:115) [ERROR] at jdk.javadoc/jdk.javadoc.doclet.StandardDoclet.run(StandardDoclet.java:103) [ERROR] at jdk.javadoc/jdk.javadoc.internal.tool.Start.parseAndExecute(Start.java:556) [ERROR]
Re: [PR] RAT-333: fix --force option will change the file permissions [creadur-rat]
Claudenw commented on code in PR #223:
URL: https://github.com/apache/creadur-rat/pull/223#discussion_r1531594203
##
apache-rat-core/src/test/java/org/apache/rat/annotation/TestLicenseAppender.java:
##
@@ -674,4 +678,70 @@ public void readFile(BufferedReader r) throws IOException {
}
});
}
+
+@Test
Review Comment:
I reformatted my changes to match what was there (I think).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RAT-333: fix --force option will change the file permissions [creadur-rat]
Claudenw commented on code in PR #223:
URL: https://github.com/apache/creadur-rat/pull/223#discussion_r1531588952
##
apache-rat-core/src/main/java/org/apache/rat/annotation/AbstractLicenseAppender.java:
##
@@ -239,27 +241,28 @@ public void append(File document) throws IOException {
// for Java just place the license at the front, for XML add
// an XML decl first - don't know how to handle PHP
if (expectsPackage || expectsXMLDecl) {
-writer = new FileWriter(newDocument);
-if (expectsXMLDecl) {
-writer.write("");
-writer.write(LINE_SEP);
+try (FileWriter writer2 = new FileWriter(newDocument)) {
+if (expectsXMLDecl) {
+writer2.write("");
+writer2.write(LINE_SEP);
+}
+attachLicense(writer2, document,
+false, false, false, false, false, false);
}
-attachLicense(writer, document,
-false, false, false, false, false, false);
}
}
-} finally {
-IOUtils.closeQuietly(writer);
-}
+}
if (isForced) {
-boolean deleted = document.delete();
-if (!deleted) {
-log.error("Could not delete original file to prepare
renaming.");
-}
-boolean renamed = newDocument.renameTo(document.getAbsoluteFile());
-if (!renamed) {
-log.error("Failed to rename new file, original file remains
unchanged.");
+Path docPath = document.toPath();
Review Comment:
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
