Re: [PR] Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1 [creadur-rat]
jochenw merged PR #234: URL: https://github.com/apache/creadur-rat/pull/234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-293) Configure SonarCloud integration for RAT
[ https://issues.apache.org/jira/browse/RAT-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833268#comment-17833268 ] Philipp Ottlinger commented on RAT-293: --- We could configure a sonarcloud profile that runs the builds without the animal-sniffer-plugin checks nevertheless I assume this would introduce unnecessary complexity and we would check a different artifact than the one we are delivering/building to our users. > Configure SonarCloud integration for RAT > > > Key: RAT-293 > URL: https://issues.apache.org/jira/browse/RAT-293 > Project: Apache Rat > Issue Type: Task >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > > Configure repo to be included in > https://sonarcloud.io/organizations/apache/projects > Requested access via INFRA-22683. > https://cwiki.apache.org/confluence/display/INFRA/SonarQube+Analysis > h2. DevHint > This task cannot be accomplished as the sonarcloud integration is >JDK8 and > fails the animal-sniffer-plugin configured to only allow JDK8 contents in RAT! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-293) Configure SonarCloud integration for RAT
[ https://issues.apache.org/jira/browse/RAT-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833054#comment-17833054 ] Claude Warren commented on RAT-293: --- Can we modify the maven build so that it runs the sonarcloud integration when java is higher than version 8? > Configure SonarCloud integration for RAT > > > Key: RAT-293 > URL: https://issues.apache.org/jira/browse/RAT-293 > Project: Apache Rat > Issue Type: Task >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > > Configure repo to be included in > https://sonarcloud.io/organizations/apache/projects > Requested access via INFRA-22683. > https://cwiki.apache.org/confluence/display/INFRA/SonarQube+Analysis > h2. DevHint > This task cannot be accomplished as the sonarcloud integration is >JDK8 and > fails the animal-sniffer-plugin configured to only allow JDK8 contents in RAT! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (RAT-293) Configure SonarCloud integration for RAT
[ https://issues.apache.org/jira/browse/RAT-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren reassigned RAT-293: - Assignee: Philipp Ottlinger > Configure SonarCloud integration for RAT > > > Key: RAT-293 > URL: https://issues.apache.org/jira/browse/RAT-293 > Project: Apache Rat > Issue Type: Task >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > > Configure repo to be included in > https://sonarcloud.io/organizations/apache/projects > Requested access via INFRA-22683. > https://cwiki.apache.org/confluence/display/INFRA/SonarQube+Analysis > h2. DevHint > This task cannot be accomplished as the sonarcloud integration is >JDK8 and > fails the animal-sniffer-plugin configured to only allow JDK8 contents in RAT! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (RAT-350) Fix javadoc warnings
[ https://issues.apache.org/jira/browse/RAT-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren reassigned RAT-350: - Assignee: Claude Warren > Fix javadoc warnings > > > Key: RAT-350 > URL: https://issues.apache.org/jira/browse/RAT-350 > Project: Apache Rat > Issue Type: Improvement > Components: documentation >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > Fix For: 0.17 > > > Multiple errors in javadocs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-355) optionally Export XML configuration file as part of run.
[ https://issues.apache.org/jira/browse/RAT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833052#comment-17833052 ] Claude Warren commented on RAT-355: --- Fix proposed in [pull 233|[https://github.com/apache/creadur-rat/pull/233]] > optionally Export XML configuration file as part of run. > > > Key: RAT-355 > URL: https://issues.apache.org/jira/browse/RAT-355 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.17 > > > Currently multiples inputs are processed into the internal configuration. > This is request is to export the configuration as part of the processing of > the files. This will be an optional output into the XML result of the run. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-366) Switch to Reading preparing header text and processing in one call.
[ https://issues.apache.org/jira/browse/RAT-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833051#comment-17833051 ] Claude Warren commented on RAT-366: --- Second potential fix in [pull 233|https://github.com/apache/creadur-rat/pull/233] Should supersede 228 > Switch to Reading preparing header text and processing in one call. > --- > > Key: RAT-366 > URL: https://issues.apache.org/jira/browse/RAT-366 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16.1 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > Fix For: 0.17 > > > Currently the system spends a fair chunk of time processing input line by > line. The code path is much simplified if instead we read the maximum number > of lines that we would process under the old code and process that all at > once. > This will also improve memory footprint since the full text matcher will not > have to keep a copy of all the text it has seen so far, but rather just > process the block of text that is passed in. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[DISCUSS] RAT-355 & RAT-366
I have created a pull request with both changes included. I think this is smaller than the combined pull requests done individually and since they overlapped and resulted in a bunch of merge conflicts I figured I would bite the bullet and get them out of the way all at once. - The issue with multiple licenses being detected but not reported is now fixed. - The configuration can be dumped into the output XML - Annotations added to make integrating Matchers into the system easier, and to simplify the required code. - Matchers now match or don't match in a single call, removing the state code that was added recently. The output has changed. The output XML format is different, style sheets have been updated to address this. The default output is significantly changed. I just realized that the example output [1] is outdated, the unapproved license lines now have " (Unapproved)" after the name of the license. I found some code that is no longer used and deprecated it. [1] https://github.com/Claudenw/creadur-rat/blob/RAT-355_RAT-366_merge/apache-rat/src/site/examples/default_output.txt -- LinkedIn: http://www.linkedin.com/in/claudewarren
