Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]
Claudenw commented on PR #240: URL: https://github.com/apache/creadur-rat/pull/240#issuecomment-2079782431 Well this blew up to something bigger than I wanted but... I added default exclusion for "*.json" files in the Default class and used that to configure the ReportConfiguration defaults. In the future the default exclusions should be configured in Default class. I changed the parameter names and instance variables to "filesToIgnore" and "directoriesToIgnore" to make it clear what the filters were doing. I cleaned up the DirectoryWalker and Walker classes. I ensured that the filesToIgnore and directoriesToIgnore alwasy have a value (not null). If set to null in the configuration the value is translated into a filter that always returns false. I think there may be an issue in the directoreisToIgnore processing, but it has been there from the beginning. I will investigate and open a ticket if necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841233#comment-17841233 ] ASF subversion and git services commented on RAT-369: - Commit a0e9fa0d1f20883bcfbb9663d6be8f396ec15ed1 in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=a0e9fa0d ] RAT-369: Fix rename in module as well > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841226#comment-17841226 ] ASF subversion and git services commented on RAT-369: - Commit 99cc9a02adc4785925346a5ae9ce1f35882ecf04 in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=99cc9a02 ] RAT-369: Add exclusions and fix TYPO in enum > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841225#comment-17841225 ] ASF subversion and git services commented on RAT-369: - Commit 10f925aec56e9e6dd295606921fa8b6acb853cdd in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=10f925ae ] RAT-369: Add exclusion for charsets that cannot be set with Java8 > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]
ottlinger commented on PR #240: URL: https://github.com/apache/creadur-rat/pull/240#issuecomment-2079291560 Pls add a reference to all the old tickets in the changelog & thanks for taking care of the old tickets/bugs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-370) Introduce performance test submodule in RAT to detect changes and measure any regressions
[ https://issues.apache.org/jira/browse/RAT-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841155#comment-17841155 ] Philipp Ottlinger commented on RAT-370: --- [~claud...@users.sourceforge.net] would you put these tests into the newly added tools submodule? > Introduce performance test submodule in RAT to detect changes and measure any > regressions > - > > Key: RAT-370 > URL: https://issues.apache.org/jira/browse/RAT-370 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.17 >Reporter: Philipp Ottlinger >Priority: Major > > The upcoming r0.17 contains many changes in the way scanning of contents is > performed. Thus it would make sense to > * collect various example files > * measure how long it takes to run RAT on these files -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841153#comment-17841153 ] ASF subversion and git services commented on RAT-369: - Commit 64b1c2188037f531c6baef25f5c8ad0eb5946ff1 in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=64b1c218 ] RAT-369: Add exclusion file to fix the build in new tools submodule > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841151#comment-17841151 ] ASF subversion and git services commented on RAT-369: - Commit bea9d2c3632f8e0d60e669b31f21362a073f59d3 in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=bea9d2c3 ] Merge remote-tracking branch 'origin/master' into feature/RAT-369 > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-355) optionally Export XML configuration file as part of run.
[ https://issues.apache.org/jira/browse/RAT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841145#comment-17841145 ] ASF subversion and git services commented on RAT-355: - Commit 8d4bb090c1cab596a56d7c4812937fb81ba0020e in creadur-rat's branch refs/heads/feature/RAT-369 from Claude Warren [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=8d4bb090 ] updated changes.xml for RAT-355 and RAT-366 > optionally Export XML configuration file as part of run. > > > Key: RAT-355 > URL: https://issues.apache.org/jira/browse/RAT-355 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.17 > > > Currently multiples inputs are processed into the internal configuration. > This is request is to export the configuration as part of the processing of > the files. This will be an optional output into the XML result of the run. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-354) Integration tests fail with new Maven 4.0.0-alpha-12
[
https://issues.apache.org/jira/browse/RAT-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841149#comment-17841149
]
ASF subversion and git services commented on RAT-354:
-
Commit 1808a3d273e4e1d4b7c76a3b8f13aff057453eb7 in creadur-rat's branch
refs/heads/feature/RAT-369 from Philipp Ottlinger
[ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=1808a3d2 ]
RAT-354: Remove warning during integration test run that breaks the build with
Maven 4
> Integration tests fail with new Maven 4.0.0-alpha-12
>
>
> Key: RAT-354
> URL: https://issues.apache.org/jira/browse/RAT-354
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.16.1
>Reporter: Philipp Ottlinger
>Assignee: Philipp Ottlinger
>Priority: Major
> Fix For: 0.17
>
>
> Running the newly published
> {code:shell}
> 22:22 $ mvn --version
> Apache Maven 4.0.0-alpha-12 (e627879aedd8a0c1859e58a527852ae8de1b4878)
> Maven home: ~/maven
> Java version: 1.8.0_192, vendor: Oracle Corporation, runtime:
> ~/jdk1.8.0_192/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.15.0-91-generic", arch: "amd64", family: "unix"
> ✔ ~/creadur-rat [master|✔]
> {code}
> on RAT yields a build failure from within the integration tests:
> {code:java}
> [INFO]
> [INFO] — invoker:3.6.0:run (integration-test) @ apache-rat-plugin —
> [INFO] Building: CustomLicense/pom.xml
> [INFO] CustomLicense/pom.xml SUCCESS
> (2.287 s)
> [INFO] Building: it1/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] it1/pom.xml .. SUCCESS
> (2.487 s)
> [INFO] Building: it4_RAT-168/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] Assertion failed:
> assert ! content.contains( '[WARNING]' )
> | | |
> | | true
> | 'Apache Maven 4.0.0-alpha-12
> (e627879aedd8a0c1859e58a527852ae8de1b4878)\nMaven home:
> /home/hirsch/software/apache-maven-4.0.0-alpha-12\nJava version: 1.8.0_192,
> vendor: Oracle Corporation, runtime: /home/hirsch/jdk1.8.0_192/jre\nDefault
> locale: de_DE, platform encoding: UTF-8\nOS name: "linux", version:
> "5.15.0-91-generic", arch: "amd64", family: "unix"\n[DEBUG] Created adapter
> factory; available factories [file-lock, rwlock-local, semaphore-local,
> noop]; available name mappers [discriminating, file-gav, file-hgav,
> file-static, gav, static]\n[DEBUG] Created new class realm maven.api\n[DEBUG]
> Importing foreign packages into class realm maven.api\n[DEBUG] Imported:
> jakarta.annotation.* < plexus.core\n[DEBUG] Imported: jakarta.inject.* <
> plexus.core\n[DEBUG] Imported: javax.annotation.* < plexus.core\n[DEBUG]
> Imported: javax.annotation.security.* < plexus.core\n[DEBUG] Imported:
> javax.inject.* < plexus.core\n[DEBUG] Imported: org.apache.maven.* <
> plexus.core\n[DEBUG] Imported: org.apache.maven.api < plexus.core\n[DEBUG]
> Imported: org.apache.maven.artifact < plexus.core\n[DEBUG] Imported:
> org.apache.maven.classrealm < plexus.core\n[DEBUG] Imported:
> org.apache.maven.cli < plexus.core\n[DEBUG] Imported:
> org.apache.maven.configuration < plexus.core\n[DEBUG] Imported:
> org.apache.maven.exception < plexus.core\n[DEBUG] Imported:
> org.apache.maven.execution < plexus.core\n[DEBUG] Imported:
> org.apache.maven.execution.scope < plexus.core\n[DEBUG] Imported:
> org.apache.maven.feature < plexus.core\n[DEBUG] Imported:
> org.apache.maven.graph < plexus.core\n[DEBUG] Imported:
> org.apache.maven.lifecycle < plexus.core\n[DEBUG] Imported:
> org.apache.maven.model < plexus.core\n[DEBUG] Imported:
> org.apache.maven.monitor < plexus.core\n[DEBUG] Imported:
> org.apache.maven.plugin < plexus.core\n[DEBUG] Imported:
> org.apache.maven.profiles < plexus.core\n[DEBUG] Imported:
> org.apache.maven.project < plexus.core\n[DEBUG] Imported:
> org.apache.maven.reporting < plexus.core\n[DEBUG] Imported:
> org.apache.maven.repository < plexus.core\n[DEBUG] Imported:
> org.apache.maven.rtinfo.* < plexus.core\n[DEBUG] Imported:
> org.apache.maven.settings < plexus.core\n[DEBUG] Imported:
> org.apache.maven.toolchain < plexus.core\n[DEBUG] Imported:
> org.apache.maven.usability < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.* < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.authentication < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.authorization < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.events < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.observers < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.proxy < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon
[jira] [Commented] (RAT-366) Switch to Reading preparing header text and processing in one call.
[ https://issues.apache.org/jira/browse/RAT-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841146#comment-17841146 ] ASF subversion and git services commented on RAT-366: - Commit 8d4bb090c1cab596a56d7c4812937fb81ba0020e in creadur-rat's branch refs/heads/feature/RAT-369 from Claude Warren [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=8d4bb090 ] updated changes.xml for RAT-355 and RAT-366 > Switch to Reading preparing header text and processing in one call. > --- > > Key: RAT-366 > URL: https://issues.apache.org/jira/browse/RAT-366 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16.1 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > Fix For: 0.17 > > > Currently the system spends a fair chunk of time processing input line by > line. The code path is much simplified if instead we read the maximum number > of lines that we would process under the old code and process that all at > once. > This will also improve memory footprint since the full text matcher will not > have to keep a copy of all the text it has seen so far, but rather just > process the block of text that is passed in. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-354) Integration tests fail with new Maven 4.0.0-alpha-12
[
https://issues.apache.org/jira/browse/RAT-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841150#comment-17841150
]
ASF subversion and git services commented on RAT-354:
-
Commit f531b8c3c07b05e61d020caa7859c251998e2a87 in creadur-rat's branch
refs/heads/feature/RAT-369 from Philipp Ottlinger
[ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=f531b8c3 ]
RAT-354: RAT remains Java8 and cannot be used with recent Maven4
> Integration tests fail with new Maven 4.0.0-alpha-12
>
>
> Key: RAT-354
> URL: https://issues.apache.org/jira/browse/RAT-354
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.16.1
>Reporter: Philipp Ottlinger
>Assignee: Philipp Ottlinger
>Priority: Major
> Fix For: 0.17
>
>
> Running the newly published
> {code:shell}
> 22:22 $ mvn --version
> Apache Maven 4.0.0-alpha-12 (e627879aedd8a0c1859e58a527852ae8de1b4878)
> Maven home: ~/maven
> Java version: 1.8.0_192, vendor: Oracle Corporation, runtime:
> ~/jdk1.8.0_192/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.15.0-91-generic", arch: "amd64", family: "unix"
> ✔ ~/creadur-rat [master|✔]
> {code}
> on RAT yields a build failure from within the integration tests:
> {code:java}
> [INFO]
> [INFO] — invoker:3.6.0:run (integration-test) @ apache-rat-plugin —
> [INFO] Building: CustomLicense/pom.xml
> [INFO] CustomLicense/pom.xml SUCCESS
> (2.287 s)
> [INFO] Building: it1/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] it1/pom.xml .. SUCCESS
> (2.487 s)
> [INFO] Building: it4_RAT-168/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] Assertion failed:
> assert ! content.contains( '[WARNING]' )
> | | |
> | | true
> | 'Apache Maven 4.0.0-alpha-12
> (e627879aedd8a0c1859e58a527852ae8de1b4878)\nMaven home:
> /home/hirsch/software/apache-maven-4.0.0-alpha-12\nJava version: 1.8.0_192,
> vendor: Oracle Corporation, runtime: /home/hirsch/jdk1.8.0_192/jre\nDefault
> locale: de_DE, platform encoding: UTF-8\nOS name: "linux", version:
> "5.15.0-91-generic", arch: "amd64", family: "unix"\n[DEBUG] Created adapter
> factory; available factories [file-lock, rwlock-local, semaphore-local,
> noop]; available name mappers [discriminating, file-gav, file-hgav,
> file-static, gav, static]\n[DEBUG] Created new class realm maven.api\n[DEBUG]
> Importing foreign packages into class realm maven.api\n[DEBUG] Imported:
> jakarta.annotation.* < plexus.core\n[DEBUG] Imported: jakarta.inject.* <
> plexus.core\n[DEBUG] Imported: javax.annotation.* < plexus.core\n[DEBUG]
> Imported: javax.annotation.security.* < plexus.core\n[DEBUG] Imported:
> javax.inject.* < plexus.core\n[DEBUG] Imported: org.apache.maven.* <
> plexus.core\n[DEBUG] Imported: org.apache.maven.api < plexus.core\n[DEBUG]
> Imported: org.apache.maven.artifact < plexus.core\n[DEBUG] Imported:
> org.apache.maven.classrealm < plexus.core\n[DEBUG] Imported:
> org.apache.maven.cli < plexus.core\n[DEBUG] Imported:
> org.apache.maven.configuration < plexus.core\n[DEBUG] Imported:
> org.apache.maven.exception < plexus.core\n[DEBUG] Imported:
> org.apache.maven.execution < plexus.core\n[DEBUG] Imported:
> org.apache.maven.execution.scope < plexus.core\n[DEBUG] Imported:
> org.apache.maven.feature < plexus.core\n[DEBUG] Imported:
> org.apache.maven.graph < plexus.core\n[DEBUG] Imported:
> org.apache.maven.lifecycle < plexus.core\n[DEBUG] Imported:
> org.apache.maven.model < plexus.core\n[DEBUG] Imported:
> org.apache.maven.monitor < plexus.core\n[DEBUG] Imported:
> org.apache.maven.plugin < plexus.core\n[DEBUG] Imported:
> org.apache.maven.profiles < plexus.core\n[DEBUG] Imported:
> org.apache.maven.project < plexus.core\n[DEBUG] Imported:
> org.apache.maven.reporting < plexus.core\n[DEBUG] Imported:
> org.apache.maven.repository < plexus.core\n[DEBUG] Imported:
> org.apache.maven.rtinfo.* < plexus.core\n[DEBUG] Imported:
> org.apache.maven.settings < plexus.core\n[DEBUG] Imported:
> org.apache.maven.toolchain < plexus.core\n[DEBUG] Imported:
> org.apache.maven.usability < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.* < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.authentication < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.authorization < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.events < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.observers < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.proxy < plexus.core\n[DEBUG] Imported:
> org.apache.maven.wagon.repository < plexus.co
[jira] [Commented] (RAT-366) Switch to Reading preparing header text and processing in one call.
[ https://issues.apache.org/jira/browse/RAT-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841148#comment-17841148 ] ASF subversion and git services commented on RAT-366: - Commit 07a70af7960bb535ddf7e22db221a814996e8d67 in creadur-rat's branch refs/heads/feature/RAT-369 from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=07a70af7 ] Merge pull request #243 from Claudenw/addNotes RAT-355, RAT-366: updated changes.xml > Switch to Reading preparing header text and processing in one call. > --- > > Key: RAT-366 > URL: https://issues.apache.org/jira/browse/RAT-366 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16.1 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > Fix For: 0.17 > > > Currently the system spends a fair chunk of time processing input line by > line. The code path is much simplified if instead we read the maximum number > of lines that we would process under the old code and process that all at > once. > This will also improve memory footprint since the full text matcher will not > have to keep a copy of all the text it has seen so far, but rather just > process the block of text that is passed in. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-355) optionally Export XML configuration file as part of run.
[ https://issues.apache.org/jira/browse/RAT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841147#comment-17841147 ] ASF subversion and git services commented on RAT-355: - Commit 07a70af7960bb535ddf7e22db221a814996e8d67 in creadur-rat's branch refs/heads/feature/RAT-369 from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=07a70af7 ] Merge pull request #243 from Claudenw/addNotes RAT-355, RAT-366: updated changes.xml > optionally Export XML configuration file as part of run. > > > Key: RAT-355 > URL: https://issues.apache.org/jira/browse/RAT-355 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.17 > > > Currently multiples inputs are processed into the internal configuration. > This is request is to export the configuration as part of the processing of > the files. This will be an optional output into the XML result of the run. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-345) Dependency updates via dependabot performed for release 0.17
[ https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841140#comment-17841140 ] ASF subversion and git services commented on RAT-345: - Commit 658f61c6f37633787f0b480c39295e645c2a68d3 in creadur-rat's branch refs/heads/feature/RAT-369 from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=658f61c6 ] RAT-345: Merge pull request #239 from apache/dependabot/maven/org.apache-apache-32 Bump org.apache:apache from 31 to 32 > Dependency updates via dependabot performed for release 0.17 > > > Key: RAT-345 > URL: https://issues.apache.org/jira/browse/RAT-345 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > h1. Updates via dependabot in RAT 0.17 > h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 > * https://github.com/apache/creadur-rat/pull/209 3.25.2 > * https://github.com/apache/creadur-rat/pull/212 3.25.3 > h2. (/) Update slf4j-simple from 2.0.11 to 2.0.13 > * https://github.com/apache/creadur-rat/pull/213 2.0.12 > * https://github.com/apache/creadur-rat/pull/237 2.0.13 > h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 > * https://github.com/apache/creadur-rat/pull/211 > h2. (/) Update junit.version from 5.10.1 to 5.10.2 > * https://github.com/apache/creadur-rat/pull/210 > h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 > * https://github.com/apache/creadur-rat/pull/214 > h2. (/) Update commons-compress from 1.25.0 to 1.26.1 > * https://github.com/apache/creadur-rat/pull/215 1.26.0 > * https://github.com/apache/creadur-rat/pull/220 1.26.1 > h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 > * https://github.com/apache/creadur-rat/pull/219 3.2.0 > h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 > * https://github.com/apache/creadur-rat/pull/218 > h2. (/) Update actions/cache from 4.0.0 to 4.0.2 > * https://github.com/apache/creadur-rat/pull/217 4.0.1 > * https://github.com/apache/creadur-rat/pull/226 4.0.2 > h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0 > * https://github.com/apache/creadur-rat/pull/216 4.1.0 > * https://github.com/apache/creadur-rat/pull/222 4.2.0 > h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 > * https://github.com/apache/creadur-rat/pull/225 > h2. (/) Update gitignore-reader from 1.4.0 to 1.5.1 > * https://github.com/apache/creadur-rat/pull/229/ 1.5.1 > h2. (/) Update commons-io from 2.15.1 to 2.16.1 > * https://github.com/apache/creadur-rat/pull/231 2.16.0 > * https://github.com/apache/creadur-rat/pull/236 2.16.1 > h2. (/) Update maven-invoker-plugin from 3.6.0 to 3.6.1. > * https://github.com/apache/creadur-rat/pull/234 3.6.1 > h2. (/) Update org.apache.maven.plugin-tools:maven-plugin-annotations from > 3.11.0 to 3.12.0 > * https://github.com/apache/creadur-rat/pull/235 3.12.0 > h2. (/) Update commons-cli from 1.6.0 to 1.7.0 > * https://github.com/apache/creadur-rat/pull/241 1.7.0 > h2. (/) Update org.apache:apache (ASF-parent) from 31 to 32 > * https://github.com/apache/creadur-rat/pull/239 32 > h2. (/) Update org.apache.maven.plugins:maven-pmd-plugin from 3.21.2 to > 3.22.0 > * https://github.com/apache/creadur-rat/pull/245 3.22.0 > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > > h1. TODO before release > * add changelog entries for each above PRs -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-366) Switch to Reading preparing header text and processing in one call.
[ https://issues.apache.org/jira/browse/RAT-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841142#comment-17841142 ] ASF subversion and git services commented on RAT-366: - Commit 66e134635aa893c291df0b2b4c6e134d37b930c4 in creadur-rat's branch refs/heads/feature/RAT-369 from Claude Warren [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=66e13463 ] Merge pull request #233 from Claudenw/RAT-355_RAT-366_merge RAT-355 and RAT-366 fixes in one package > Switch to Reading preparing header text and processing in one call. > --- > > Key: RAT-366 > URL: https://issues.apache.org/jira/browse/RAT-366 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16.1 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > Fix For: 0.17 > > > Currently the system spends a fair chunk of time processing input line by > line. The code path is much simplified if instead we read the maximum number > of lines that we would process under the old code and process that all at > once. > This will also improve memory footprint since the full text matcher will not > have to keep a copy of all the text it has seen so far, but rather just > process the block of text that is passed in. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-366) Switch to Reading preparing header text and processing in one call.
[ https://issues.apache.org/jira/browse/RAT-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841144#comment-17841144 ] ASF subversion and git services commented on RAT-366: - Commit e5c95ed53f209c6c30e512d251500527d9535586 in creadur-rat's branch refs/heads/feature/RAT-369 from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=e5c95ed5 ] Merge pull request #242 from Claudenw/fix_closed_output RAT-355, RAT-366: Fixed closed output issue > Switch to Reading preparing header text and processing in one call. > --- > > Key: RAT-366 > URL: https://issues.apache.org/jira/browse/RAT-366 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16.1 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > Fix For: 0.17 > > > Currently the system spends a fair chunk of time processing input line by > line. The code path is much simplified if instead we read the maximum number > of lines that we would process under the old code and process that all at > once. > This will also improve memory footprint since the full text matcher will not > have to keep a copy of all the text it has seen so far, but rather just > process the block of text that is passed in. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-355) optionally Export XML configuration file as part of run.
[ https://issues.apache.org/jira/browse/RAT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841143#comment-17841143 ] ASF subversion and git services commented on RAT-355: - Commit e5c95ed53f209c6c30e512d251500527d9535586 in creadur-rat's branch refs/heads/feature/RAT-369 from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=e5c95ed5 ] Merge pull request #242 from Claudenw/fix_closed_output RAT-355, RAT-366: Fixed closed output issue > optionally Export XML configuration file as part of run. > > > Key: RAT-355 > URL: https://issues.apache.org/jira/browse/RAT-355 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.17 > > > Currently multiples inputs are processed into the internal configuration. > This is request is to export the configuration as part of the processing of > the files. This will be an optional output into the XML result of the run. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-355) optionally Export XML configuration file as part of run.
[ https://issues.apache.org/jira/browse/RAT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841141#comment-17841141 ] ASF subversion and git services commented on RAT-355: - Commit 66e134635aa893c291df0b2b4c6e134d37b930c4 in creadur-rat's branch refs/heads/feature/RAT-369 from Claude Warren [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=66e13463 ] Merge pull request #233 from Claudenw/RAT-355_RAT-366_merge RAT-355 and RAT-366 fixes in one package > optionally Export XML configuration file as part of run. > > > Key: RAT-355 > URL: https://issues.apache.org/jira/browse/RAT-355 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.17 > > > Currently multiples inputs are processed into the internal configuration. > This is request is to export the configuration as part of the processing of > the files. This will be an optional output into the XML result of the run. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-368: removed unused files [creadur-rat]
ottlinger commented on PR #244: URL: https://github.com/apache/creadur-rat/pull/244#issuecomment-2079148053 Could you add a changelog entry as well to announce that which classes may be removed in 0.18.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-368: removed unused files [creadur-rat]
ottlinger commented on PR #244: URL: https://github.com/apache/creadur-rat/pull/244#issuecomment-2079147363 Go ahead - I'm not sure if any of these classes are referenced in the docs . @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (RAT-345) Dependency updates via dependabot performed for release 0.17
[ https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-345: -- Description: h1. Updates via dependabot in RAT 0.17 h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 * https://github.com/apache/creadur-rat/pull/209 3.25.2 * https://github.com/apache/creadur-rat/pull/212 3.25.3 h2. (/) Update slf4j-simple from 2.0.11 to 2.0.13 * https://github.com/apache/creadur-rat/pull/213 2.0.12 * https://github.com/apache/creadur-rat/pull/237 2.0.13 h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 * https://github.com/apache/creadur-rat/pull/211 h2. (/) Update junit.version from 5.10.1 to 5.10.2 * https://github.com/apache/creadur-rat/pull/210 h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 * https://github.com/apache/creadur-rat/pull/214 h2. (/) Update commons-compress from 1.25.0 to 1.26.1 * https://github.com/apache/creadur-rat/pull/215 1.26.0 * https://github.com/apache/creadur-rat/pull/220 1.26.1 h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 * https://github.com/apache/creadur-rat/pull/219 3.2.0 h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 * https://github.com/apache/creadur-rat/pull/218 h2. (/) Update actions/cache from 4.0.0 to 4.0.2 * https://github.com/apache/creadur-rat/pull/217 4.0.1 * https://github.com/apache/creadur-rat/pull/226 4.0.2 h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0 * https://github.com/apache/creadur-rat/pull/216 4.1.0 * https://github.com/apache/creadur-rat/pull/222 4.2.0 h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 * https://github.com/apache/creadur-rat/pull/225 h2. (/) Update gitignore-reader from 1.4.0 to 1.5.1 * https://github.com/apache/creadur-rat/pull/229/ 1.5.1 h2. (/) Update commons-io from 2.15.1 to 2.16.1 * https://github.com/apache/creadur-rat/pull/231 2.16.0 * https://github.com/apache/creadur-rat/pull/236 2.16.1 h2. (/) Update maven-invoker-plugin from 3.6.0 to 3.6.1. * https://github.com/apache/creadur-rat/pull/234 3.6.1 h2. (/) Update org.apache.maven.plugin-tools:maven-plugin-annotations from 3.11.0 to 3.12.0 * https://github.com/apache/creadur-rat/pull/235 3.12.0 h2. (/) Update commons-cli from 1.6.0 to 1.7.0 * https://github.com/apache/creadur-rat/pull/241 1.7.0 h2. (/) Update org.apache:apache (ASF-parent) from 31 to 32 * https://github.com/apache/creadur-rat/pull/239 32 h2. (/) Update org.apache.maven.plugins:maven-pmd-plugin from 3.21.2 to 3.22.0 * https://github.com/apache/creadur-rat/pull/245 3.22.0 h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h1. TODO before release * add changelog entries for each above PRs was: h1. Updates via dependabot in RAT 0.17 h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 * https://github.com/apache/creadur-rat/pull/209 3.25.2 * https://github.com/apache/creadur-rat/pull/212 3.25.3 h2. (/) Update slf4j-simple from 2.0.11 to 2.0.13 * https://github.com/apache/creadur-rat/pull/213 2.0.12 * https://github.com/apache/creadur-rat/pull/237 2.0.13 h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 * https://github.com/apache/creadur-rat/pull/211 h2. (/) Update junit.version from 5.10.1 to 5.10.2 * https://github.com/apache/creadur-rat/pull/210 h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 * https://github.com/apache/creadur-rat/pull/214 h2. (/) Update commons-compress from 1.25.0 to 1.26.1 * https://github.com/apache/creadur-rat/pull/215 1.26.0 * https://github.com/apache/creadur-rat/pull/220 1.26.1 h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 * https://github.com/apache/creadur-rat/pull/219 3.2.0 h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 * https://github.com/apache/creadur-rat/pull/218 h2. (/) Update actions/cache from 4.0.0 to 4.0.2 * https://github.com/apache/creadur-rat/pull/217 4.0.1 * https://github.com/apache/creadur-rat/pull/226 4.0.2 h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0 * https://github.com/apache/creadur-rat/pull/216 4.1.0 * https://github.com/apache/creadur-rat/pull/222 4.2.0 h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 * https://github.com/apache/creadur-rat/pull/225 h2. (/) Update gitignore-reader from 1.4.0 to 1.5.1 * https://github.com/apache/creadur-rat/pull/229/ 1.5.1 h2. (/) Update commons-io from 2.15.1 to 2.16.1 * https://github.com/apache/creadur-rat/pull/231 2.16.0 * https://github.com/apache/creadur-rat/pull/236 2.16.1 h2. (/) Update maven-invoker-plugin from 3.6.0 to 3.6.1. * https://github.com/apache/creadur-rat/pull/234 3.6.1 h2. (/) Update org.apache.maven.plugin-tools:maven-plugin-annotations from 3.11.0 to 3.12.0 * https://github.com/apache/creadur-rat/pull/235 3.12.0 h2. (/) Update commons-cli from 1.6.0 to 1.7.0 * https://github.com/apache/creadur-rat/pull/241 1.7.0 h2. (/) Update org.apache:apache (ASF-parent) from 31 to 32 * https://github.co
Re: [PR] RAT-345: Bump org.apache.maven.plugins:maven-pmd-plugin from 3.21.2 to 3.22.0 [creadur-rat]
ottlinger merged PR #245: URL: https://github.com/apache/creadur-rat/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-pmd-plugin from 3.21.2 to 3.22.0 [creadur-whisker]
ottlinger merged PR #143: URL: https://github.com/apache/creadur-whisker/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]
Claudenw commented on PR #240: URL: https://github.com/apache/creadur-rat/pull/240#issuecomment-2078759677 I am adding a file filter to remove json files. Initially this will be hard coded. I will open a subsequent ticket to generalize it so that we can define a list of extensions to remove. This will probably mean more command line options. So I'll have to open that can of worms as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-368: removed unused files [creadur-rat]
Claudenw commented on PR #244: URL: https://github.com/apache/creadur-rat/pull/244#issuecomment-2078756986 @ottlinger @jbonofre if neither of you see any issues I'll go ahead and merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
