[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/140#issuecomment-202669736 Looks OK to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/140#issuecomment-202669627 I updated the method doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/140#issuecomment-202668460 Looks like an OK short fix to me. We probably need to document the new contract (call waitForInitialCreate before calling setData) somewhere? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup
Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/140#discussion_r57663793
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
@@ -317,6 +317,7 @@ public String getActualPath()
public void setData(byte[] data) throws Exception
{
data = Preconditions.checkNotNull(data, "data cannot be null");
+Preconditions.checkState(nodePath.get() != null, "initial create
has not been processed. Call waitForInitialCreate() to ensure.");
this.data.set(Arrays.copyOf(data, data.length));
--- End diff --
Yes, good point
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/140#discussion_r57663645
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
@@ -317,6 +317,7 @@ public String getActualPath()
public void setData(byte[] data) throws Exception
{
data = Preconditions.checkNotNull(data, "data cannot be null");
+Preconditions.checkState(nodePath.get() != null, "initial create
has not been processed. Call waitForInitialCreate() to ensure.");
this.data.set(Arrays.copyOf(data, data.length));
--- End diff --
The current behavior is undefined. I can't imagine anyone is dependent on
an NPE. Right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup
Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/140#discussion_r57663597
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
@@ -317,6 +317,7 @@ public String getActualPath()
public void setData(byte[] data) throws Exception
{
data = Preconditions.checkNotNull(data, "data cannot be null");
+Preconditions.checkState(nodePath.get() != null, "initial create
has not been processed. Call waitForInitialCreate() to ensure.");
this.data.set(Arrays.copyOf(data, data.length));
--- End diff --
Isn't this potentially going to break legacy clients depending on how they
handle exceptions thrown from this method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
