[GitHub] [cxf] reta commented on pull request #807: CXF-8532: @Priority support for ParamConverterProvider

[GitBox]

reta commented on pull request #807:
URL: https://github.com/apache/cxf/pull/807#issuecomment-851717489


   @andymc12 my apologies, double-checked the implementation, the 
`MicroProfileClientProviderFactory::createComparator` is all set, it uses 
`ContractComparator` which uses the delegating comparator (the one which 
confused me) but itself check the priorities. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Releases soon?

[Freeman Fang]

+1 for a new release.

Thanks Colm!
Freeman

On Fri, May 28, 2021 at 4:25 AM Colm O hEigeartaigh 
wrote:

> Hi all,
>
> It's been over two months since the last set of releases, shall we get
> the next releases out soon? What remains to be fixed?
>
> Colm.
>

[GitHub] [cxf] brevilo edited a comment on pull request #805: Make CDI and MP Config dependencies optional for MicroProfile REST client

[GitBox]

brevilo edited a comment on pull request #805:
URL: https://github.com/apache/cxf/pull/805#issuecomment-850852978


   Sorry, I don't have enough context knowledge to provide the additional tests 
needed. The overall goal here is to make CDI and MP Config optional for the MP 
REST client, as the [spec 
mandates](https://download.eclipse.org/microprofile/microprofile-rest-client-2.0/microprofile-rest-client-spec-2.0.html#integration)
 
([confirmed](https://github.com/eclipse/microprofile-rest-client/issues/308#issuecomment-806057762)
 by @andymc12). How do we best proceed to achieve this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] coheigea commented on a change in pull request #768: Cxf 8445

[GitBox]

coheigea commented on a change in pull request #768:
URL: https://github.com/apache/cxf/pull/768#discussion_r642273107



##
File path: core/src/main/java/org/apache/cxf/attachment/AttachmentUtil.java
##
@@ -170,18 +170,31 @@ public static boolean isMtomEnabled(Message message) {
 public static void setStreamedAttachmentProperties(Message message, 
CachedOutputStream bos)
 throws IOException {
 Object directory = 
message.getContextualProperty(AttachmentDeserializer.ATTACHMENT_DIRECTORY);
+setOutputDirectory(directory, bos);
+
+Object threshold = 
message.getContextualProperty(AttachmentDeserializer.ATTACHMENT_MEMORY_THRESHOLD);
+setThreshold(threshold, bos);
+
+Object maxSize = 
message.getContextualProperty(AttachmentDeserializer.ATTACHMENT_MAX_SIZE);
+setMaxSize(maxSize, bos);
+}
+
+private static void setOutputDirectory(Object directory, 
CachedOutputStream bos) throws IOException {
 if (directory != null) {
 if (directory instanceof File) {
-bos.setOutputDir((File) directory);
+bos.setOutputDir((File)directory);
 } else if (directory instanceof String) {
-bos.setOutputDir(new File((String) directory));
+String directoryStr  = (String)directory;
+directoryStr = directoryStr.replace("..", "");

Review comment:
   How is this change related to the overall PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org