[GitHub] rmannibucau commented on a change in pull request #487: Ensure JAXB and javax.activation are not required for JAX-RS

2019-01-09 Thread GitBox 
rmannibucau commented on a change in pull request #487: Ensure JAXB and 
javax.activation are not required for JAX-RS
URL: https://github.com/apache/cxf/pull/487#discussion_r246412596
 
 

 ##
 File path: core/src/main/java/org/apache/cxf/service/model/EndpointInfo.java
 ##
 @@ -94,7 +95,12 @@ public String getAddress() {
 
 public void setAddress(String addr) {
 if (null == address) {
-address = EndpointReferenceUtils.getEndpointReference(addr);
+// address = EndpointReferenceUtils.getEndpointReference(addr); 
loads jaxb and we want to avoid it
+final EndpointReferenceType reference = new 
EndpointReferenceType();
+final AttributedURIType a = new AttributedURIType();
+a.setValue("/");
 
 Review comment:
   Hmm, sure? address is null here so it defaults to "/" but good catch i 
forgot the else ;)
   
   edit: pushed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rmannibucau commented on a change in pull request #487: Ensure JAXB and javax.activation are not required for JAX-RS

2019-01-09 Thread GitBox 
rmannibucau commented on a change in pull request #487: Ensure JAXB and 
javax.activation are not required for JAX-RS
URL: https://github.com/apache/cxf/pull/487#discussion_r246412596
 
 

 ##
 File path: core/src/main/java/org/apache/cxf/service/model/EndpointInfo.java
 ##
 @@ -94,7 +95,12 @@ public String getAddress() {
 
 public void setAddress(String addr) {
 if (null == address) {
-address = EndpointReferenceUtils.getEndpointReference(addr);
+// address = EndpointReferenceUtils.getEndpointReference(addr); 
loads jaxb and we want to avoid it
+final EndpointReferenceType reference = new 
EndpointReferenceType();
+final AttributedURIType a = new AttributedURIType();
+a.setValue("/");
 
 Review comment:
   s/address/addr/
   
   edit: pushed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services