Re: Backport Microprofile Client to 3.1.x branch

2018-03-01 Thread Roberto Cortez
 
Hi Andy,
Thank you for your response.
Yeah I keep forgetting the Java 7 / Java 8 issue. 
I did try to use the 3.2.x client with the rest of the 3.1.x, but there are a 
couple of API in the core that were made public on 3.2.x which are private in 
3.1.x, so you get IllegalAccessError.
I see that you just override that piece, so I'll probably would need to do the 
same.
Thanks you for the help :)
Cheers,RobertoOn Wednesday, February 28, 2018, 7:48:41 PM GMT, Andy 
McCright  wrote:  
 
 Hi Roberto,

I think it is a good idea.  The main drawback is that the 3.1.X stream
requires compatibility with Java 7.  The MicroProfile spec and Rest Client
specifically sets Java 8 as the minimum Java level - and the Rest Client
specifically makes use of Java 8 syntax and APIs, like lambdas and default
interface methods.  I don't think it will be possible to build in 3.1.X
without a Java 8 compiler.  That might be possible, but might not be a good
idea because then the MP Rest Client module will be out of sync with the
other modules in the 3.1.X stream.

One thing you might consider would be have your projects depend on the MP
Rest Client module from 3.2.X, but the rest of CXF be at the 3.1.X level.
You would need to run with Java 8 - and there are probably some other
changes in the 3.2.X stream that would need to be back ported for
compatibility.  I did something similar in OpenLiberty here [1] that might
help you.

Hope this helps,

Andy

[1] https://github.com/OpenLiberty/open-liberty/pull/1558

On Wed, Feb 28, 2018 at 4:40 AM, Roberto Cortez  wrote:

> Hi,
> I was wondering if it would be ok to backport the Microprofile Client
> module from the master branch in the 3.1.x branch.
> This is because the latest spec of Microprofile, version 1.3, targets
> JAX-RS 2.0 and requires the Rest Client 1.0, implemented in 3.2.x, which is
> JAX-RS 2.1.
> If this is ok, I wouldn't mind submitting a PR myself with the port.
> Cheers,Roberto
  

Re: Backport Microprofile Client to 3.1.x branch

2018-02-28 Thread Andy McCright
Hi Roberto,

I think it is a good idea.  The main drawback is that the 3.1.X stream
requires compatibility with Java 7.  The MicroProfile spec and Rest Client
specifically sets Java 8 as the minimum Java level - and the Rest Client
specifically makes use of Java 8 syntax and APIs, like lambdas and default
interface methods.  I don't think it will be possible to build in 3.1.X
without a Java 8 compiler.  That might be possible, but might not be a good
idea because then the MP Rest Client module will be out of sync with the
other modules in the 3.1.X stream.

One thing you might consider would be have your projects depend on the MP
Rest Client module from 3.2.X, but the rest of CXF be at the 3.1.X level.
You would need to run with Java 8 - and there are probably some other
changes in the 3.2.X stream that would need to be back ported for
compatibility.  I did something similar in OpenLiberty here [1] that might
help you.

Hope this helps,

Andy

[1] https://github.com/OpenLiberty/open-liberty/pull/1558

On Wed, Feb 28, 2018 at 4:40 AM, Roberto Cortez  wrote:

> Hi,
> I was wondering if it would be ok to backport the Microprofile Client
> module from the master branch in the 3.1.x branch.
> This is because the latest spec of Microprofile, version 1.3, targets
> JAX-RS 2.0 and requires the Rest Client 1.0, implemented in 3.2.x, which is
> JAX-RS 2.1.
> If this is ok, I wouldn't mind submitting a PR myself with the port.
> Cheers,Roberto


Backport Microprofile Client to 3.1.x branch

2018-02-28 Thread Roberto Cortez
Hi,
I was wondering if it would be ok to backport the Microprofile Client module 
from the master branch in the 3.1.x branch.
This is because the latest spec of Microprofile, version 1.3, targets JAX-RS 
2.0 and requires the Rest Client 1.0, implemented in 3.2.x, which is JAX-RS 2.1.
If this is ok, I wouldn't mind submitting a PR myself with the port.
Cheers,Roberto