[GitHub] jadams-tresys opened a new pull request #168: Keep line/column info for Daffodil tests
jadams-tresys opened a new pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168 We had been adding line and column attributes to the schemas we were testing against in order to provide more helpful error messages. These attributes were causing issues with the IBM DFDL processor and were removed. This commit allows the TDMLRunner to detect if it is running the IBM DFDL implementation and remove these attributes as needed, while keeping them for the Daffodil implementation. DAFFODIL-2050 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (DAFFODIL-2051) Many tests are OS-dependent and fail on Windows platform
[ https://issues.apache.org/jira/browse/DAFFODIL-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence resolved DAFFODIL-2051. -- Resolution: Fixed Fixed in commit ba2c3b1337aa22d352eae3b32f044ffdf00575db > Many tests are OS-dependent and fail on Windows platform > > > Key: DAFFODIL-2051 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2051 > Project: Daffodil > Issue Type: Test > Components: General >Affects Versions: 2.2.0 > Environment: Dell Lattitude 7450 Laptop, Windows 8.1, Java SDK > 11.0.1, SBT 1.2.7, Daffodil 2.2.0 >Reporter: Mark C. Otto >Assignee: Mark C. Otto >Priority: Major > Labels: test, windows > Fix For: 2.3.0 > > Attachments: erroroutput.txt > > Original Estimate: 840h > Remaining Estimate: 840h > > Many tests are not written in an OS-independent manner. Most of these fail > due to OS-dependent line termination differences (LF vs. CR/LF). While some > of this was covered in DAFFODIL-1360, that bug was insufficient in scope and > detail to cover the issues listed here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (DAFFODIL-1360) Some TDML Tests not Windows Compatible
[ https://issues.apache.org/jira/browse/DAFFODIL-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark C. Otto reassigned DAFFODIL-1360: -- Assignee: Steve Lawrence (was: Mark C. Otto) Fixed as part of DAFFODIL-2051. Reassigned to Steve L. for resolution. Thanks. > Some TDML Tests not Windows Compatible > -- > > Key: DAFFODIL-1360 > URL: https://issues.apache.org/jira/browse/DAFFODIL-1360 > Project: Daffodil > Issue Type: Wish > Components: QA, TDML Runner, Windows >Reporter: Jessie Chab >Assignee: Steve Lawrence >Priority: Major > > test_prefix_separator_as_variable > test_internal_space_preserved_3b > test_internal_space_preserved_2 > The "internal_space_preserved" tests seem to be a newline issue. However, > test_prefix_separator_as_variable is a user-submitted test, and does not > appear to be failing for the same reason -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (DAFFODIL-1360) Some TDML Tests not Windows Compatible
[ https://issues.apache.org/jira/browse/DAFFODIL-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence resolved DAFFODIL-1360. -- Resolution: Duplicate Fix Version/s: 2.3.0 > Some TDML Tests not Windows Compatible > -- > > Key: DAFFODIL-1360 > URL: https://issues.apache.org/jira/browse/DAFFODIL-1360 > Project: Daffodil > Issue Type: Wish > Components: QA, TDML Runner, Windows >Reporter: Jessie Chab >Assignee: Steve Lawrence >Priority: Major > Fix For: 2.3.0 > > > test_prefix_separator_as_variable > test_internal_space_preserved_3b > test_internal_space_preserved_2 > The "internal_space_preserved" tests seem to be a newline issue. However, > test_prefix_separator_as_variable is a user-submitted test, and does not > appear to be failing for the same reason -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (DAFFODIL-1227) XML Pretty Printer tests not Windows compatible
[ https://issues.apache.org/jira/browse/DAFFODIL-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence resolved DAFFODIL-1227. -- Resolution: Duplicate Fix Version/s: 2.3.0 > XML Pretty Printer tests not Windows compatible > --- > > Key: DAFFODIL-1227 > URL: https://issues.apache.org/jira/browse/DAFFODIL-1227 > Project: Daffodil > Issue Type: Wish > Components: Windows >Reporter: Jessie Chab >Assignee: Steve Lawrence >Priority: Major > Fix For: 2.3.0 > > > The following tests fail on Windows 7 64-bit: > test_daffodil_pretty_printer_will_format_to_20_columns > test_daffodil_pretty_printer_preserves_whitespace_inside_cdata_properly2 > test_daffodil_pretty_printer_preserves_whitespace_inside_cdata_properly3 > They all fail with this error: > failed: null > with no accompanying traceback -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (DAFFODIL-1227) XML Pretty Printer tests not Windows compatible
[ https://issues.apache.org/jira/browse/DAFFODIL-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark C. Otto reassigned DAFFODIL-1227: -- Assignee: Steve Lawrence (was: Mark C. Otto) This is fixed in DAFFODIL-2051. Thanks. > XML Pretty Printer tests not Windows compatible > --- > > Key: DAFFODIL-1227 > URL: https://issues.apache.org/jira/browse/DAFFODIL-1227 > Project: Daffodil > Issue Type: Wish > Components: Windows >Reporter: Jessie Chab >Assignee: Steve Lawrence >Priority: Major > > The following tests fail on Windows 7 64-bit: > test_daffodil_pretty_printer_will_format_to_20_columns > test_daffodil_pretty_printer_preserves_whitespace_inside_cdata_properly2 > test_daffodil_pretty_printer_preserves_whitespace_inside_cdata_properly3 > They all fail with this error: > failed: null > with no accompanying traceback -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows
stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455574596 Looks like the ratCheck is still failing. Can you please look into that? I think you maybe just need to fetch the latest and rebase ontop of master. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (DAFFODIL-1810) Tests fail on MS-Windows due to CRLF vs LF
[
https://issues.apache.org/jira/browse/DAFFODIL-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark C. Otto updated DAFFODIL-1810:
---
Fix Version/s: 2.3.0
> Tests fail on MS-Windows due to CRLF vs LF
> --
>
> Key: DAFFODIL-1810
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1810
> Project: Daffodil
> Issue Type: Improvement
> Components: QA, Windows
> Environment: MS Windows
>Reporter: Michael Beckerle
>Assignee: Mark C. Otto
>Priority: Major
> Labels: beginner
> Fix For: 2.3.0
>
>
> This bug looks like a windows line-ending (CRLF) vs. unix line ending (LF)
> problem. I.e., real bug in test because it is line-ending sensitive. When I
> look at this in Emacs it shows me the CRs as ^M. Every line ends with a ^M
> except the ones I marked with ### below.
> THere are several of this same failure. These are tests related to internal
> whitespace preservation, so it's a place where Windows vs. Linux sensitivity
> may come up.
> {code}
> [error] Test
> edu.illinois.ncsa.daffodil.section23.dfdl_expressions.TestDFDLExpressions.test_internal_space_preserved3b
> failed: java.lang.Exception:
> [error] Comparison failed.
> [error] Expected
> [error] 2a
> [error] b
> [error] c
> [error] Actual
> [error] 2a ### no ^M here
> [error] b### no ^M here
> [error] c
> [error] Differences were (path, expected, actual):
> [error] (expr_space3b/value,'a
> [error] b
> [error] c','a### no ^M here
> [error] b### no ^M here
> [error] c'), took 0.618 sec
> {code}
> We need to change these tests so they are portable somehow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (DAFFODIL-2051) Many tests are OS-dependent and fail on Windows platform
[ https://issues.apache.org/jira/browse/DAFFODIL-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence reopened DAFFODIL-2051: -- We cannot mark this issue as resolved until the pull request is accepted and merged into master. The PR is still failing due to a ratCheck failure so cannot be merged. Reopening until that is fixed. > Many tests are OS-dependent and fail on Windows platform > > > Key: DAFFODIL-2051 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2051 > Project: Daffodil > Issue Type: Test > Components: General >Affects Versions: 2.2.0 > Environment: Dell Lattitude 7450 Laptop, Windows 8.1, Java SDK > 11.0.1, SBT 1.2.7, Daffodil 2.2.0 >Reporter: Mark C. Otto >Assignee: Mark C. Otto >Priority: Major > Labels: test, windows > Fix For: 2.3.0 > > Attachments: erroroutput.txt > > Original Estimate: 840h > Remaining Estimate: 840h > > Many tests are not written in an OS-independent manner. Most of these fail > due to OS-dependent line termination differences (LF vs. CR/LF). While some > of this was covered in DAFFODIL-1360, that bug was insufficient in scope and > detail to cover the issues listed here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (DAFFODIL-2051) Many tests are OS-dependent and fail on Windows platform
[ https://issues.apache.org/jira/browse/DAFFODIL-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark C. Otto resolved DAFFODIL-2051. Resolution: Fixed Fix Version/s: 2.3.0 Changed numerous tests to be consistent in line termination regardless of OS used. > Many tests are OS-dependent and fail on Windows platform > > > Key: DAFFODIL-2051 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2051 > Project: Daffodil > Issue Type: Test > Components: General >Affects Versions: 2.2.0 > Environment: Dell Lattitude 7450 Laptop, Windows 8.1, Java SDK > 11.0.1, SBT 1.2.7, Daffodil 2.2.0 >Reporter: Mark C. Otto >Assignee: Mark C. Otto >Priority: Major > Labels: test, windows > Fix For: 2.3.0 > > Attachments: erroroutput.txt > > Original Estimate: 840h > Remaining Estimate: 840h > > Many tests are not written in an OS-independent manner. Most of these fail > due to OS-dependent line termination differences (LF vs. CR/LF). While some > of this was covered in DAFFODIL-1360, that bug was insufficient in scope and > detail to cover the issues listed here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DAFFODIL-2051) Many tests are OS-dependent and fail on Windows platform
[ https://issues.apache.org/jira/browse/DAFFODIL-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark C. Otto updated DAFFODIL-2051: --- Environment: Dell Lattitude 7450 Laptop, Windows 8.1, Java SDK 11.0.1, SBT 1.2.7, Daffodil 2.2.0 (was: Dell Lattitude 7450 Laptop, Windows 8.1, Java SDK 11.0.1, SBT 1.2.7, Daffodil 2.2.1) > Many tests are OS-dependent and fail on Windows platform > > > Key: DAFFODIL-2051 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2051 > Project: Daffodil > Issue Type: Test > Components: General >Affects Versions: 2.2.0 > Environment: Dell Lattitude 7450 Laptop, Windows 8.1, Java SDK > 11.0.1, SBT 1.2.7, Daffodil 2.2.0 >Reporter: Mark C. Otto >Assignee: Mark C. Otto >Priority: Major > Labels: test, windows > Attachments: erroroutput.txt > > Original Estimate: 840h > Remaining Estimate: 840h > > Many tests are not written in an OS-independent manner. Most of these fail > due to OS-dependent line termination differences (LF vs. CR/LF). While some > of this was covered in DAFFODIL-1360, that bug was insufficient in scope and > detail to cover the issues listed here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DAFFODIL-2051) Many tests are OS-dependent and fail on Windows platform
[ https://issues.apache.org/jira/browse/DAFFODIL-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark C. Otto updated DAFFODIL-2051: --- Description: Many tests are not written in an OS-independent manner. Most of these fail due to OS-dependent line termination differences (LF vs. CR/LF). While some of this was covered in DAFFODIL-1360, that bug was insufficient in scope and detail to cover the issues listed here. (was: Many tests are not written in an OS-independent manner. Most of these fail due to OS-dependent line termination differences (LF vs. CR/LF). While some of this was covered in DAFFODIP-1360, that bug was insufficient in scope and detail to cover the issues listed here.) > Many tests are OS-dependent and fail on Windows platform > > > Key: DAFFODIL-2051 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2051 > Project: Daffodil > Issue Type: Test > Components: General >Affects Versions: 2.2.0 > Environment: Dell Lattitude 7450 Laptop, Windows 8.1, Java SDK > 11.0.1, SBT 1.2.7, Daffodil 2.2.1 >Reporter: Mark C. Otto >Assignee: Mark C. Otto >Priority: Major > Labels: test, windows > Attachments: erroroutput.txt > > Original Estimate: 840h > Remaining Estimate: 840h > > Many tests are not written in an OS-independent manner. Most of these fail > due to OS-dependent line termination differences (LF vs. CR/LF). While some > of this was covered in DAFFODIL-1360, that bug was insufficient in scope and > detail to cover the issues listed here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
