Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Beckerle, Mike
+1


I verified Steve's PGP signature.


I tested all the DFDL schemas I have access to. All work - minor additions 
needed of missing properties. Actually found a couple misspelled properties 
with new features of this release.


Tested these which are generally available:


bmp
CSV
EDIFACT
geonames
gif
HL7
IBM4690-TLOG
ISO8583
jpeg
MagVar
mil-std-2045
NACHA
NITF
PCAP
png
quasiXML
utf8test

Also tested these which are not generally available:

agnosc_remedy
army_drrs_lh
cef
disv6
gmtif
iCalendar
imf
imf_iCalendar_cse
ipfix
nato-stanag-5516
uscg_ucop_lh
usmtf
vmf
vmf_s2s



From: Beckerle, Mike
Sent: Wednesday, July 3, 2019 12:11:06 PM
To: dev@daffodil.apache.org
Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1


Ah! yes I will correct the schema. That property isn't allowed there, and prior 
releases were just ignoring that.


I also found a typo in a short-form property name on a related schema. So this 
feature is helping find bugs.


From: Steve Lawrence 
Sent: Wednesday, July 3, 2019 12:04:05 PM
To: dev@daffodil.apache.org
Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

According to the DFDL doc, escapeSchemaRef is only valid on dfdl:element
and dfdl:simpleType. Is the schema just incorrect? Sounds to me like
validation found an error in the schema, assuming the DFDL spec is right.

- Steve

On 7/3/19 12:00 PM, Beckerle, Mike wrote:
>
> I have tested existing schemas to be sure we haven't broken anything.
>
>
> Alas, I have an iCalendar schema that works in 2.2.0, and 2.3.0, but fails to 
> compile on 2.4.0 with this diagnostic:
>
>
> [error] Test com.mitre.iCalendar.Test_iCalendar.test_ex02 failed: 
> org.apache.daffodil.tdml.TDMLExceptionImpl: (Implementation: daffodil) 
> SchemaDefinitionError: Schema Definition Error: Error loading schema due to 
> org.xml.sax.SAXParseException; systemId: 
> file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd;
>  lineNumber: 245; columnNumber: 74; cvc-complex-type.3.2.2: Attribute 
> 'dfdl:escapeSchemeRef' is not allowed to appear in element 'xs:sequence'.
> [error] Schema context: 
> file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd
>  Location in 
> file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd,
>  took 0.082 sec
>
>
> So my best guess is something about changes to fix validation of short form 
> properties is refusing to allow this property.
>
>
> I will continue to test other schemas so we can get a list of which remain 
> compatible, and which do not.
>
>
> I'm not going to vote yet. We'll see if there are other flaws with existing 
> schemas first.
>
>
>
> 
> From: Steve Lawrence 
> Sent: Wednesday, July 3, 2019 9:03:45 AM
> To: dev@daffodil.apache.org
> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
>
> Hi all,
>
> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
>
> All distribution packages, including signatures, digests, etc. can be
> found at:
>
> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
>
> Staging artifacts can be found at:
>
> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
>
> This release has been signed with PGP key 36F3494B033AE661,
> corresponding to slawre...@apache.org, which is included in the KEYS
> file here:
>
> https://www.apache.org/dist/incubator/daffodil/KEYS
>
> The release candidate has been tagged in git with v2.4.0-rc1.
>
> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
>
> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> For a summary of the changes in this release, see:
>
> https://daffodil.apache.org/releases/2.4.0/
>
> Please review and vote. The vote will be open for at least 72 hours
> (Saturday, 6 July 2019, 9am EST).
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thanks,
> - Steve
>



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Dave Fisher



> On Jul 3, 2019, at 10:11 AM, Steve Lawrence  wrote:
> 
> We actually use the sbt rat plugin, which is configured in the
> project/Rat.scala file. So all of our excludes are in there, and can be
> checked via "sbt ratCheck", with the rat report output in
> target/rat.txt. Would it be preferred that we additionally maintain a
> .rat-excludes so that people can manually run the rat tool?

No, that worked fine. Thank you!

Regards,
Dave

> 
> On 7/3/19 12:59 PM, Dave Fisher wrote:
>> +1 (binding)
>> 
>> Signatures and hashes are all correct.
>> DISCLAIMER is correct
>> NOTICE and LICENSE look good.
>> Rat check is good.
>> 
>> Please add a .rat-excludes file for the next release. This will make license 
>> checking easier.
>> 
>> HTH,
>> Dave
>> 
>>> On Jul 3, 2019, at 7:50 AM, Adams, Joshua  wrote:
>>> 
>>> +1
>>> 
>>> I checked the following:
>>> - incubating in name
>>> - signatures and hashes are all correct
>>> - DISCLAIMER exists
>>> - NOTICE looks correct
>>> - LICENSE looks correct
>>> 
>>> Josh
>>> 
>>> From: Steve Lawrence 
>>> Sent: Wednesday, July 3, 2019 9:03 AM
>>> To: dev@daffodil.apache.org
>>> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
>>> 
>>> Hi all,
>>> 
>>> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
>>> 
>>> All distribution packages, including signatures, digests, etc. can be
>>> found at:
>>> 
>>> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
>>> 
>>> Staging artifacts can be found at:
>>> 
>>> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
>>> 
>>> This release has been signed with PGP key 36F3494B033AE661,
>>> corresponding to slawre...@apache.org, which is included in the KEYS
>>> file here:
>>> 
>>> https://www.apache.org/dist/incubator/daffodil/KEYS
>>> 
>>> The release candidate has been tagged in git with v2.4.0-rc1.
>>> 
>>> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
>>> 
>>> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>>> 
>>> For a summary of the changes in this release, see:
>>> 
>>> https://daffodil.apache.org/releases/2.4.0/
>>> 
>>> Please review and vote. The vote will be open for at least 72 hours
>>> (Saturday, 6 July 2019, 9am EST).
>>> 
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove (and reason why)
>>> 
>>> Thanks,
>>> - Steve
>> 
> 



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Steve Lawrence
We actually use the sbt rat plugin, which is configured in the
project/Rat.scala file. So all of our excludes are in there, and can be
checked via "sbt ratCheck", with the rat report output in
target/rat.txt. Would it be preferred that we additionally maintain a
.rat-excludes so that people can manually run the rat tool?

On 7/3/19 12:59 PM, Dave Fisher wrote:
> +1 (binding)
> 
> Signatures and hashes are all correct.
> DISCLAIMER is correct
> NOTICE and LICENSE look good.
> Rat check is good.
> 
> Please add a .rat-excludes file for the next release. This will make license 
> checking easier.
> 
> HTH,
> Dave
> 
>> On Jul 3, 2019, at 7:50 AM, Adams, Joshua  wrote:
>>
>> +1
>>
>> I checked the following:
>> - incubating in name
>> - signatures and hashes are all correct
>> - DISCLAIMER exists
>> - NOTICE looks correct
>> - LICENSE looks correct
>>
>> Josh
>> 
>> From: Steve Lawrence 
>> Sent: Wednesday, July 3, 2019 9:03 AM
>> To: dev@daffodil.apache.org
>> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
>>
>> Hi all,
>>
>> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
>>
>> All distribution packages, including signatures, digests, etc. can be
>> found at:
>>
>> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
>>
>> Staging artifacts can be found at:
>>
>> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
>>
>> This release has been signed with PGP key 36F3494B033AE661,
>> corresponding to slawre...@apache.org, which is included in the KEYS
>> file here:
>>
>> https://www.apache.org/dist/incubator/daffodil/KEYS
>>
>> The release candidate has been tagged in git with v2.4.0-rc1.
>>
>> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
>>
>> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>>
>> For a summary of the changes in this release, see:
>>
>> https://daffodil.apache.org/releases/2.4.0/
>>
>> Please review and vote. The vote will be open for at least 72 hours
>> (Saturday, 6 July 2019, 9am EST).
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and reason why)
>>
>> Thanks,
>> - Steve
> 



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Dave Fisher
+1 (binding)

Signatures and hashes are all correct.
DISCLAIMER is correct
NOTICE and LICENSE look good.
Rat check is good.

Please add a .rat-excludes file for the next release. This will make license 
checking easier.

HTH,
Dave

> On Jul 3, 2019, at 7:50 AM, Adams, Joshua  wrote:
> 
> +1
> 
> I checked the following:
> - incubating in name
> - signatures and hashes are all correct
> - DISCLAIMER exists
> - NOTICE looks correct
> - LICENSE looks correct
> 
> Josh
> 
> From: Steve Lawrence 
> Sent: Wednesday, July 3, 2019 9:03 AM
> To: dev@daffodil.apache.org
> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
> 
> Hi all,
> 
> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
> 
> All distribution packages, including signatures, digests, etc. can be
> found at:
> 
> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
> 
> Staging artifacts can be found at:
> 
> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
> 
> This release has been signed with PGP key 36F3494B033AE661,
> corresponding to slawre...@apache.org, which is included in the KEYS
> file here:
> 
> https://www.apache.org/dist/incubator/daffodil/KEYS
> 
> The release candidate has been tagged in git with v2.4.0-rc1.
> 
> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
> 
> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> 
> For a summary of the changes in this release, see:
> 
> https://daffodil.apache.org/releases/2.4.0/
> 
> Please review and vote. The vote will be open for at least 72 hours
> (Saturday, 6 July 2019, 9am EST).
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
> 
> Thanks,
> - Steve



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Beckerle, Mike
Ah! yes I will correct the schema. That property isn't allowed there, and prior 
releases were just ignoring that.


I also found a typo in a short-form property name on a related schema. So this 
feature is helping find bugs.


From: Steve Lawrence 
Sent: Wednesday, July 3, 2019 12:04:05 PM
To: dev@daffodil.apache.org
Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

According to the DFDL doc, escapeSchemaRef is only valid on dfdl:element
and dfdl:simpleType. Is the schema just incorrect? Sounds to me like
validation found an error in the schema, assuming the DFDL spec is right.

- Steve

On 7/3/19 12:00 PM, Beckerle, Mike wrote:
>
> I have tested existing schemas to be sure we haven't broken anything.
>
>
> Alas, I have an iCalendar schema that works in 2.2.0, and 2.3.0, but fails to 
> compile on 2.4.0 with this diagnostic:
>
>
> [error] Test com.mitre.iCalendar.Test_iCalendar.test_ex02 failed: 
> org.apache.daffodil.tdml.TDMLExceptionImpl: (Implementation: daffodil) 
> SchemaDefinitionError: Schema Definition Error: Error loading schema due to 
> org.xml.sax.SAXParseException; systemId: 
> file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd;
>  lineNumber: 245; columnNumber: 74; cvc-complex-type.3.2.2: Attribute 
> 'dfdl:escapeSchemeRef' is not allowed to appear in element 'xs:sequence'.
> [error] Schema context: 
> file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd
>  Location in 
> file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd,
>  took 0.082 sec
>
>
> So my best guess is something about changes to fix validation of short form 
> properties is refusing to allow this property.
>
>
> I will continue to test other schemas so we can get a list of which remain 
> compatible, and which do not.
>
>
> I'm not going to vote yet. We'll see if there are other flaws with existing 
> schemas first.
>
>
>
> 
> From: Steve Lawrence 
> Sent: Wednesday, July 3, 2019 9:03:45 AM
> To: dev@daffodil.apache.org
> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
>
> Hi all,
>
> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
>
> All distribution packages, including signatures, digests, etc. can be
> found at:
>
> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
>
> Staging artifacts can be found at:
>
> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
>
> This release has been signed with PGP key 36F3494B033AE661,
> corresponding to slawre...@apache.org, which is included in the KEYS
> file here:
>
> https://www.apache.org/dist/incubator/daffodil/KEYS
>
> The release candidate has been tagged in git with v2.4.0-rc1.
>
> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
>
> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> For a summary of the changes in this release, see:
>
> https://daffodil.apache.org/releases/2.4.0/
>
> Please review and vote. The vote will be open for at least 72 hours
> (Saturday, 6 July 2019, 9am EST).
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thanks,
> - Steve
>



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Steve Lawrence
According to the DFDL doc, escapeSchemaRef is only valid on dfdl:element
and dfdl:simpleType. Is the schema just incorrect? Sounds to me like
validation found an error in the schema, assuming the DFDL spec is right.

- Steve

On 7/3/19 12:00 PM, Beckerle, Mike wrote:
> 
> I have tested existing schemas to be sure we haven't broken anything.
> 
> 
> Alas, I have an iCalendar schema that works in 2.2.0, and 2.3.0, but fails to 
> compile on 2.4.0 with this diagnostic:
> 
> 
> [error] Test com.mitre.iCalendar.Test_iCalendar.test_ex02 failed: 
> org.apache.daffodil.tdml.TDMLExceptionImpl: (Implementation: daffodil) 
> SchemaDefinitionError: Schema Definition Error: Error loading schema due to 
> org.xml.sax.SAXParseException; systemId: 
> file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd;
>  lineNumber: 245; columnNumber: 74; cvc-complex-type.3.2.2: Attribute 
> 'dfdl:escapeSchemeRef' is not allowed to appear in element 'xs:sequence'.
> [error] Schema context: 
> file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd
>  Location in 
> file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd,
>  took 0.082 sec
> 
> 
> So my best guess is something about changes to fix validation of short form 
> properties is refusing to allow this property.
> 
> 
> I will continue to test other schemas so we can get a list of which remain 
> compatible, and which do not.
> 
> 
> I'm not going to vote yet. We'll see if there are other flaws with existing 
> schemas first.
> 
> 
> 
> 
> From: Steve Lawrence 
> Sent: Wednesday, July 3, 2019 9:03:45 AM
> To: dev@daffodil.apache.org
> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
> 
> Hi all,
> 
> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
> 
> All distribution packages, including signatures, digests, etc. can be
> found at:
> 
> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
> 
> Staging artifacts can be found at:
> 
> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
> 
> This release has been signed with PGP key 36F3494B033AE661,
> corresponding to slawre...@apache.org, which is included in the KEYS
> file here:
> 
> https://www.apache.org/dist/incubator/daffodil/KEYS
> 
> The release candidate has been tagged in git with v2.4.0-rc1.
> 
> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
> 
> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> 
> For a summary of the changes in this release, see:
> 
> https://daffodil.apache.org/releases/2.4.0/
> 
> Please review and vote. The vote will be open for at least 72 hours
> (Saturday, 6 July 2019, 9am EST).
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
> 
> Thanks,
> - Steve
> 



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Beckerle, Mike

I have tested existing schemas to be sure we haven't broken anything.


Alas, I have an iCalendar schema that works in 2.2.0, and 2.3.0, but fails to 
compile on 2.4.0 with this diagnostic:


[error] Test com.mitre.iCalendar.Test_iCalendar.test_ex02 failed: 
org.apache.daffodil.tdml.TDMLExceptionImpl: (Implementation: daffodil) 
SchemaDefinitionError: Schema Definition Error: Error loading schema due to 
org.xml.sax.SAXParseException; systemId: 
file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd;
 lineNumber: 245; columnNumber: 74; cvc-complex-type.3.2.2: Attribute 
'dfdl:escapeSchemeRef' is not allowed to appear in element 'xs:sequence'.
[error] Schema context: 
file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd
 Location in 
file:/home/mbeckerle/FOUO/fouo-schemas/iCalendar/target/classes/com/mitre/iCalendar/xsd/iCalendar.dfdl.xsd,
 took 0.082 sec


So my best guess is something about changes to fix validation of short form 
properties is refusing to allow this property.


I will continue to test other schemas so we can get a list of which remain 
compatible, and which do not.


I'm not going to vote yet. We'll see if there are other flaws with existing 
schemas first.




From: Steve Lawrence 
Sent: Wednesday, July 3, 2019 9:03:45 AM
To: dev@daffodil.apache.org
Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

Hi all,

I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.

All distribution packages, including signatures, digests, etc. can be
found at:

https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/

Staging artifacts can be found at:

https://repository.apache.org/content/repositories/orgapachedaffodil-1009/

This release has been signed with PGP key 36F3494B033AE661,
corresponding to slawre...@apache.org, which is included in the KEYS
file here:

https://www.apache.org/dist/incubator/daffodil/KEYS

The release candidate has been tagged in git with v2.4.0-rc1.

For reference, here is a list of all closed JIRAs tagged with 2.4.0:

https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC

For a summary of the changes in this release, see:

https://daffodil.apache.org/releases/2.4.0/

Please review and vote. The vote will be open for at least 72 hours
(Saturday, 6 July 2019, 9am EST).

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Thanks,
- Steve


Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Steve Lawrence
Probably this is the link we really want to use:

https://issues.apache.org/jira/projects/DAFFODIL/versions/12344105

Unfortunately, that can only be seen by logged in users, but maybe
that's okay? Anyone can create a JIRA account. Or maybe we just don't
include the link at all? We do link to every bug on the 2.4.0 release page.

On 7/3/19 10:51 AM, Steve Lawrence wrote:
> For me it shows a split where all the issues are listed on the left
> split and the 2174 is on the right. I can't find a way to not show a
> ticket on the right.
> 
> And when I go to your /issues link, it just redirects me to the same
> /browse/* page. Tested on both Chrome and Firefox.
> 
> And I think I've found the problem. It's the difference between "List
> View" and "Detail View", changed by the icon under "Tools" on the right.
> We really want a list view here, but I'm not sure there's a way to force
> that in the URL. Maybe there's some other place in JIRA where we can get
> this information.
> 
> 
> On 7/3/19 10:42 AM, Beckerle, Mike wrote:
>> Strange.
>>
>>
>> Your short link doesn't work for me.
>>
>>
>> It opens up ticket DAFFODIL-2174.
>>
>>
>> After I click the shortened link, what it indirects my browser to is this 
>> longer URL
>>
>> https://issues.apache.org/jira/browse/DAFFODIL-2174?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0
>>
>>
>> Which if you look at it, is a cross between the URL for DAFFODIL-2174, and a 
>> query for 2.4.0 fixVersion for project daffodil.
>>
>>
>> My longer URL doesn't have the incorrect "/browse/DAFFODIL-2174" part. It 
>> has "/issues/" and a slightly different query part.
>>
>>
>> I am using firefox browser.
>>
>>
>>
>> 
>> From: Steve Lawrence 
>> Sent: Wednesday, July 3, 2019 10:23:09 AM
>> To: dev@daffodil.apache.org
>> Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
>>
>> Both links look open up the same thing to me. I wonder if it's getting
>> mangled due to the length? Also, your link looks like it requires a log-in.
>>
>> I've created an apache short url, does this look correct:
>>
>> https://s.apache.org/daffodil-issues-2.4.0
>>
>>
>> On 7/3/19 10:15 AM, Beckerle, Mike wrote:
>>> The link for the list of tickets isn't correct. It opens up one specific 
>>> ticket for me. The correct URL
>>>
>>> is
>>>
>>> https://issues.apache.org/jira/issues/?filter=-1=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>>>
>>>
>>> 
>>> From: Steve Lawrence 
>>> Sent: Wednesday, July 3, 2019 9:03:45 AM
>>> To: dev@daffodil.apache.org
>>> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
>>>
>>> Hi all,
>>>
>>> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
>>>
>>> All distribution packages, including signatures, digests, etc. can be
>>> found at:
>>>
>>> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
>>>
>>> Staging artifacts can be found at:
>>>
>>> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
>>>
>>> This release has been signed with PGP key 36F3494B033AE661,
>>> corresponding to slawre...@apache.org, which is included in the KEYS
>>> file here:
>>>
>>> https://www.apache.org/dist/incubator/daffodil/KEYS
>>>
>>> The release candidate has been tagged in git with v2.4.0-rc1.
>>>
>>> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
>>>
>>> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>>>
>>> For a summary of the changes in this release, see:
>>>
>>> https://daffodil.apache.org/releases/2.4.0/
>>>
>>> Please review and vote. The vote will be open for at least 72 hours
>>> (Saturday, 6 July 2019, 9am EST).
>>>
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove (and reason why)
>>>
>>> Thanks,
>>> - Steve
>>>
>>
>>
> 



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Steve Lawrence
For me it shows a split where all the issues are listed on the left
split and the 2174 is on the right. I can't find a way to not show a
ticket on the right.

And when I go to your /issues link, it just redirects me to the same
/browse/* page. Tested on both Chrome and Firefox.

And I think I've found the problem. It's the difference between "List
View" and "Detail View", changed by the icon under "Tools" on the right.
We really want a list view here, but I'm not sure there's a way to force
that in the URL. Maybe there's some other place in JIRA where we can get
this information.


On 7/3/19 10:42 AM, Beckerle, Mike wrote:
> Strange.
> 
> 
> Your short link doesn't work for me.
> 
> 
> It opens up ticket DAFFODIL-2174.
> 
> 
> After I click the shortened link, what it indirects my browser to is this 
> longer URL
> 
> https://issues.apache.org/jira/browse/DAFFODIL-2174?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0
> 
> 
> Which if you look at it, is a cross between the URL for DAFFODIL-2174, and a 
> query for 2.4.0 fixVersion for project daffodil.
> 
> 
> My longer URL doesn't have the incorrect "/browse/DAFFODIL-2174" part. It has 
> "/issues/" and a slightly different query part.
> 
> 
> I am using firefox browser.
> 
> 
> 
> ____________
> From: Steve Lawrence 
> Sent: Wednesday, July 3, 2019 10:23:09 AM
> To: dev@daffodil.apache.org
> Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
> 
> Both links look open up the same thing to me. I wonder if it's getting
> mangled due to the length? Also, your link looks like it requires a log-in.
> 
> I've created an apache short url, does this look correct:
> 
> https://s.apache.org/daffodil-issues-2.4.0
> 
> 
> On 7/3/19 10:15 AM, Beckerle, Mike wrote:
>> The link for the list of tickets isn't correct. It opens up one specific 
>> ticket for me. The correct URL
>>
>> is
>>
>> https://issues.apache.org/jira/issues/?filter=-1=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>>
>>
>> 
>> From: Steve Lawrence 
>> Sent: Wednesday, July 3, 2019 9:03:45 AM
>> To: dev@daffodil.apache.org
>> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
>>
>> Hi all,
>>
>> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
>>
>> All distribution packages, including signatures, digests, etc. can be
>> found at:
>>
>> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
>>
>> Staging artifacts can be found at:
>>
>> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
>>
>> This release has been signed with PGP key 36F3494B033AE661,
>> corresponding to slawre...@apache.org, which is included in the KEYS
>> file here:
>>
>> https://www.apache.org/dist/incubator/daffodil/KEYS
>>
>> The release candidate has been tagged in git with v2.4.0-rc1.
>>
>> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
>>
>> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>>
>> For a summary of the changes in this release, see:
>>
>> https://daffodil.apache.org/releases/2.4.0/
>>
>> Please review and vote. The vote will be open for at least 72 hours
>> (Saturday, 6 July 2019, 9am EST).
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and reason why)
>>
>> Thanks,
>> - Steve
>>
> 
> 



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Adams, Joshua
+1

I checked the following:
 - incubating in name
 - signatures and hashes are all correct
 - DISCLAIMER exists
 - NOTICE looks correct
 - LICENSE looks correct

Josh

From: Steve Lawrence 
Sent: Wednesday, July 3, 2019 9:03 AM
To: dev@daffodil.apache.org
Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

Hi all,

I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.

All distribution packages, including signatures, digests, etc. can be
found at:

https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/

Staging artifacts can be found at:

https://repository.apache.org/content/repositories/orgapachedaffodil-1009/

This release has been signed with PGP key 36F3494B033AE661,
corresponding to slawre...@apache.org, which is included in the KEYS
file here:

https://www.apache.org/dist/incubator/daffodil/KEYS

The release candidate has been tagged in git with v2.4.0-rc1.

For reference, here is a list of all closed JIRAs tagged with 2.4.0:

https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC

For a summary of the changes in this release, see:

https://daffodil.apache.org/releases/2.4.0/

Please review and vote. The vote will be open for at least 72 hours
(Saturday, 6 July 2019, 9am EST).

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Thanks,
- Steve


Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Beckerle, Mike
Strange.


Your short link doesn't work for me.


It opens up ticket DAFFODIL-2174.


After I click the shortened link, what it indirects my browser to is this 
longer URL

https://issues.apache.org/jira/browse/DAFFODIL-2174?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0


Which if you look at it, is a cross between the URL for DAFFODIL-2174, and a 
query for 2.4.0 fixVersion for project daffodil.


My longer URL doesn't have the incorrect "/browse/DAFFODIL-2174" part. It has 
"/issues/" and a slightly different query part.


I am using firefox browser.




From: Steve Lawrence 
Sent: Wednesday, July 3, 2019 10:23:09 AM
To: dev@daffodil.apache.org
Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

Both links look open up the same thing to me. I wonder if it's getting
mangled due to the length? Also, your link looks like it requires a log-in.

I've created an apache short url, does this look correct:

https://s.apache.org/daffodil-issues-2.4.0


On 7/3/19 10:15 AM, Beckerle, Mike wrote:
> The link for the list of tickets isn't correct. It opens up one specific 
> ticket for me. The correct URL
>
> is
>
> https://issues.apache.org/jira/issues/?filter=-1=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
>
> 
> From: Steve Lawrence 
> Sent: Wednesday, July 3, 2019 9:03:45 AM
> To: dev@daffodil.apache.org
> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
>
> Hi all,
>
> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
>
> All distribution packages, including signatures, digests, etc. can be
> found at:
>
> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
>
> Staging artifacts can be found at:
>
> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
>
> This release has been signed with PGP key 36F3494B033AE661,
> corresponding to slawre...@apache.org, which is included in the KEYS
> file here:
>
> https://www.apache.org/dist/incubator/daffodil/KEYS
>
> The release candidate has been tagged in git with v2.4.0-rc1.
>
> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
>
> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> For a summary of the changes in this release, see:
>
> https://daffodil.apache.org/releases/2.4.0/
>
> Please review and vote. The vote will be open for at least 72 hours
> (Saturday, 6 July 2019, 9am EST).
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thanks,
> - Steve
>



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Steve Lawrence
Sounds good. I've updated the release workflow page to mention the URL
shotening for this long JIRA link, and I'll make sure to using the
s.apache.org link when we bring the vote to the incubator.

- Steve

On 7/3/19 10:24 AM, Adams, Joshua wrote:
> That one looks right to me.
> 
> Josh
> 
> From: Steve Lawrence 
> Sent: Wednesday, July 3, 2019 10:23 AM
> To: dev@daffodil.apache.org
> Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
> 
> Both links look open up the same thing to me. I wonder if it's getting
> mangled due to the length? Also, your link looks like it requires a log-in.
> 
> I've created an apache short url, does this look correct:
> 
> https://s.apache.org/daffodil-issues-2.4.0
> 
> 
> On 7/3/19 10:15 AM, Beckerle, Mike wrote:
>> The link for the list of tickets isn't correct. It opens up one specific 
>> ticket for me. The correct URL
>>
>> is
>>
>> https://issues.apache.org/jira/issues/?filter=-1=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>>
>>
>> 
>> From: Steve Lawrence 
>> Sent: Wednesday, July 3, 2019 9:03:45 AM
>> To: dev@daffodil.apache.org
>> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
>>
>> Hi all,
>>
>> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
>>
>> All distribution packages, including signatures, digests, etc. can be
>> found at:
>>
>> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
>>
>> Staging artifacts can be found at:
>>
>> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
>>
>> This release has been signed with PGP key 36F3494B033AE661,
>> corresponding to slawre...@apache.org, which is included in the KEYS
>> file here:
>>
>> https://www.apache.org/dist/incubator/daffodil/KEYS
>>
>> The release candidate has been tagged in git with v2.4.0-rc1.
>>
>> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
>>
>> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>>
>> For a summary of the changes in this release, see:
>>
>> https://daffodil.apache.org/releases/2.4.0/
>>
>> Please review and vote. The vote will be open for at least 72 hours
>> (Saturday, 6 July 2019, 9am EST).
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and reason why)
>>
>> Thanks,
>> - Steve
>>
> 
> 



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Adams, Joshua
That one looks right to me.

Josh

From: Steve Lawrence 
Sent: Wednesday, July 3, 2019 10:23 AM
To: dev@daffodil.apache.org
Subject: Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

Both links look open up the same thing to me. I wonder if it's getting
mangled due to the length? Also, your link looks like it requires a log-in.

I've created an apache short url, does this look correct:

https://s.apache.org/daffodil-issues-2.4.0


On 7/3/19 10:15 AM, Beckerle, Mike wrote:
> The link for the list of tickets isn't correct. It opens up one specific 
> ticket for me. The correct URL
>
> is
>
> https://issues.apache.org/jira/issues/?filter=-1=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
>
> 
> From: Steve Lawrence 
> Sent: Wednesday, July 3, 2019 9:03:45 AM
> To: dev@daffodil.apache.org
> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
>
> Hi all,
>
> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
>
> All distribution packages, including signatures, digests, etc. can be
> found at:
>
> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
>
> Staging artifacts can be found at:
>
> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
>
> This release has been signed with PGP key 36F3494B033AE661,
> corresponding to slawre...@apache.org, which is included in the KEYS
> file here:
>
> https://www.apache.org/dist/incubator/daffodil/KEYS
>
> The release candidate has been tagged in git with v2.4.0-rc1.
>
> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
>
> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> For a summary of the changes in this release, see:
>
> https://daffodil.apache.org/releases/2.4.0/
>
> Please review and vote. The vote will be open for at least 72 hours
> (Saturday, 6 July 2019, 9am EST).
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thanks,
> - Steve
>



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Steve Lawrence
Both links look open up the same thing to me. I wonder if it's getting
mangled due to the length? Also, your link looks like it requires a log-in.

I've created an apache short url, does this look correct:

https://s.apache.org/daffodil-issues-2.4.0


On 7/3/19 10:15 AM, Beckerle, Mike wrote:
> The link for the list of tickets isn't correct. It opens up one specific 
> ticket for me. The correct URL
> 
> is
> 
> https://issues.apache.org/jira/issues/?filter=-1=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> 
> 
> 
> From: Steve Lawrence 
> Sent: Wednesday, July 3, 2019 9:03:45 AM
> To: dev@daffodil.apache.org
> Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1
> 
> Hi all,
> 
> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
> 
> All distribution packages, including signatures, digests, etc. can be
> found at:
> 
> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
> 
> Staging artifacts can be found at:
> 
> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
> 
> This release has been signed with PGP key 36F3494B033AE661,
> corresponding to slawre...@apache.org, which is included in the KEYS
> file here:
> 
> https://www.apache.org/dist/incubator/daffodil/KEYS
> 
> The release candidate has been tagged in git with v2.4.0-rc1.
> 
> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
> 
> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> 
> For a summary of the changes in this release, see:
> 
> https://daffodil.apache.org/releases/2.4.0/
> 
> Please review and vote. The vote will be open for at least 72 hours
> (Saturday, 6 July 2019, 9am EST).
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
> 
> Thanks,
> - Steve
> 



Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Beckerle, Mike
The link for the list of tickets isn't correct. It opens up one specific ticket 
for me. The correct URL

is

https://issues.apache.org/jira/issues/?filter=-1=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC



From: Steve Lawrence 
Sent: Wednesday, July 3, 2019 9:03:45 AM
To: dev@daffodil.apache.org
Subject: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

Hi all,

I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.

All distribution packages, including signatures, digests, etc. can be
found at:

https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/

Staging artifacts can be found at:

https://repository.apache.org/content/repositories/orgapachedaffodil-1009/

This release has been signed with PGP key 36F3494B033AE661,
corresponding to slawre...@apache.org, which is included in the KEYS
file here:

https://www.apache.org/dist/incubator/daffodil/KEYS

The release candidate has been tagged in git with v2.4.0-rc1.

For reference, here is a list of all closed JIRAs tagged with 2.4.0:

https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC

For a summary of the changes in this release, see:

https://daffodil.apache.org/releases/2.4.0/

Please review and vote. The vote will be open for at least 72 hours
(Saturday, 6 July 2019, 9am EST).

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Thanks,
- Steve


Re: [VOTE] Release Apache Daffodil (incubating) 2.4.0-rc1

2019-07-03 Thread Steve Lawrence
I forgot to mention, but something we haven't done well in the past that
we should start doing is state what you checked that lead to your vote.
As an example, see this recent vote on the incubator list:

https://lists.apache.org/thread.html/1e7cb02e92ecbe4d62e0a0c18b21ba32fba52f3bfee65b70eb15012b@%3Cgeneral.incubator.apache.org%3E

- Steve

On 7/3/19 9:03 AM, Steve Lawrence wrote:
> Hi all,
> 
> I'd like to call a vote to release Apache Daffodil (incubating) 2.4.0-rc1.
> 
> All distribution packages, including signatures, digests, etc. can be
> found at:
> 
> https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.4.0-rc1/
> 
> Staging artifacts can be found at:
> 
> https://repository.apache.org/content/repositories/orgapachedaffodil-1009/
> 
> This release has been signed with PGP key 36F3494B033AE661,
> corresponding to slawre...@apache.org, which is included in the KEYS
> file here:
> 
> https://www.apache.org/dist/incubator/daffodil/KEYS
> 
> The release candidate has been tagged in git with v2.4.0-rc1.
> 
> For reference, here is a list of all closed JIRAs tagged with 2.4.0:
> 
> https://issues.apache.org/jira/browse/DAFFODIL-1477?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.4.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> 
> For a summary of the changes in this release, see:
> 
> https://daffodil.apache.org/releases/2.4.0/
> 
> Please review and vote. The vote will be open for at least 72 hours
> (Saturday, 6 July 2019, 9am EST).
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
> 
> Thanks,
> - Steve
>