[jira] [Commented] (DELTASPIKE-856) Eclipse deployment to container add remove view shows deltaspike-jsf-module-impl-ee6-1.2.1 as if it was an app module - in weblogic we get a double jar file
[ https://issues.apache.org/jira/browse/DELTASPIKE-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362428#comment-14362428 ] Nuno G. de M commented on DELTASPIKE-856: - Quite bizarre, I have just finished downloading the latest release of eclipse from the official site. I've installed OEPE from the market place and even had to instlal JRE 8 to run the latest version of this plugin. I've gone through the same motions, and here is the result: https://drive.google.com/file/d/0B_dEiNBGUsxqVUY5bmVYUDFUaTQ/view?usp=sharing I still see this jar file as if it were an application module. You can confirm in the docx that I've uploaded that I am indeed using the latest version of eclipse. Eclipse deployment to container add remove view shows deltaspike-jsf-module-impl-ee6-1.2.1 as if it was an app module - in weblogic we get a double jar file Key: DELTASPIKE-856 URL: https://issues.apache.org/jira/browse/DELTASPIKE-856 Project: DeltaSpike Issue Type: Bug Components: JSF-Module Affects Versions: 1.2.1 Environment: Windows 7 , Eclipse Version: Luna (4.4) Build id: I20140606-1215, WTP plugin Version: 1.2.100.v201405081709-797LBiCcNBHQFTGaGVbu3KEF Build id: 20131017041352, Oracle enterprise Pack for Ecliplse plugin: Build id: 20131017041352 Reporter: Nuno G. de M Assignee: Rafael Benevides Attachments: Screenshot 2015-03-13 18.05.21.png There is something special about the deltaspike-jsf-module-impl-ee6-1.2.1.jar . This project dependency alone, unlike every other project dependency, it is displayed itself by eclipse Add Remove view to an application server as if it were a module itself of the war application to be deployed. When a user, for example, configures weblogic 12.1.2 server to take in deployments as exploded war files, what ends up happening after the deployment goes through is that we see within Weblogic Domain AdminServer temp mydeployment war Web-inf/lib we see the jar dependency twice. First we see the correct and expected dependency: deltaspike-jsf-module-impl-ee6-1.2.1.jar But then we have a second file in the lib folder called: deltaspike-jsf-module-impl-ee6-1.2.1.jar.jar This appears to be releated to the Add Remove view of eclipse, since normally under the project war file itself we only see other open project modules. I am pasting in this post an url to a google driver sample application that you can use to simulate the scenario. The zip file will contain both a sample application that I have once before submitted to you already (regarding the view access scoped beans) and document file illustrating the issue in my IDE. To simulate the issue simply: (a) create a domain (b) do mvn eclipse:eclipse and import the project (c) Configure your weblogic domain to accept exploded war deployment (d) click on add and remove on the domain you want to deploy to and see that the JEE6 impl appears as a module. (e) deploy, and look at what happens within the weblogic deployment folder URL: https://drive.google.com/file/d/0B_dEiNBGUsxqOGZRUjBJQU85WXc/view?usp=sharing It is not yet clear if this phenomena may be creating problems for us when we use eclipse to run the deployment. In the sample application we have no issues. Thank you for your support, My kindest regards. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [2/2] deltaspike git commit: DELTASPIKE-851 move proxy-handling to ds-core
do you mean the jar size? the difference is just ~130kb when we shade asm or not 2015-03-15 21:40 GMT+01:00 Romain Manni-Bucau rmannibu...@gmail.com: But owb has no link with ds need imo. Ds is a lib so need to care about user deps where owb doesnt. Not having an own module would be another reason to not use ds - which is already the case from my experience for its size but now it would also be to not be smart enough :( Le 15 mars 2015 21:20, Gerhard Petracek gerhard.petra...@gmail.com a écrit : @romain: +0 for an own module -0.5 for an additional indirection (we also don't have/need it at owb) regards, gerhard 2015-03-15 21:11 GMT+01:00 Thomas Andraschko andraschko.tho...@gmail.com : +0 for an extra module before i implemented the asm proxy for the partial bean module, i tried it many hours to understand and implement it with commons proxy as it was not possible out of the box, i switched to plain ASM If someone would like to evolve commons proxy and use it in DS - +0 2015-03-15 20:53 GMT+01:00 Romain Manni-Bucau rmannibu...@gmail.com: Hmm, shouldn't we provide this as another module? I'm not super happy to have asm shade in core. BTW can't we just use [proxy2]? we can still make the code evolving if needed. Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn https://www.linkedin.com/in/rmannibucau | Tomitriber http://www.tomitribe.com -- Forwarded message -- From: tandrasc...@apache.org Date: 2015-03-15 20:50 GMT+01:00 Subject: [2/2] deltaspike git commit: DELTASPIKE-851 move proxy-handling to ds-core To: comm...@deltaspike.apache.org DELTASPIKE-851 move proxy-handling to ds-core Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo Commit: http://git-wip-us.apache.org/repos/asf/deltaspike/commit/fcf4d77d Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/fcf4d77d Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/fcf4d77d Branch: refs/heads/master Commit: fcf4d77d692971a6a93731e64d044f6cf1757d6c Parents: d3a21c0 Author: Thomas Andraschko tandrasc...@apache.org Authored: Sun Mar 15 20:50:24 2015 +0100 Committer: Thomas Andraschko tandrasc...@apache.org Committed: Sun Mar 15 20:50:24 2015 +0100 -- deltaspike/core/api/pom.xml | 57 +++ .../AbstractManualInvocationHandler.java| 104 + .../invocation/ManualInvocationContext.java | 187 ...nualInvocationThrowableWrapperException.java | 27 ++ .../core/util/proxy/AsmProxyClassGenerator.java | 436 +++ .../core/util/proxy/DeltaSpikeProxy.java| 28 ++ .../DeltaSpikeProxyContextualLifecycle.java | 144 ++ .../core/util/proxy/DeltaSpikeProxyFactory.java | 274 .../DelegateManualInvocationHandler.java| 43 ++ .../InterceptManualInvocationHandler.java | 51 +++ deltaspike/modules/jsf/impl/pom.xml | 6 - .../InjectionAwareApplicationWrapper.java | 6 +- .../proxy/ConverterAndValidatorLifecycle.java | 132 -- .../ConverterAndValidatorProxyExtension.java| 19 +- .../ConverterAndValidatorProxyFactory.java | 78 .../proxy/ConverterInvocationHandler.java | 13 +- .../proxy/DefaultPartialStateHolder.java| 3 + .../proxy/DelegatingMethodHandler.java | 58 --- .../injection/proxy/MethodHandlerProxy.java | 42 -- .../jsf/impl/injection/proxy/ProxyMarker.java | 23 - .../proxy/ValidatorInvocationHandler.java | 12 +- .../test/jsf/impl/util/ArchiveUtils.java| 1 - deltaspike/modules/partial-bean/impl/pom.xml| 56 --- .../impl/PartialBeanBindingExtension.java | 16 +- .../partialbean/impl/PartialBeanLifecycle.java | 142 -- .../impl/PartialBeanProxyFactory.java | 62 +++ .../AbstractManualInvocationHandler.java| 104 - .../interception/ManualInvocationContext.java | 187 ...nualInvocationThrowableWrapperException.java | 27 -- .../impl/proxy/AsmProxyClassGenerator.java | 423 -- .../proxy/CallSuperManualInvocationHandler.java | 50 --- .../impl/proxy/PartialBeanProxy.java| 28 -- .../impl/proxy/PartialBeanProxyFactory.java | 263 --- .../proxy/RedirectManualInvocationHandler.java | 42 -- .../core/api/partialbean/util/ArchiveUtils.java | 7 - 35 files changed, 1510 insertions(+), 1641 deletions(-) --
Re: [2/2] deltaspike git commit: DELTASPIKE-851 move proxy-handling to ds-core
javassist is about 600kb and the user needs to manage it 2015-03-15 21:48 GMT+01:00 Thomas Andraschko andraschko.tho...@gmail.com: do you mean the jar size? the difference is just ~130kb when we shade asm or not 2015-03-15 21:40 GMT+01:00 Romain Manni-Bucau rmannibu...@gmail.com: But owb has no link with ds need imo. Ds is a lib so need to care about user deps where owb doesnt. Not having an own module would be another reason to not use ds - which is already the case from my experience for its size but now it would also be to not be smart enough :( Le 15 mars 2015 21:20, Gerhard Petracek gerhard.petra...@gmail.com a écrit : @romain: +0 for an own module -0.5 for an additional indirection (we also don't have/need it at owb) regards, gerhard 2015-03-15 21:11 GMT+01:00 Thomas Andraschko andraschko.tho...@gmail.com : +0 for an extra module before i implemented the asm proxy for the partial bean module, i tried it many hours to understand and implement it with commons proxy as it was not possible out of the box, i switched to plain ASM If someone would like to evolve commons proxy and use it in DS - +0 2015-03-15 20:53 GMT+01:00 Romain Manni-Bucau rmannibu...@gmail.com : Hmm, shouldn't we provide this as another module? I'm not super happy to have asm shade in core. BTW can't we just use [proxy2]? we can still make the code evolving if needed. Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn https://www.linkedin.com/in/rmannibucau | Tomitriber http://www.tomitribe.com -- Forwarded message -- From: tandrasc...@apache.org Date: 2015-03-15 20:50 GMT+01:00 Subject: [2/2] deltaspike git commit: DELTASPIKE-851 move proxy-handling to ds-core To: comm...@deltaspike.apache.org DELTASPIKE-851 move proxy-handling to ds-core Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo Commit: http://git-wip-us.apache.org/repos/asf/deltaspike/commit/fcf4d77d Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/fcf4d77d Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/fcf4d77d Branch: refs/heads/master Commit: fcf4d77d692971a6a93731e64d044f6cf1757d6c Parents: d3a21c0 Author: Thomas Andraschko tandrasc...@apache.org Authored: Sun Mar 15 20:50:24 2015 +0100 Committer: Thomas Andraschko tandrasc...@apache.org Committed: Sun Mar 15 20:50:24 2015 +0100 -- deltaspike/core/api/pom.xml | 57 +++ .../AbstractManualInvocationHandler.java| 104 + .../invocation/ManualInvocationContext.java | 187 ...nualInvocationThrowableWrapperException.java | 27 ++ .../core/util/proxy/AsmProxyClassGenerator.java | 436 +++ .../core/util/proxy/DeltaSpikeProxy.java| 28 ++ .../DeltaSpikeProxyContextualLifecycle.java | 144 ++ .../core/util/proxy/DeltaSpikeProxyFactory.java | 274 .../DelegateManualInvocationHandler.java| 43 ++ .../InterceptManualInvocationHandler.java | 51 +++ deltaspike/modules/jsf/impl/pom.xml | 6 - .../InjectionAwareApplicationWrapper.java | 6 +- .../proxy/ConverterAndValidatorLifecycle.java | 132 -- .../ConverterAndValidatorProxyExtension.java| 19 +- .../ConverterAndValidatorProxyFactory.java | 78 .../proxy/ConverterInvocationHandler.java | 13 +- .../proxy/DefaultPartialStateHolder.java| 3 + .../proxy/DelegatingMethodHandler.java | 58 --- .../injection/proxy/MethodHandlerProxy.java | 42 -- .../jsf/impl/injection/proxy/ProxyMarker.java | 23 - .../proxy/ValidatorInvocationHandler.java | 12 +- .../test/jsf/impl/util/ArchiveUtils.java| 1 - deltaspike/modules/partial-bean/impl/pom.xml| 56 --- .../impl/PartialBeanBindingExtension.java | 16 +- .../partialbean/impl/PartialBeanLifecycle.java | 142 -- .../impl/PartialBeanProxyFactory.java | 62 +++ .../AbstractManualInvocationHandler.java| 104 - .../interception/ManualInvocationContext.java | 187 ...nualInvocationThrowableWrapperException.java | 27 -- .../impl/proxy/AsmProxyClassGenerator.java | 423 -- .../proxy/CallSuperManualInvocationHandler.java | 50 --- .../impl/proxy/PartialBeanProxy.java| 28 -- .../impl/proxy/PartialBeanProxyFactory.java | 263 --- .../proxy/RedirectManualInvocationHandler.java | 42 -- .../core/api/partialbean/util/ArchiveUtils.java | 7 - 35
[jira] [Resolved] (DELTASPIKE-851) move proxy-handling to ds-core
[ https://issues.apache.org/jira/browse/DELTASPIKE-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved DELTASPIKE-851. -- Resolution: Fixed move proxy-handling to ds-core -- Key: DELTASPIKE-851 URL: https://issues.apache.org/jira/browse/DELTASPIKE-851 Project: DeltaSpike Issue Type: Improvement Components: Core, JSF-Module, PartialBean Affects Versions: 1.3.0 Reporter: Gerhard Petracek Assignee: Thomas Andraschko Fix For: 1.3.1 with that we can get rid of the optional dependency to javassist in the jsf-module... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [2/2] deltaspike git commit: DELTASPIKE-851 move proxy-handling to ds-core
+0 for an extra module before i implemented the asm proxy for the partial bean module, i tried it many hours to understand and implement it with commons proxy as it was not possible out of the box, i switched to plain ASM If someone would like to evolve commons proxy and use it in DS - +0 2015-03-15 20:53 GMT+01:00 Romain Manni-Bucau rmannibu...@gmail.com: Hmm, shouldn't we provide this as another module? I'm not super happy to have asm shade in core. BTW can't we just use [proxy2]? we can still make the code evolving if needed. Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn https://www.linkedin.com/in/rmannibucau | Tomitriber http://www.tomitribe.com -- Forwarded message -- From: tandrasc...@apache.org Date: 2015-03-15 20:50 GMT+01:00 Subject: [2/2] deltaspike git commit: DELTASPIKE-851 move proxy-handling to ds-core To: comm...@deltaspike.apache.org DELTASPIKE-851 move proxy-handling to ds-core Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo Commit: http://git-wip-us.apache.org/repos/asf/deltaspike/commit/fcf4d77d Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/fcf4d77d Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/fcf4d77d Branch: refs/heads/master Commit: fcf4d77d692971a6a93731e64d044f6cf1757d6c Parents: d3a21c0 Author: Thomas Andraschko tandrasc...@apache.org Authored: Sun Mar 15 20:50:24 2015 +0100 Committer: Thomas Andraschko tandrasc...@apache.org Committed: Sun Mar 15 20:50:24 2015 +0100 -- deltaspike/core/api/pom.xml | 57 +++ .../AbstractManualInvocationHandler.java| 104 + .../invocation/ManualInvocationContext.java | 187 ...nualInvocationThrowableWrapperException.java | 27 ++ .../core/util/proxy/AsmProxyClassGenerator.java | 436 +++ .../core/util/proxy/DeltaSpikeProxy.java| 28 ++ .../DeltaSpikeProxyContextualLifecycle.java | 144 ++ .../core/util/proxy/DeltaSpikeProxyFactory.java | 274 .../DelegateManualInvocationHandler.java| 43 ++ .../InterceptManualInvocationHandler.java | 51 +++ deltaspike/modules/jsf/impl/pom.xml | 6 - .../InjectionAwareApplicationWrapper.java | 6 +- .../proxy/ConverterAndValidatorLifecycle.java | 132 -- .../ConverterAndValidatorProxyExtension.java| 19 +- .../ConverterAndValidatorProxyFactory.java | 78 .../proxy/ConverterInvocationHandler.java | 13 +- .../proxy/DefaultPartialStateHolder.java| 3 + .../proxy/DelegatingMethodHandler.java | 58 --- .../injection/proxy/MethodHandlerProxy.java | 42 -- .../jsf/impl/injection/proxy/ProxyMarker.java | 23 - .../proxy/ValidatorInvocationHandler.java | 12 +- .../test/jsf/impl/util/ArchiveUtils.java| 1 - deltaspike/modules/partial-bean/impl/pom.xml| 56 --- .../impl/PartialBeanBindingExtension.java | 16 +- .../partialbean/impl/PartialBeanLifecycle.java | 142 -- .../impl/PartialBeanProxyFactory.java | 62 +++ .../AbstractManualInvocationHandler.java| 104 - .../interception/ManualInvocationContext.java | 187 ...nualInvocationThrowableWrapperException.java | 27 -- .../impl/proxy/AsmProxyClassGenerator.java | 423 -- .../proxy/CallSuperManualInvocationHandler.java | 50 --- .../impl/proxy/PartialBeanProxy.java| 28 -- .../impl/proxy/PartialBeanProxyFactory.java | 263 --- .../proxy/RedirectManualInvocationHandler.java | 42 -- .../core/api/partialbean/util/ArchiveUtils.java | 7 - 35 files changed, 1510 insertions(+), 1641 deletions(-) -- http://git-wip-us.apache.org/repos/asf/deltaspike/blob/fcf4d77d/deltaspike/core/api/pom.xml -- diff --git a/deltaspike/core/api/pom.xml b/deltaspike/core/api/pom.xml index c5793f4..94b489d 100644 --- a/deltaspike/core/api/pom.xml +++ b/deltaspike/core/api/pom.xml @@ -33,6 +33,42 @@ nameApache DeltaSpike Core-API/name +build +plugins +plugin +groupIdorg.apache.maven.plugins/groupId +artifactIdmaven-shade-plugin/artifactId +version2.3/version +configuration +shadedArtifactAttachedfalse/shadedArtifactAttached + createDependencyReducedPomfalse/createDependencyReducedPom + promoteTransitiveDependenciestrue/promoteTransitiveDependencies +relocations +relocation +patternorg.objectweb.asm/pattern +
Re: [2/2] deltaspike git commit: DELTASPIKE-851 move proxy-handling to ds-core
But owb has no link with ds need imo. Ds is a lib so need to care about user deps where owb doesnt. Not having an own module would be another reason to not use ds - which is already the case from my experience for its size but now it would also be to not be smart enough :( Le 15 mars 2015 21:20, Gerhard Petracek gerhard.petra...@gmail.com a écrit : @romain: +0 for an own module -0.5 for an additional indirection (we also don't have/need it at owb) regards, gerhard 2015-03-15 21:11 GMT+01:00 Thomas Andraschko andraschko.tho...@gmail.com : +0 for an extra module before i implemented the asm proxy for the partial bean module, i tried it many hours to understand and implement it with commons proxy as it was not possible out of the box, i switched to plain ASM If someone would like to evolve commons proxy and use it in DS - +0 2015-03-15 20:53 GMT+01:00 Romain Manni-Bucau rmannibu...@gmail.com: Hmm, shouldn't we provide this as another module? I'm not super happy to have asm shade in core. BTW can't we just use [proxy2]? we can still make the code evolving if needed. Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn https://www.linkedin.com/in/rmannibucau | Tomitriber http://www.tomitribe.com -- Forwarded message -- From: tandrasc...@apache.org Date: 2015-03-15 20:50 GMT+01:00 Subject: [2/2] deltaspike git commit: DELTASPIKE-851 move proxy-handling to ds-core To: comm...@deltaspike.apache.org DELTASPIKE-851 move proxy-handling to ds-core Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo Commit: http://git-wip-us.apache.org/repos/asf/deltaspike/commit/fcf4d77d Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/fcf4d77d Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/fcf4d77d Branch: refs/heads/master Commit: fcf4d77d692971a6a93731e64d044f6cf1757d6c Parents: d3a21c0 Author: Thomas Andraschko tandrasc...@apache.org Authored: Sun Mar 15 20:50:24 2015 +0100 Committer: Thomas Andraschko tandrasc...@apache.org Committed: Sun Mar 15 20:50:24 2015 +0100 -- deltaspike/core/api/pom.xml | 57 +++ .../AbstractManualInvocationHandler.java| 104 + .../invocation/ManualInvocationContext.java | 187 ...nualInvocationThrowableWrapperException.java | 27 ++ .../core/util/proxy/AsmProxyClassGenerator.java | 436 +++ .../core/util/proxy/DeltaSpikeProxy.java| 28 ++ .../DeltaSpikeProxyContextualLifecycle.java | 144 ++ .../core/util/proxy/DeltaSpikeProxyFactory.java | 274 .../DelegateManualInvocationHandler.java| 43 ++ .../InterceptManualInvocationHandler.java | 51 +++ deltaspike/modules/jsf/impl/pom.xml | 6 - .../InjectionAwareApplicationWrapper.java | 6 +- .../proxy/ConverterAndValidatorLifecycle.java | 132 -- .../ConverterAndValidatorProxyExtension.java| 19 +- .../ConverterAndValidatorProxyFactory.java | 78 .../proxy/ConverterInvocationHandler.java | 13 +- .../proxy/DefaultPartialStateHolder.java| 3 + .../proxy/DelegatingMethodHandler.java | 58 --- .../injection/proxy/MethodHandlerProxy.java | 42 -- .../jsf/impl/injection/proxy/ProxyMarker.java | 23 - .../proxy/ValidatorInvocationHandler.java | 12 +- .../test/jsf/impl/util/ArchiveUtils.java| 1 - deltaspike/modules/partial-bean/impl/pom.xml| 56 --- .../impl/PartialBeanBindingExtension.java | 16 +- .../partialbean/impl/PartialBeanLifecycle.java | 142 -- .../impl/PartialBeanProxyFactory.java | 62 +++ .../AbstractManualInvocationHandler.java| 104 - .../interception/ManualInvocationContext.java | 187 ...nualInvocationThrowableWrapperException.java | 27 -- .../impl/proxy/AsmProxyClassGenerator.java | 423 -- .../proxy/CallSuperManualInvocationHandler.java | 50 --- .../impl/proxy/PartialBeanProxy.java| 28 -- .../impl/proxy/PartialBeanProxyFactory.java | 263 --- .../proxy/RedirectManualInvocationHandler.java | 42 -- .../core/api/partialbean/util/ArchiveUtils.java | 7 - 35 files changed, 1510 insertions(+), 1641 deletions(-) -- http://git-wip-us.apache.org/repos/asf/deltaspike/blob/fcf4d77d/deltaspike/core/api/pom.xml -- diff --git a/deltaspike/core/api/pom.xml b/deltaspike/core/api/pom.xml index c5793f4..94b489d
Re: multithreaded repository issues
Hello, I have not really noticed any perf issues with deltaspike data but then again I did not measure it either. We use it a lot. Would be great to learn more about it for sure. I always assumed the method name query syntax and the other static stuff would be cached etc so I don't really get why it would be any major penalty all though I understand each abstraction will have some kind of impact... On 15 March 2015 at 21:40, hwaastad he...@waastad.org wrote: Hi guys, and thanks for answering. I'll try to get something out on github tomorrow. Br hw -- View this message in context: http://apache-deltaspike-incubator-discussions.2316169.n4.nabble.com/multithreaded-repository-issues-tp4660132p4660145.html Sent from the Apache DeltaSpike Incubator Discussions mailing list archive at Nabble.com.
