Re: CriteriaSupport API

[Thomas Hug]

Wow, thnx for churning out those fixes! :) (and also to Rafael for
reviewing!) Will take some time for me to get to it but will try to do this
asap.
Cheers,
Thomas

On Thu, May 14, 2015 at 10:17 PM, Daniel Cunha daniels...@gmail.com wrote:

 Hi Thomas,

 I've working in some issues and I would like to send my result on work in
 DS.
 I have attached patch for:
 https://issues.apache.org/jira/browse/DELTASPIKE-603
 https://issues.apache.org/jira/browse/DELTASPIKE-894
 https://issues.apache.org/jira/browse/DELTASPIKE-701
 https://issues.apache.org/jira/browse/DELTASPIKE-902

 I had an help of the Rafael Benevides (rbenevides), he reviewed my patchs
 in (DELTASPIKE-894,  DELTASPIKE-701).
 Let me know if the patchs is good or need improvement. I would like to help
 more :)

 I'll start work on DELTASPIKE-901.
 See you. Thank you.

 On Wed, May 13, 2015 at 1:10 PM, Daniel Cunha daniels...@gmail.com
 wrote:

  Hi Thomas,
 
  I'm looking to DELTASPIKE-701 and DELTASPIKE-603
  I'm preparing to start with DELTASPIKE-603. Do you have something for it
  or did something?
  I would like to fix it, if you don't have time to do. :)
 
  On Wed, May 13, 2015 at 1:00 PM, Thomas Hug thomas@gmail.com
 wrote:
 
  Hi Daniel
  I definitely don't have as much time for DS as I'd like to have (right
 now
  close to none ;) so any help is welcome :). Let me know if you have any
  specific issue in mind and we can check what's needed.
  Cheers,
  Thomas
 
  On Wed, May 13, 2015 at 12:13 AM, Daniel Cunha daniels...@gmail.com
  wrote:
 
   Hi Thomas,
  
   I can to see that we have some issues opened and not fixed if you
 want I
   can try help you with this tasks.
   Let me know if you need help to fix another issues in data-module. :)
  
   On Mon, May 11, 2015 at 4:55 AM, Thomas Hug thomas@gmail.com
  wrote:
  
Hi Daniel
   
Thanks for the patch! I should have some bandwidth the next week to
 do
   some
DS coding and take care about it.
There's indeed room for improvement for the criteria API. I was not
   really
sure how useful people find it and started with a simplified
 version,
  but
if it gets more adoption it's definitely worth filling the gaps.
  Feedback
and PRs always welcome :)
   
Cheers,
Thomas
   
On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha daniels...@gmail.com
 
wrote:
   
 Hi folks,

 I started to change something in data-module, I don't know if we
  have
time
 to do it, but, let me know if DELTASPIKE-894 could be apply in
 next
 release.

 We don't support all methods. Do we want support for all methods?
 I can to see that some methods like 'isTrue', 'isFalse', etc.. of
  the
 Criteria not is supported by DS data-module.

 --
 Best regard,
 Daniel Cunha (soro)

   
  
  
  
   --
   Best regard,
   Daniel Cunha (soro)
  
 
 
 
 
  --
  Best regard,
  Daniel Cunha (soro)
 



 --
 Best regard,
 Daniel Cunha (soro)

[jira] [Commented] (DELTASPIKE-901) org.apache.deltaspike.data.impl.builder.postprocessor.CountQueryPostProcessor doesn't respect order by

[Daniel Cunha (soro) (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546225#comment-14546225
 ] 

Daniel Cunha (soro) commented on DELTASPIKE-901:


Hi [~romain.manni-bucau],

I tested here on snapshot version and it seem work fine.
https://github.com/danielsoro/deltaspike/commit/6f9a03155ecc7ff387b8613ab487f003bc710ea8

I'll put this patch to add this test in data module if you validate as ok.
See you. :)

 org.apache.deltaspike.data.impl.builder.postprocessor.CountQueryPostProcessor 
 doesn't respect order by
 --

 Key: DELTASPIKE-901
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-901
 Project: DeltaSpike
  Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Romain Manni-Bucau

 using select p from MyEntity p order by p.someString
 and
 {code}
 @Query(named = MyEntity.findAll)
 QueryResultMyEntity all(@FirstResult int start, @MaxResults int 
 pageSize);
 {code}
 I get 
 {code}
 org.apache.openjpa.lib.jdbc.ReportingSQLException: expression not in 
 aggregate or GROUP BY columns: T0.PROPERTY_KEY {SELECT 
 COUNT(t0.property_key), t0.property_key FROM properties t0} [code=-5574, 
 state=42574]
 {code}
 the count post processor doesn't handle the order by correctly.
 Wonder if we should add order by parameters in the select clause or just 
 ignore it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)