[jira] [Resolved] (DELTASPIKE-1035) Make DS PersistenceUnit public and also parse properties

2015-12-04 Thread Thomas Andraschko (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Andraschko resolved DELTASPIKE-1035.
---
Resolution: Fixed
  Assignee: Thomas Andraschko

> Make DS PersistenceUnit public and also parse properties
> 
>
> Key: DELTASPIKE-1035
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1035
> Project: DeltaSpike
>  Issue Type: New Feature
>  Components: Data-Module
>Affects Versions: 1.5.1
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
> Fix For: 1.5.2
>
> Attachments: DS.patch
>
>
> Currently not all JPA implementations (e.g. EclipseLink) provides the PU 
> properties configured via persistene.xml via 
> EntityManagerFactory#getProperties.
> Also there is no other way to access these properties.
> I need to change the database path for my application to the webroot, if 
> HSQLDB is configured via persistence.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (DELTASPIKE-1037) add support for constructor taking a single String parameter or fromString static method for @ConfigProperty

2015-12-04 Thread Romain Manni-Bucau (JIRA) 
Romain Manni-Bucau created DELTASPIKE-1037:
--

 Summary: add support for constructor taking a single String 
parameter or fromString static method for @ConfigProperty
 Key: DELTASPIKE-1037
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1037
 Project: DeltaSpike
  Issue Type: New Feature
Affects Versions: 1.5.1
Reporter: Romain Manni-Bucau
Assignee: Romain Manni-Bucau
 Fix For: 1.5.2






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (DELTASPIKE-1037) add support for constructor taking a single String parameter or fromString static method for @ConfigProperty

2015-12-04 Thread Romain Manni-Bucau (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau updated DELTASPIKE-1037:
---
Description: Support injection of unknown types if they take a String as 
parameter or have a static fromString(String) method

> add support for constructor taking a single String parameter or fromString 
> static method for @ConfigProperty
> 
>
> Key: DELTASPIKE-1037
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1037
> Project: DeltaSpike
>  Issue Type: New Feature
>Affects Versions: 1.5.1
>Reporter: Romain Manni-Bucau
>Assignee: Romain Manni-Bucau
> Fix For: 1.5.2
>
> Attachments: DELTASPIKE-generic-config.patch
>
>
> Support injection of unknown types if they take a String as parameter or have 
> a static fromString(String) method



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (DELTASPIKE-1037) add support for constructor taking a single String parameter or fromString static method for @ConfigProperty

2015-12-04 Thread Romain Manni-Bucau (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau updated DELTASPIKE-1037:
---
Attachment: DELTASPIKE-generic-config.patch

Attaching a patch with the proposal (inspired from Sabot)

I wonder if we can remove all the producers we have in the default config 
producer class or if we consider them as part of the API/userland (the patch 
does this assumption)

> add support for constructor taking a single String parameter or fromString 
> static method for @ConfigProperty
> 
>
> Key: DELTASPIKE-1037
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1037
> Project: DeltaSpike
>  Issue Type: New Feature
>Affects Versions: 1.5.1
>Reporter: Romain Manni-Bucau
>Assignee: Romain Manni-Bucau
> Fix For: 1.5.2
>
> Attachments: DELTASPIKE-generic-config.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1035) Make DS PersistenceUnit public and also parse properties

2015-12-04 Thread John D. Ament (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041515#comment-15041515
 ] 

John D. Ament commented on DELTASPIKE-1035:
---

Why not back the persistence units with a map keyed on name to make traversal 
easier?

> Make DS PersistenceUnit public and also parse properties
> 
>
> Key: DELTASPIKE-1035
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1035
> Project: DeltaSpike
>  Issue Type: New Feature
>  Components: Data-Module
>Affects Versions: 1.5.1
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
> Fix For: 1.5.2
>
> Attachments: DS.patch
>
>
> Currently not all JPA implementations (e.g. EclipseLink) provides the PU 
> properties configured via persistene.xml via 
> EntityManagerFactory#getProperties.
> Also there is no other way to access these properties.
> I need to change the database path for my application to the webroot, if 
> HSQLDB is configured via persistence.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1035) Make DS PersistenceUnit public and also parse properties

2015-12-04 Thread Thomas Andraschko (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041521#comment-15041521
 ] 

Thomas Andraschko commented on DELTASPIKE-1035:
---

We can do it later - currently it's not used by DS.
I will start a dicussion after the release if we could e.g. move it to a API 
package.

> Make DS PersistenceUnit public and also parse properties
> 
>
> Key: DELTASPIKE-1035
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1035
> Project: DeltaSpike
>  Issue Type: New Feature
>  Components: Data-Module
>Affects Versions: 1.5.1
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
> Fix For: 1.5.2
>
> Attachments: DS.patch
>
>
> Currently not all JPA implementations (e.g. EclipseLink) provides the PU 
> properties configured via persistene.xml via 
> EntityManagerFactory#getProperties.
> Also there is no other way to access these properties.
> I need to change the database path for my application to the webroot, if 
> HSQLDB is configured via persistence.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

@ConfigProperty and constructors

2015-12-04 Thread Romain Manni-Bucau 
Hi guys,

opened https://issues.apache.org/jira/browse/DELTASPIKE-1037

WDYT about this feature?

Side note: wondered if we should support List/Map with the same coercing
logic, these types are quite common IMHO.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Github  |
LinkedIn  | Tomitriber

[jira] [Created] (DELTASPIKE-1038) prepare v1.5.2

2015-12-04 Thread Gerhard Petracek (JIRA) 
Gerhard Petracek created DELTASPIKE-1038:


 Summary: prepare v1.5.2
 Key: DELTASPIKE-1038
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1038
 Project: DeltaSpike
  Issue Type: Task
Reporter: Gerhard Petracek
Assignee: Gerhard Petracek
 Fix For: 1.5.2






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: @ConfigProperty and constructors

2015-12-04 Thread Gerhard Petracek 
hi romain,

i'll start with the release-steps for v1.5.2 soon -> let's discuss it for
v1.5.3.

regards,
gerhard



2015-12-04 15:49 GMT+01:00 Romain Manni-Bucau :

> Hi guys,
>
> opened https://issues.apache.org/jira/browse/DELTASPIKE-1037
>
> WDYT about this feature?
>
> Side note: wondered if we should support List/Map with the same coercing
> logic, these types are quite common IMHO.
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Tomitriber
> 
>

Re: @ConfigProperty and constructors

2015-12-04 Thread Romain Manni-Bucau 
well we can discuss it even if we dont push anything yet  ;)


Romain Manni-Bucau
@rmannibucau  |  Blog
 | Github  |
LinkedIn  | Tomitriber


2015-12-04 19:22 GMT+01:00 Gerhard Petracek :

> hi romain,
>
> i'll start with the release-steps for v1.5.2 soon -> let's discuss it for
> v1.5.3.
>
> regards,
> gerhard
>
>
>
> 2015-12-04 15:49 GMT+01:00 Romain Manni-Bucau :
>
> > Hi guys,
> >
> > opened https://issues.apache.org/jira/browse/DELTASPIKE-1037
> >
> > WDYT about this feature?
> >
> > Side note: wondered if we should support List/Map with the same coercing
> > logic, these types are quite common IMHO.
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn  | Tomitriber
> > 
> >
>

Re: @ConfigProperty and constructors

2015-12-04 Thread Gerhard Petracek 
+1
(i just mentioned it, because "Fix Version" is currently 1.5.2.)

regards,
gerhard



2015-12-04 19:45 GMT+01:00 Romain Manni-Bucau :

> well we can discuss it even if we dont push anything yet  ;)
>
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Tomitriber
> 
>
> 2015-12-04 19:22 GMT+01:00 Gerhard Petracek :
>
> > hi romain,
> >
> > i'll start with the release-steps for v1.5.2 soon -> let's discuss it for
> > v1.5.3.
> >
> > regards,
> > gerhard
> >
> >
> >
> > 2015-12-04 15:49 GMT+01:00 Romain Manni-Bucau :
> >
> > > Hi guys,
> > >
> > > opened https://issues.apache.org/jira/browse/DELTASPIKE-1037
> > >
> > > WDYT about this feature?
> > >
> > > Side note: wondered if we should support List/Map with the same
> coercing
> > > logic, these types are quite common IMHO.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau  |  Blog
> > >  | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn  | Tomitriber
> > > 
> > >
> >
>

[jira] [Updated] (DELTASPIKE-1037) add support for constructor taking a single String parameter or fromString static method for @ConfigProperty

2015-12-04 Thread Gerhard Petracek (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gerhard Petracek updated DELTASPIKE-1037:
-
Fix Version/s: (was: 1.5.2)
   1.5.3

> add support for constructor taking a single String parameter or fromString 
> static method for @ConfigProperty
> 
>
> Key: DELTASPIKE-1037
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1037
> Project: DeltaSpike
>  Issue Type: New Feature
>Affects Versions: 1.5.1
>Reporter: Romain Manni-Bucau
>Assignee: Romain Manni-Bucau
> Fix For: 1.5.3
>
> Attachments: DELTASPIKE-generic-config.patch
>
>
> Support injection of unknown types if they take a String as parameter or have 
> a static fromString(String) method



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: @ConfigProperty and constructors

2015-12-04 Thread Romain Manni-Bucau 
Oh yep just set the n+1 as a default. Thanks for updating it.
Le 4 déc. 2015 19:53, "Gerhard Petracek"  a
écrit :

> +1
> (i just mentioned it, because "Fix Version" is currently 1.5.2.)
>
> regards,
> gerhard
>
>
>
> 2015-12-04 19:45 GMT+01:00 Romain Manni-Bucau :
>
> > well we can discuss it even if we dont push anything yet  ;)
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn  | Tomitriber
> > 
> >
> > 2015-12-04 19:22 GMT+01:00 Gerhard Petracek  >:
> >
> > > hi romain,
> > >
> > > i'll start with the release-steps for v1.5.2 soon -> let's discuss it
> for
> > > v1.5.3.
> > >
> > > regards,
> > > gerhard
> > >
> > >
> > >
> > > 2015-12-04 15:49 GMT+01:00 Romain Manni-Bucau :
> > >
> > > > Hi guys,
> > > >
> > > > opened https://issues.apache.org/jira/browse/DELTASPIKE-1037
> > > >
> > > > WDYT about this feature?
> > > >
> > > > Side note: wondered if we should support List/Map with the same
> > coercing
> > > > logic, these types are quite common IMHO.
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau  |  Blog
> > > >  | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn  | Tomitriber
> > > > 
> > > >
> > >
> >
>