Re: [VOTE] Release of Apache DeltaSpike 1.7.0
Yep, no worries. I'm patient (secretly points all projects to staging repo) (j/k) @Matej could you apply the fixes in master? If not I can probably get to it late tomorrow. John On Wed, Jun 15, 2016 at 4:46 PM Mark Struberg wrote: > If it’s only an error in the script then it’s surely not a show stopper. > > Could you please just apply the fix in master so others don’t fall into > this trap as well? ;) > > Will continue my review (but probably tomorrow, already really tired today) > > txs and LieGrue, > strub > > > > Am 15.06.2016 um 22:16 schrieb John D. Ament : > > > > Looks like the buildall script has the same bug as I reported. > > > > These two lines: > > > > mvn clean install -PWeld -Dweld.version=1.1.10.Final | tee > > mvn-weld1_1_10.log > > > > mvn clean install -PWeld -Dweld.version=1.1.28.Final | tee > > mvn-weld1_1_28.log > > > > > > Should be: > > > > > > mvn clean install -PWeld1 -Dweld.version=1.1.10.Final | tee > > mvn-weld1_1_10.log > > > > mvn clean install -PWeld1 -Dweld.version=1.1.28.Final | tee > > mvn-weld1_1_28.log > > > > > > I didn't notice as I run these manually > > > > > > So, cancel and fix? or leave it? > > > > > > John > > > > On Wed, Jun 15, 2016 at 4:02 PM Mark Struberg > > > wrote: > > > >> No, that’s a separate one. It is not in the cdictrl module but in the > >> scheduler module. > >> > >> Just unpack the source.zip from the 1.7.0 release candidate and run the > >> buildall.sh script and you’ll see what I mean. > >> > >> LieGrue, > >> strub > >> > >> > >>> Am 15.06.2016 um 16:08 schrieb John D. Ament : > >>> > >>> There might be some issue with the Weld profile(s) and the cdictrl > >> module. > >>> > >>> If I do -PWeld1, it activates the OWB profile in cdictrl. I have to do > >>> > >>> I have to do this to build it properly (from the root): > >>> > >>> mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.10.Final > >>> > >>> > >>> If it makes sense, we can cancel this vote, fix that build issue and > move > >>> on, but I don't believe this is a critical issue and can be fixed in a > >>> follow up 1.7.1 release. This *might* be the issue @struberg is > facing. > >>> > >>> > >>> John > >>> > >>> On Wed, Jun 15, 2016 at 9:26 AM Matej Novotny > >> wrote: > >>> > @struberg, if you are talking about master branch build, than it works > >> for > me with Weld 1.x (tried 1.1.28 && 1.1.10). > > Just tried it with: mvn clean install -PWeld1 > >> -Dweld.version=1.1.28.Final > > Matej > > - Original Message - > > From: "Mark Struberg" > > To: "deltaspike" > > Sent: Wednesday, June 15, 2016 2:52:59 PM > > Subject: Re: [VOTE] Release of Apache DeltaSpike 1.7.0 > > > > Can someone plz check this version with Weld? > > > > [ERROR] mvn -rf :deltaspike-scheduler-module-impl > > > > Did blow up both with weld1_1_28 and 1_1_10 > > > > LieGrue, > > strub > > > >> Am 13.06.2016 um 14:09 schrieb Antoine Sabot-Durand > >> : > >> > >> +1 > >> > >> Le lun. 13 juin 2016 à 13:21, John D. Ament > a > >> écrit : > >> > >>> I guess I'll be the first to vote? Obviously I'm +1 since I ran > the > >>> release twice to make sure no issues... > >>> > >>> John > >>> > >>> > >>> On Thu, Jun 9, 2016 at 8:10 PM John D. Ament < > johndam...@apache.org> > >>> wrote: > >>> > All, > > I was running the needed tasks to get the 1.7.0 release of Apache > DeltaSpike out. > The artifacts are deployed to Nexus [1], the source release > available at > [2]. > > The tag is available at [3] and will get pushed to the ASF > >> repository > >>> once > the vote passed. > > The release notes can be found at [4]. > > Please take a look at the 1.7.0 artifacts and vote! > > Please note: > This vote is "majority approval" with a minimum of three binding > +1 > votes > (see [5]). > > > [ ] +1 for community members who have reviewed the bits > [ ] +0 > [ ] -1 for fatal flaws that should cause these bits not to be > released, > and why.. > > > Thanks, > John > > PS - I found a few issues with the release steps, which I will > >> update > after the release is complete. > > [1] > > >>> > > >> > https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/ > [2] > > >>> > > >> > https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/org/apache/deltaspike/deltaspike/1.7.0/ > [3] https://github.com/johnament/deltaspike/tree/deltaspike-1.7.0 > [4]
Re: [VOTE] Release of Apache DeltaSpike 1.7.0
If it’s only an error in the script then it’s surely not a show stopper. Could you please just apply the fix in master so others don’t fall into this trap as well? ;) Will continue my review (but probably tomorrow, already really tired today) txs and LieGrue, strub > Am 15.06.2016 um 22:16 schrieb John D. Ament : > > Looks like the buildall script has the same bug as I reported. > > These two lines: > > mvn clean install -PWeld -Dweld.version=1.1.10.Final | tee > mvn-weld1_1_10.log > > mvn clean install -PWeld -Dweld.version=1.1.28.Final | tee > mvn-weld1_1_28.log > > > Should be: > > > mvn clean install -PWeld1 -Dweld.version=1.1.10.Final | tee > mvn-weld1_1_10.log > > mvn clean install -PWeld1 -Dweld.version=1.1.28.Final | tee > mvn-weld1_1_28.log > > > I didn't notice as I run these manually > > > So, cancel and fix? or leave it? > > > John > > On Wed, Jun 15, 2016 at 4:02 PM Mark Struberg > wrote: > >> No, that’s a separate one. It is not in the cdictrl module but in the >> scheduler module. >> >> Just unpack the source.zip from the 1.7.0 release candidate and run the >> buildall.sh script and you’ll see what I mean. >> >> LieGrue, >> strub >> >> >>> Am 15.06.2016 um 16:08 schrieb John D. Ament : >>> >>> There might be some issue with the Weld profile(s) and the cdictrl >> module. >>> >>> If I do -PWeld1, it activates the OWB profile in cdictrl. I have to do >>> >>> I have to do this to build it properly (from the root): >>> >>> mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.10.Final >>> >>> >>> If it makes sense, we can cancel this vote, fix that build issue and move >>> on, but I don't believe this is a critical issue and can be fixed in a >>> follow up 1.7.1 release. This *might* be the issue @struberg is facing. >>> >>> >>> John >>> >>> On Wed, Jun 15, 2016 at 9:26 AM Matej Novotny >> wrote: >>> @struberg, if you are talking about master branch build, than it works >> for me with Weld 1.x (tried 1.1.28 && 1.1.10). Just tried it with: mvn clean install -PWeld1 >> -Dweld.version=1.1.28.Final Matej - Original Message - > From: "Mark Struberg" > To: "deltaspike" > Sent: Wednesday, June 15, 2016 2:52:59 PM > Subject: Re: [VOTE] Release of Apache DeltaSpike 1.7.0 > > Can someone plz check this version with Weld? > > [ERROR] mvn -rf :deltaspike-scheduler-module-impl > > Did blow up both with weld1_1_28 and 1_1_10 > > LieGrue, > strub > >> Am 13.06.2016 um 14:09 schrieb Antoine Sabot-Durand >> : >> >> +1 >> >> Le lun. 13 juin 2016 à 13:21, John D. Ament a >> écrit : >> >>> I guess I'll be the first to vote? Obviously I'm +1 since I ran the >>> release twice to make sure no issues... >>> >>> John >>> >>> >>> On Thu, Jun 9, 2016 at 8:10 PM John D. Ament >>> wrote: >>> All, I was running the needed tasks to get the 1.7.0 release of Apache DeltaSpike out. The artifacts are deployed to Nexus [1], the source release available at [2]. The tag is available at [3] and will get pushed to the ASF >> repository >>> once the vote passed. The release notes can be found at [4]. Please take a look at the 1.7.0 artifacts and vote! Please note: This vote is "majority approval" with a minimum of three binding +1 votes (see [5]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, John PS - I found a few issues with the release steps, which I will >> update after the release is complete. [1] >>> >> https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/ [2] >>> >> https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/org/apache/deltaspike/deltaspike/1.7.0/ [3] https://github.com/johnament/deltaspike/tree/deltaspike-1.7.0 [4] https://s.apache.org/DeltaSpike-1.7.0 [5] http://www.apache.org/foundation/voting.html#ReleaseVotes >>> > > >> >>
[jira] [Updated] (DELTASPIKE-1175) Weld(1|2|3) profiles do not activate Weld profile in cdictrl
[
https://issues.apache.org/jira/browse/DELTASPIKE-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John D. Ament updated DELTASPIKE-1175:
--
Description:
If you run the build with {{mvn clean install -PWeld1
-Dweld.version=1.1.28.Final}} you'll see the OWB container control module get
built. It should build the Weld module. To get it to activate properly you
need to do {{mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.28.Final}}
In addition, if it can be fixed in here, the {{buildall.sh}} script incorrectly
points to {{-PWeld}} instead of {{-PWeld1}}.
was:If you run the build with {{mvn clean install -PWeld1
-Dweld.version=1.1.28.Final}} you'll see the OWB container control module get
built. It should build the Weld module. To get it to activate properly you
need to do {{mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.28.Final}}
> Weld(1|2|3) profiles do not activate Weld profile in cdictrl
>
>
> Key: DELTASPIKE-1175
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1175
> Project: DeltaSpike
> Issue Type: Bug
> Components: CdiControl
>Affects Versions: 1.7.0
>Reporter: John D. Ament
>
> If you run the build with {{mvn clean install -PWeld1
> -Dweld.version=1.1.28.Final}} you'll see the OWB container control module get
> built. It should build the Weld module. To get it to activate properly you
> need to do {{mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.28.Final}}
> In addition, if it can be fixed in here, the {{buildall.sh}} script
> incorrectly points to {{-PWeld}} instead of {{-PWeld1}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release of Apache DeltaSpike 1.7.0
Looks like the buildall script has the same bug as I reported. These two lines: mvn clean install -PWeld -Dweld.version=1.1.10.Final | tee mvn-weld1_1_10.log mvn clean install -PWeld -Dweld.version=1.1.28.Final | tee mvn-weld1_1_28.log Should be: mvn clean install -PWeld1 -Dweld.version=1.1.10.Final | tee mvn-weld1_1_10.log mvn clean install -PWeld1 -Dweld.version=1.1.28.Final | tee mvn-weld1_1_28.log I didn't notice as I run these manually So, cancel and fix? or leave it? John On Wed, Jun 15, 2016 at 4:02 PM Mark Struberg wrote: > No, that’s a separate one. It is not in the cdictrl module but in the > scheduler module. > > Just unpack the source.zip from the 1.7.0 release candidate and run the > buildall.sh script and you’ll see what I mean. > > LieGrue, > strub > > > > Am 15.06.2016 um 16:08 schrieb John D. Ament : > > > > There might be some issue with the Weld profile(s) and the cdictrl > module. > > > > If I do -PWeld1, it activates the OWB profile in cdictrl. I have to do > > > > I have to do this to build it properly (from the root): > > > > mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.10.Final > > > > > > If it makes sense, we can cancel this vote, fix that build issue and move > > on, but I don't believe this is a critical issue and can be fixed in a > > follow up 1.7.1 release. This *might* be the issue @struberg is facing. > > > > > > John > > > > On Wed, Jun 15, 2016 at 9:26 AM Matej Novotny > wrote: > > > >> @struberg, if you are talking about master branch build, than it works > for > >> me with Weld 1.x (tried 1.1.28 && 1.1.10). > >> > >> Just tried it with: mvn clean install -PWeld1 > -Dweld.version=1.1.28.Final > >> > >> Matej > >> > >> - Original Message - > >>> From: "Mark Struberg" > >>> To: "deltaspike" > >>> Sent: Wednesday, June 15, 2016 2:52:59 PM > >>> Subject: Re: [VOTE] Release of Apache DeltaSpike 1.7.0 > >>> > >>> Can someone plz check this version with Weld? > >>> > >>> [ERROR] mvn -rf :deltaspike-scheduler-module-impl > >>> > >>> Did blow up both with weld1_1_28 and 1_1_10 > >>> > >>> LieGrue, > >>> strub > >>> > Am 13.06.2016 um 14:09 schrieb Antoine Sabot-Durand > : > > +1 > > Le lun. 13 juin 2016 à 13:21, John D. Ament a > écrit : > > > I guess I'll be the first to vote? Obviously I'm +1 since I ran the > > release twice to make sure no issues... > > > > John > > > > > > On Thu, Jun 9, 2016 at 8:10 PM John D. Ament > > wrote: > > > >> All, > >> > >> I was running the needed tasks to get the 1.7.0 release of Apache > >> DeltaSpike out. > >> The artifacts are deployed to Nexus [1], the source release > >> available at > >> [2]. > >> > >> The tag is available at [3] and will get pushed to the ASF > repository > > once > >> the vote passed. > >> > >> The release notes can be found at [4]. > >> > >> Please take a look at the 1.7.0 artifacts and vote! > >> > >> Please note: > >> This vote is "majority approval" with a minimum of three binding +1 > >> votes > >> (see [5]). > >> > >> > >> [ ] +1 for community members who have reviewed the bits > >> [ ] +0 > >> [ ] -1 for fatal flaws that should cause these bits not to be > >> released, > >> and why.. > >> > >> > >> Thanks, > >> John > >> > >> PS - I found a few issues with the release steps, which I will > update > >> after the release is complete. > >> > >> [1] > >> > > > >> > https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/ > >> [2] > >> > > > >> > https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/org/apache/deltaspike/deltaspike/1.7.0/ > >> [3] https://github.com/johnament/deltaspike/tree/deltaspike-1.7.0 > >> [4] https://s.apache.org/DeltaSpike-1.7.0 > >> [5] http://www.apache.org/foundation/voting.html#ReleaseVotes > >> > > > >>> > >>> > >> > >
Re: [VOTE] Release of Apache DeltaSpike 1.7.0
No, that’s a separate one. It is not in the cdictrl module but in the scheduler module. Just unpack the source.zip from the 1.7.0 release candidate and run the buildall.sh script and you’ll see what I mean. LieGrue, strub > Am 15.06.2016 um 16:08 schrieb John D. Ament : > > There might be some issue with the Weld profile(s) and the cdictrl module. > > If I do -PWeld1, it activates the OWB profile in cdictrl. I have to do > > I have to do this to build it properly (from the root): > > mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.10.Final > > > If it makes sense, we can cancel this vote, fix that build issue and move > on, but I don't believe this is a critical issue and can be fixed in a > follow up 1.7.1 release. This *might* be the issue @struberg is facing. > > > John > > On Wed, Jun 15, 2016 at 9:26 AM Matej Novotny wrote: > >> @struberg, if you are talking about master branch build, than it works for >> me with Weld 1.x (tried 1.1.28 && 1.1.10). >> >> Just tried it with: mvn clean install -PWeld1 -Dweld.version=1.1.28.Final >> >> Matej >> >> - Original Message - >>> From: "Mark Struberg" >>> To: "deltaspike" >>> Sent: Wednesday, June 15, 2016 2:52:59 PM >>> Subject: Re: [VOTE] Release of Apache DeltaSpike 1.7.0 >>> >>> Can someone plz check this version with Weld? >>> >>> [ERROR] mvn -rf :deltaspike-scheduler-module-impl >>> >>> Did blow up both with weld1_1_28 and 1_1_10 >>> >>> LieGrue, >>> strub >>> Am 13.06.2016 um 14:09 schrieb Antoine Sabot-Durand : +1 Le lun. 13 juin 2016 à 13:21, John D. Ament a écrit : > I guess I'll be the first to vote? Obviously I'm +1 since I ran the > release twice to make sure no issues... > > John > > > On Thu, Jun 9, 2016 at 8:10 PM John D. Ament > wrote: > >> All, >> >> I was running the needed tasks to get the 1.7.0 release of Apache >> DeltaSpike out. >> The artifacts are deployed to Nexus [1], the source release >> available at >> [2]. >> >> The tag is available at [3] and will get pushed to the ASF repository > once >> the vote passed. >> >> The release notes can be found at [4]. >> >> Please take a look at the 1.7.0 artifacts and vote! >> >> Please note: >> This vote is "majority approval" with a minimum of three binding +1 >> votes >> (see [5]). >> >> >> [ ] +1 for community members who have reviewed the bits >> [ ] +0 >> [ ] -1 for fatal flaws that should cause these bits not to be >> released, >> and why.. >> >> >> Thanks, >> John >> >> PS - I found a few issues with the release steps, which I will update >> after the release is complete. >> >> [1] >> > >> https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/ >> [2] >> > >> https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/org/apache/deltaspike/deltaspike/1.7.0/ >> [3] https://github.com/johnament/deltaspike/tree/deltaspike-1.7.0 >> [4] https://s.apache.org/DeltaSpike-1.7.0 >> [5] http://www.apache.org/foundation/voting.html#ReleaseVotes >> > >>> >>> >>
[jira] [Commented] (DELTASPIKE-1175) Weld(1|2|3) profiles do not activate Weld profile in cdictrl
[
https://issues.apache.org/jira/browse/DELTASPIKE-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332079#comment-15332079
]
John D. Ament commented on DELTASPIKE-1175:
---
Its very likely the parent structure needs to be revamped. Previously we
didn't have a root pom, it was always in the {{deltaspike}} folder, so release
execution was from there. When we moved the docs into our repo, it became a
root pom, but now the structure needs to be fixed up I suppose.
> Weld(1|2|3) profiles do not activate Weld profile in cdictrl
>
>
> Key: DELTASPIKE-1175
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1175
> Project: DeltaSpike
> Issue Type: Bug
> Components: CdiControl
>Affects Versions: 1.7.0
>Reporter: John D. Ament
>
> If you run the build with {{mvn clean install -PWeld1
> -Dweld.version=1.1.28.Final}} you'll see the OWB container control module get
> built. It should build the Weld module. To get it to activate properly you
> need to do {{mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.28.Final}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1175) Weld(1|2|3) profiles do not activate Weld profile in cdictrl
[
https://issues.apache.org/jira/browse/DELTASPIKE-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331940#comment-15331940
]
Matej Novotny commented on DELTASPIKE-1175:
---
It cannot even detect Weld profiles because the parent of {{cdictrl}} is
{{parent}} ({{../parent/pom.xml}}) and Weld profiles are defined in
{{parent-code}} ({{../parent/code/pom.xml}}).
Besides {{cdictrl}} defines its own profile named {{Weld}}.
I suppose altering the parent to {{parent-code}} would give access to those
profiles and then you could extend those profiles by adding adequate
{{}} subsections?
> Weld(1|2|3) profiles do not activate Weld profile in cdictrl
>
>
> Key: DELTASPIKE-1175
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1175
> Project: DeltaSpike
> Issue Type: Bug
> Components: CdiControl
>Affects Versions: 1.7.0
>Reporter: John D. Ament
>
> If you run the build with {{mvn clean install -PWeld1
> -Dweld.version=1.1.28.Final}} you'll see the OWB container control module get
> built. It should build the Weld module. To get it to activate properly you
> need to do {{mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.28.Final}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release of Apache DeltaSpike 1.7.0
FYI - https://issues.apache.org/jira/browse/DELTASPIKE-1175 On Wed, Jun 15, 2016 at 10:08 AM John D. Ament wrote: > There might be some issue with the Weld profile(s) and the cdictrl module. > > If I do -PWeld1, it activates the OWB profile in cdictrl. I have to do > > I have to do this to build it properly (from the root): > > mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.10.Final > > > If it makes sense, we can cancel this vote, fix that build issue and move > on, but I don't believe this is a critical issue and can be fixed in a > follow up 1.7.1 release. This *might* be the issue @struberg is facing. > > > John > > On Wed, Jun 15, 2016 at 9:26 AM Matej Novotny wrote: > >> @struberg, if you are talking about master branch build, than it works >> for me with Weld 1.x (tried 1.1.28 && 1.1.10). >> >> Just tried it with: mvn clean install -PWeld1 -Dweld.version=1.1.28.Final >> >> Matej >> >> - Original Message - >> > From: "Mark Struberg" >> > To: "deltaspike" >> > Sent: Wednesday, June 15, 2016 2:52:59 PM >> > Subject: Re: [VOTE] Release of Apache DeltaSpike 1.7.0 >> > >> > Can someone plz check this version with Weld? >> > >> > [ERROR] mvn -rf :deltaspike-scheduler-module-impl >> > >> > Did blow up both with weld1_1_28 and 1_1_10 >> > >> > LieGrue, >> > strub >> > >> > > Am 13.06.2016 um 14:09 schrieb Antoine Sabot-Durand >> > > : >> > > >> > > +1 >> > > >> > > Le lun. 13 juin 2016 à 13:21, John D. Ament a >> > > écrit : >> > > >> > >> I guess I'll be the first to vote? Obviously I'm +1 since I ran the >> > >> release twice to make sure no issues... >> > >> >> > >> John >> > >> >> > >> >> > >> On Thu, Jun 9, 2016 at 8:10 PM John D. Ament >> > >> wrote: >> > >> >> > >>> All, >> > >>> >> > >>> I was running the needed tasks to get the 1.7.0 release of Apache >> > >>> DeltaSpike out. >> > >>> The artifacts are deployed to Nexus [1], the source release >> available at >> > >>> [2]. >> > >>> >> > >>> The tag is available at [3] and will get pushed to the ASF >> repository >> > >> once >> > >>> the vote passed. >> > >>> >> > >>> The release notes can be found at [4]. >> > >>> >> > >>> Please take a look at the 1.7.0 artifacts and vote! >> > >>> >> > >>> Please note: >> > >>> This vote is "majority approval" with a minimum of three binding +1 >> votes >> > >>> (see [5]). >> > >>> >> > >>> >> > >>> [ ] +1 for community members who have reviewed the bits >> > >>> [ ] +0 >> > >>> [ ] -1 for fatal flaws that should cause these bits not to be >> released, >> > >>> and why.. >> > >>> >> > >>> >> > >>> Thanks, >> > >>> John >> > >>> >> > >>> PS - I found a few issues with the release steps, which I will >> update >> > >>> after the release is complete. >> > >>> >> > >>> [1] >> > >>> >> > >> >> https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/ >> > >>> [2] >> > >>> >> > >> >> https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/org/apache/deltaspike/deltaspike/1.7.0/ >> > >>> [3] https://github.com/johnament/deltaspike/tree/deltaspike-1.7.0 >> > >>> [4] https://s.apache.org/DeltaSpike-1.7.0 >> > >>> [5] http://www.apache.org/foundation/voting.html#ReleaseVotes >> > >>> >> > >> >> > >> > >> >
[jira] [Created] (DELTASPIKE-1175) Weld(1|2|3) profiles do not activate Weld profile in cdictrl
John D. Ament created DELTASPIKE-1175:
-
Summary: Weld(1|2|3) profiles do not activate Weld profile in
cdictrl
Key: DELTASPIKE-1175
URL: https://issues.apache.org/jira/browse/DELTASPIKE-1175
Project: DeltaSpike
Issue Type: Bug
Components: CdiControl
Affects Versions: 1.7.0
Reporter: John D. Ament
If you run the build with {{mvn clean install -PWeld1
-Dweld.version=1.1.28.Final}} you'll see the OWB container control module get
built. It should build the Weld module. To get it to activate properly you
need to do {{mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.28.Final}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release of Apache DeltaSpike 1.7.0
There might be some issue with the Weld profile(s) and the cdictrl module. If I do -PWeld1, it activates the OWB profile in cdictrl. I have to do I have to do this to build it properly (from the root): mvn clean install -PWeld -PWeld1 -Dweld.version=1.1.10.Final If it makes sense, we can cancel this vote, fix that build issue and move on, but I don't believe this is a critical issue and can be fixed in a follow up 1.7.1 release. This *might* be the issue @struberg is facing. John On Wed, Jun 15, 2016 at 9:26 AM Matej Novotny wrote: > @struberg, if you are talking about master branch build, than it works for > me with Weld 1.x (tried 1.1.28 && 1.1.10). > > Just tried it with: mvn clean install -PWeld1 -Dweld.version=1.1.28.Final > > Matej > > - Original Message - > > From: "Mark Struberg" > > To: "deltaspike" > > Sent: Wednesday, June 15, 2016 2:52:59 PM > > Subject: Re: [VOTE] Release of Apache DeltaSpike 1.7.0 > > > > Can someone plz check this version with Weld? > > > > [ERROR] mvn -rf :deltaspike-scheduler-module-impl > > > > Did blow up both with weld1_1_28 and 1_1_10 > > > > LieGrue, > > strub > > > > > Am 13.06.2016 um 14:09 schrieb Antoine Sabot-Durand > > > : > > > > > > +1 > > > > > > Le lun. 13 juin 2016 à 13:21, John D. Ament a > > > écrit : > > > > > >> I guess I'll be the first to vote? Obviously I'm +1 since I ran the > > >> release twice to make sure no issues... > > >> > > >> John > > >> > > >> > > >> On Thu, Jun 9, 2016 at 8:10 PM John D. Ament > > >> wrote: > > >> > > >>> All, > > >>> > > >>> I was running the needed tasks to get the 1.7.0 release of Apache > > >>> DeltaSpike out. > > >>> The artifacts are deployed to Nexus [1], the source release > available at > > >>> [2]. > > >>> > > >>> The tag is available at [3] and will get pushed to the ASF repository > > >> once > > >>> the vote passed. > > >>> > > >>> The release notes can be found at [4]. > > >>> > > >>> Please take a look at the 1.7.0 artifacts and vote! > > >>> > > >>> Please note: > > >>> This vote is "majority approval" with a minimum of three binding +1 > votes > > >>> (see [5]). > > >>> > > >>> > > >>> [ ] +1 for community members who have reviewed the bits > > >>> [ ] +0 > > >>> [ ] -1 for fatal flaws that should cause these bits not to be > released, > > >>> and why.. > > >>> > > >>> > > >>> Thanks, > > >>> John > > >>> > > >>> PS - I found a few issues with the release steps, which I will update > > >>> after the release is complete. > > >>> > > >>> [1] > > >>> > > >> > https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/ > > >>> [2] > > >>> > > >> > https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/org/apache/deltaspike/deltaspike/1.7.0/ > > >>> [3] https://github.com/johnament/deltaspike/tree/deltaspike-1.7.0 > > >>> [4] https://s.apache.org/DeltaSpike-1.7.0 > > >>> [5] http://www.apache.org/foundation/voting.html#ReleaseVotes > > >>> > > >> > > > > >
Re: [VOTE] Release of Apache DeltaSpike 1.7.0
@struberg, if you are talking about master branch build, than it works for me with Weld 1.x (tried 1.1.28 && 1.1.10). Just tried it with: mvn clean install -PWeld1 -Dweld.version=1.1.28.Final Matej - Original Message - > From: "Mark Struberg" > To: "deltaspike" > Sent: Wednesday, June 15, 2016 2:52:59 PM > Subject: Re: [VOTE] Release of Apache DeltaSpike 1.7.0 > > Can someone plz check this version with Weld? > > [ERROR] mvn -rf :deltaspike-scheduler-module-impl > > Did blow up both with weld1_1_28 and 1_1_10 > > LieGrue, > strub > > > Am 13.06.2016 um 14:09 schrieb Antoine Sabot-Durand > > : > > > > +1 > > > > Le lun. 13 juin 2016 à 13:21, John D. Ament a > > écrit : > > > >> I guess I'll be the first to vote? Obviously I'm +1 since I ran the > >> release twice to make sure no issues... > >> > >> John > >> > >> > >> On Thu, Jun 9, 2016 at 8:10 PM John D. Ament > >> wrote: > >> > >>> All, > >>> > >>> I was running the needed tasks to get the 1.7.0 release of Apache > >>> DeltaSpike out. > >>> The artifacts are deployed to Nexus [1], the source release available at > >>> [2]. > >>> > >>> The tag is available at [3] and will get pushed to the ASF repository > >> once > >>> the vote passed. > >>> > >>> The release notes can be found at [4]. > >>> > >>> Please take a look at the 1.7.0 artifacts and vote! > >>> > >>> Please note: > >>> This vote is "majority approval" with a minimum of three binding +1 votes > >>> (see [5]). > >>> > >>> > >>> [ ] +1 for community members who have reviewed the bits > >>> [ ] +0 > >>> [ ] -1 for fatal flaws that should cause these bits not to be released, > >>> and why.. > >>> > >>> > >>> Thanks, > >>> John > >>> > >>> PS - I found a few issues with the release steps, which I will update > >>> after the release is complete. > >>> > >>> [1] > >>> > >> https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/ > >>> [2] > >>> > >> https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/org/apache/deltaspike/deltaspike/1.7.0/ > >>> [3] https://github.com/johnament/deltaspike/tree/deltaspike-1.7.0 > >>> [4] https://s.apache.org/DeltaSpike-1.7.0 > >>> [5] http://www.apache.org/foundation/voting.html#ReleaseVotes > >>> > >> > >
Re: [VOTE] Release of Apache DeltaSpike 1.7.0
Can someone plz check this version with Weld? [ERROR] mvn -rf :deltaspike-scheduler-module-impl Did blow up both with weld1_1_28 and 1_1_10 LieGrue, strub > Am 13.06.2016 um 14:09 schrieb Antoine Sabot-Durand > : > > +1 > > Le lun. 13 juin 2016 à 13:21, John D. Ament a > écrit : > >> I guess I'll be the first to vote? Obviously I'm +1 since I ran the >> release twice to make sure no issues... >> >> John >> >> >> On Thu, Jun 9, 2016 at 8:10 PM John D. Ament >> wrote: >> >>> All, >>> >>> I was running the needed tasks to get the 1.7.0 release of Apache >>> DeltaSpike out. >>> The artifacts are deployed to Nexus [1], the source release available at >>> [2]. >>> >>> The tag is available at [3] and will get pushed to the ASF repository >> once >>> the vote passed. >>> >>> The release notes can be found at [4]. >>> >>> Please take a look at the 1.7.0 artifacts and vote! >>> >>> Please note: >>> This vote is "majority approval" with a minimum of three binding +1 votes >>> (see [5]). >>> >>> >>> [ ] +1 for community members who have reviewed the bits >>> [ ] +0 >>> [ ] -1 for fatal flaws that should cause these bits not to be released, >>> and why.. >>> >>> >>> Thanks, >>> John >>> >>> PS - I found a few issues with the release steps, which I will update >>> after the release is complete. >>> >>> [1] >>> >> https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/ >>> [2] >>> >> https://repository.apache.org/content/repositories/orgapachedeltaspike-1038/org/apache/deltaspike/deltaspike/1.7.0/ >>> [3] https://github.com/johnament/deltaspike/tree/deltaspike-1.7.0 >>> [4] https://s.apache.org/DeltaSpike-1.7.0 >>> [5] http://www.apache.org/foundation/voting.html#ReleaseVotes >>> >>
