[jira] [Commented] (DELTASPIKE-1281) Deltaspike does not pass BeanManager to persistenf factory config using "javax.persistence.bean.manager"
[
https://issues.apache.org/jira/browse/DELTASPIKE-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124740#comment-16124740
]
ASF subversion and git services commented on DELTASPIKE-1281:
-
Commit 618dd99b6861c80250d2724208e77807c14b5f32 in deltaspike's branch
refs/heads/master from [~johndament]
[ https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;h=618dd99 ]
DELTASPIKE-1281 - Updating test.
> Deltaspike does not pass BeanManager to persistenf factory config using
> "javax.persistence.bean.manager"
>
>
> Key: DELTASPIKE-1281
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1281
> Project: DeltaSpike
> Issue Type: Bug
> Components: JPA-Module
>Affects Versions: 1.8.0
> Environment: Deltaspike 1.8, Weld 3.0, Java 8 (JSE) JPA with
> HIbernate 5.2.10
>Reporter: Alex Roytman
>Assignee: John D. Ament
> Fix For: 1.8.1
>
>
> As the result no injections were working in JPA listeners.
> Per specs Persistence UnitFactory expects BeanManager in
> javax.persistence.bean.manager property passed when instantiate it but
> org.apache.deltaspike.jpa.impl.entitymanager.PersistenceConfigurationProviderImpl
> does not pass it
> this simple override took care of it but I should not need to do it:
> {code:java}
> @ApplicationScoped
> @Alternative
> @Priority(Interceptor.Priority.APPLICATION + 10)
> public class CdiAwarePersistenceConfigurationProviderImpl extends
> PersistenceConfigurationProviderImpl implements
> PersistenceConfigurationProvider {
> @Inject BeanManager beanManager;
> @Override public Properties getEntityManagerFactoryConfiguration(String
> persistenceUnitName) {
> final Properties conf =
> super.getEntityManagerFactoryConfiguration(persistenceUnitName);
> conf.put("javax.persistence.bean.manager", beanManager);
> return conf;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (DELTASPIKE-1278) PropertyFileConfig does not respect optional on external resources
[
https://issues.apache.org/jira/browse/DELTASPIKE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John D. Ament resolved DELTASPIKE-1278.
---
Resolution: Fixed
Assignee: John D. Ament
Fix Version/s: 1.8.1
Thanks for the contribution, merged!
> PropertyFileConfig does not respect optional on external resources
> --
>
> Key: DELTASPIKE-1278
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1278
> Project: DeltaSpike
> Issue Type: Bug
> Components: Configuration
>Affects Versions: 1.8.0
>Reporter: Dennis Rippinger
>Assignee: John D. Ament
> Fix For: 1.8.1
>
>
> Adding a property file from an external location (e.g. local file system)
> marked as optional is not respected by {{PropertyFileUtils}}. It creates a
> list of possible resource URLs, but does not check for their existence in all
> branches of its logic. This results in a list of possible nonexistent
> resources which could be optional, leading to an IllegalStateException.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1278) PropertyFileConfig does not respect optional on external resources
[
https://issues.apache.org/jira/browse/DELTASPIKE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124734#comment-16124734
]
ASF GitHub Bot commented on DELTASPIKE-1278:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/74
> PropertyFileConfig does not respect optional on external resources
> --
>
> Key: DELTASPIKE-1278
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1278
> Project: DeltaSpike
> Issue Type: Bug
> Components: Configuration
>Affects Versions: 1.8.0
>Reporter: Dennis Rippinger
>
> Adding a property file from an external location (e.g. local file system)
> marked as optional is not respected by {{PropertyFileUtils}}. It creates a
> list of possible resource URLs, but does not check for their existence in all
> branches of its logic. This results in a list of possible nonexistent
> resources which could be optional, leading to an IllegalStateException.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1278) PropertyFileConfig does not respect optional on external resources
[
https://issues.apache.org/jira/browse/DELTASPIKE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124733#comment-16124733
]
ASF subversion and git services commented on DELTASPIKE-1278:
-
Commit c7b5471c2912b68775ae887ab99d3e6cac57a053 in deltaspike's branch
refs/heads/master from [~dennis.rippinger]
[ https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;h=c7b5471 ]
DELTASPIKE-1278: Added an additonal check to ensure local resources do exist to
respect optional flag.
This closes #74
> PropertyFileConfig does not respect optional on external resources
> --
>
> Key: DELTASPIKE-1278
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1278
> Project: DeltaSpike
> Issue Type: Bug
> Components: Configuration
>Affects Versions: 1.8.0
>Reporter: Dennis Rippinger
>
> Adding a property file from an external location (e.g. local file system)
> marked as optional is not respected by {{PropertyFileUtils}}. It creates a
> list of possible resource URLs, but does not check for their existence in all
> branches of its logic. This results in a list of possible nonexistent
> resources which could be optional, leading to an IllegalStateException.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] deltaspike pull request #74: DELTASPIKE-1278: Added an additonal check
Github user asfgit closed the pull request at: https://github.com/apache/deltaspike/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (DELTASPIKE-940) @Transactional and @EntityManagerConfig each use a different method to resolve EntityManagers
[
https://issues.apache.org/jira/browse/DELTASPIKE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124726#comment-16124726
]
John D. Ament commented on DELTASPIKE-940:
--
[~tandraschko] sorry thought I had already responded. The problem with pulling
it out is that it has to be in two places, since this annotation can control
both transactions and repository. Having it in a common place makes more sense.
> @Transactional and @EntityManagerConfig each use a different method to
> resolve EntityManagers
> -
>
> Key: DELTASPIKE-940
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-940
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Data-Module, JPA-Module
>Reporter: Xavier Dury
>Assignee: John D. Ament
>Priority: Minor
> Fix For: 1.8.1
>
> Attachments: ds940.patch
>
>
> When an application uses multiple {{EntityManager}}'s, there must be a way to
> specify which one(s) should be used. Currently, {{@Transactional}} and
> {{@EntityManagerConfig}} use different approaches:
> - {{@Transactional}} can take one or more qualifiers directly in its
> {{qualifier()}} member ({{@Transactional(qualifier = MyDB.class)}})
> - While {{@EntityManagerConfig}} must define an {{EntityManagerResolver}}
> ({{@EntityManagerConfig(entityManagerResolver =
> MyDBEntityManagerResolver.class}})
> I think both should be unified and use a single way to specify which
> {{EntityManager}} to use. IMHO, the {{@Transactional}} way of doing looks
> better and should be applied to {{@EntityManagerConfig}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (DELTASPIKE-1281) Deltaspike does not pass BeanManager to persistenf factory config using "javax.persistence.bean.manager"
[
https://issues.apache.org/jira/browse/DELTASPIKE-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John D. Ament resolved DELTASPIKE-1281.
---
Resolution: Fixed
Done.
> Deltaspike does not pass BeanManager to persistenf factory config using
> "javax.persistence.bean.manager"
>
>
> Key: DELTASPIKE-1281
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1281
> Project: DeltaSpike
> Issue Type: Bug
> Components: JPA-Module
>Affects Versions: 1.8.0
> Environment: Deltaspike 1.8, Weld 3.0, Java 8 (JSE) JPA with
> HIbernate 5.2.10
>Reporter: Alex Roytman
>Assignee: John D. Ament
> Fix For: 1.8.1
>
>
> As the result no injections were working in JPA listeners.
> Per specs Persistence UnitFactory expects BeanManager in
> javax.persistence.bean.manager property passed when instantiate it but
> org.apache.deltaspike.jpa.impl.entitymanager.PersistenceConfigurationProviderImpl
> does not pass it
> this simple override took care of it but I should not need to do it:
> {code:java}
> @ApplicationScoped
> @Alternative
> @Priority(Interceptor.Priority.APPLICATION + 10)
> public class CdiAwarePersistenceConfigurationProviderImpl extends
> PersistenceConfigurationProviderImpl implements
> PersistenceConfigurationProvider {
> @Inject BeanManager beanManager;
> @Override public Properties getEntityManagerFactoryConfiguration(String
> persistenceUnitName) {
> final Properties conf =
> super.getEntityManagerFactoryConfiguration(persistenceUnitName);
> conf.put("javax.persistence.bean.manager", beanManager);
> return conf;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-940) @Transactional and @EntityManagerConfig each use a different method to resolve EntityManagers
[
https://issues.apache.org/jira/browse/DELTASPIKE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124650#comment-16124650
]
ASF subversion and git services commented on DELTASPIKE-940:
Commit 28bcefc88dc38c27ad6acfe28a46f1810af81c56 in deltaspike's branch
refs/heads/master from [~johndament]
[ https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;h=28bcefc ]
DELTASPIKE-940 - Avoid reading transactional annotation.
> @Transactional and @EntityManagerConfig each use a different method to
> resolve EntityManagers
> -
>
> Key: DELTASPIKE-940
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-940
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Data-Module, JPA-Module
>Reporter: Xavier Dury
>Assignee: John D. Ament
>Priority: Minor
> Fix For: 1.8.1
>
> Attachments: ds940.patch
>
>
> When an application uses multiple {{EntityManager}}'s, there must be a way to
> specify which one(s) should be used. Currently, {{@Transactional}} and
> {{@EntityManagerConfig}} use different approaches:
> - {{@Transactional}} can take one or more qualifiers directly in its
> {{qualifier()}} member ({{@Transactional(qualifier = MyDB.class)}})
> - While {{@EntityManagerConfig}} must define an {{EntityManagerResolver}}
> ({{@EntityManagerConfig(entityManagerResolver =
> MyDBEntityManagerResolver.class}})
> I think both should be unified and use a single way to specify which
> {{EntityManager}} to use. IMHO, the {{@Transactional}} way of doing looks
> better and should be applied to {{@EntityManagerConfig}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
