[GitHub] [deltaspike] SethFalco edited a comment on pull request #109: Support for Additional Converters by Default

2021-09-25 Thread GitBox 


SethFalco edited a comment on pull request #109:
URL: https://github.com/apache/deltaspike/pull/109#issuecomment-927151911


   Hey! Understood, I'll squash this PR and match the improvements suggested 
from BeanUtils.
   Even if this won't be merged as is, the logic should still be updated anyway.
   
   Meanwhile, having implicit converters seems cool.
   
   This PR includes 5 converters that would be made redundant, assuming we 
stuck with the current implementations.
   * 
[Duration](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Duration.html)
 
([`Duration#parse`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Duration.html#parse(java.lang.CharSequence)))
   * 
[File](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/File.html)
 
([`File::new`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/File.html#%3Cinit%3E(java.lang.String)))
   * 
[Instant](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Instant.html)
 
([`Instant#parse`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Instant.html#parse(java.lang.CharSequence)))
   * 
[Period](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Period.html)
 
([`Period#parse`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Period.html#parse(java.lang.CharSequence)))
   * 
[URI](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/URI.html)
 
([`URI::new`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/URI.html#%3Cinit%3E(java.lang.String)))
   
   Just a note, but something that could've been implicit, but doesn't meet the 
current spec is `#fromString(java.lang.String)`?
   But only the following have it in the standard library:
   * 
[UUID](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/UUID.html)
 
([`UUID#fromString`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/UUID.html#fromString(java.lang.String)))
   * 
[PosixFilePermissions](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/nio/file/attribute/PosixFilePermissions.html)
 
([`PosixFilePermissions#fromString`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/nio/file/attribute/PosixFilePermissions.html#fromString(java.lang.String)))


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@deltaspike.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [deltaspike] SethFalco commented on pull request #109: Support for Additional Converters by Default

2021-09-25 Thread GitBox 


SethFalco commented on pull request #109:
URL: https://github.com/apache/deltaspike/pull/109#issuecomment-927151911


   Hey! Understood, I'll squash this PR and match the improvements suggested 
from BeanUtils.
   Even if this won't be merged as is, the logic should still be updated anyway.
   
   Meanwhile, having implicit converters seems cool.
   
   This PR includes 5 converters that would be made redundant, assuming we 
stuck with the current implementations.
   * 
[Duration](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Duration.html)
 
([`Duration#parse`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Duration.html#parse(java.lang.CharSequence)))
   * 
[File](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/File.html)
 
([`File::new`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/File.html#%3Cinit%3E(java.lang.String)))
   * 
[Instant](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Instant.html)
 
([`Instant#parse`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Instant.html#parse(java.lang.CharSequence)))
   * 
[Period](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Period.html)
 
([`Period#parse`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Period.html#parse(java.lang.CharSequence)))
   * 
[URI](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/URI.html)
 
([`URI::new`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/URI.html#%3Cinit%3E(java.lang.String)))
   
   Just a note, but something that could've been implicit, but doesn't meet the 
current spec is `#fromString`?
   But only the following have it in the standard library:
   * 
[UUID](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/UUID.html)
 
([`UUID#fromString`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/UUID.html#fromString(java.lang.String)))
   * 
[PosixFilePermissions](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/nio/file/attribute/PosixFilePermissions.html)
 
([`PosixFilePermissions#fromString`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/nio/file/attribute/PosixFilePermissions.html#fromString(java.lang.String)))


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@deltaspike.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: some draft for DS-2.0

2021-09-25 Thread Romain Manni-Bucau 
Without feature change I would still prefer the shade/relocation + bom
option instead of 2 branches (recall you didnt maintain your
geronimo-config branches? ;))

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le sam. 25 sept. 2021 à 09:38, Thomas Andraschko <
andraschko.tho...@gmail.com> a écrit :

> Mark, AFAICS you did it in a new main branch instead of master?
> I would move master to 1.9.x branch and do 2.x in master
>
> Why isnt it in GitHub?
>
> Thomas Andraschko  schrieb am Do., 23. Sept.
> 2021, 21:33:
>
> > +1 for making it master
> >
> > Mark Struberg  schrieb am Do., 23. Sept.
> 2021,
> > 20:13:
> >
> >> hi!
> >>
> >> I've migrated a few things over to the jakarta namespace and started
> >> dropping a few old features.
> >> Right now it's just core which I got working, but will now also move
> over
> >> module by module.
> >>
> >> The draft can be viewed here:
> >> https://github.com/struberg/deltaspike/tree/fb_ds20 <
> >> https://github.com/struberg/deltaspike/tree/fb_ds20>
> >> What branch name do we want to give it finally? Take the chance to
> switch
> >> to 'main' and somewhat later rename the master branch to mt_ds1.x?
> >>
> >> How did I proceed?
> >> I did not yet delete anything. Pieces which I do not see as part of
> >> DS-2.0 got moved to an 'obsolete' directory with the same structure. If
> we
> >> figure that we do still want to keep some of the features, then we can
> >> simply move those files back without loosing any history.
> >>
> >> Happ to get feedback!
> >>
> >> LieGrue,
> >> strub
> >>
> >>
> >>
>

Re: some draft for DS-2.0

2021-09-25 Thread Thomas Andraschko 
Mark, AFAICS you did it in a new main branch instead of master?
I would move master to 1.9.x branch and do 2.x in master

Why isnt it in GitHub?

Thomas Andraschko  schrieb am Do., 23. Sept.
2021, 21:33:

> +1 for making it master
>
> Mark Struberg  schrieb am Do., 23. Sept. 2021,
> 20:13:
>
>> hi!
>>
>> I've migrated a few things over to the jakarta namespace and started
>> dropping a few old features.
>> Right now it's just core which I got working, but will now also move over
>> module by module.
>>
>> The draft can be viewed here:
>> https://github.com/struberg/deltaspike/tree/fb_ds20 <
>> https://github.com/struberg/deltaspike/tree/fb_ds20>
>> What branch name do we want to give it finally? Take the chance to switch
>> to 'main' and somewhat later rename the master branch to mt_ds1.x?
>>
>> How did I proceed?
>> I did not yet delete anything. Pieces which I do not see as part of
>> DS-2.0 got moved to an 'obsolete' directory with the same structure. If we
>> figure that we do still want to keep some of the features, then we can
>> simply move those files back without loosing any history.
>>
>> Happ to get feedback!
>>
>> LieGrue,
>> strub
>>
>>
>>