[GitHub] deltaspike pull request: DELTASPIKE-1141 fix EnableInterceptorsTes...
GitHub user manovotn opened a pull request: https://github.com/apache/deltaspike/pull/51 DELTASPIKE-1141 fix EnableInterceptorsTest for CDI 1.0/Weld 1.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/manovotn/deltaspike enableIntercTestFix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 07f5199529a0e2cdb6dfbda20e4b16f060378b84 Author: Matej Novotny <manov...@redhat.com> Date: 2016-05-05T09:58:55Z DELTASPIKE-1141 fix EnableInterceptorsTest for CDI 1.0/Weld 1.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] deltaspike pull request: DELTASPIKE-1141 modify FutureableTest and...
GitHub user manovotn opened a pull request: https://github.com/apache/deltaspike/pull/50 DELTASPIKE-1141 modify FutureableTest and LockedTest to contain beans⦠â¦.xml with relevant interceptors. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manovotn/deltaspike ds1141 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit d2558b7ddf682e41bc829d69bbdafa4927c23887 Author: Matej Novotny <manov...@redhat.com> Date: 2016-05-04T13:07:00Z DELTASPIKE-1141 modify FutureableTest and LockedTest to contain beans.xml with relevant interceptors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...
Github user manovotn commented on a diff in the pull request: https://github.com/apache/deltaspike/pull/49#discussion_r61877744 --- Diff: deltaspike/parent/pom.xml --- @@ -49,7 +49,8 @@ 1.6 1.2.7 -1.1.28.Final + +1.1.9.Final --- End diff -- This is based on a Gerhard's comment. He claimed that the idea is to list the minimal supported version. Although I strongly dislike dislike this approach, I put it here. However if you look into Weld1 profile, you can see it is overriden by current version (1.1.33.Final). So this version declaration is naught but a mere information :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...
GitHub user manovotn opened a pull request: https://github.com/apache/deltaspike/pull/49 DELTASPIKE-1091 add default values to Weld profiles. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manovotn/deltaspike weldProfiles Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/49.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #49 commit 1482edcdc9fa7f7727b1169b74a83766c0d74b58 Author: Matej Novotny <manov...@redhat.com> Date: 2016-05-03T08:04:53Z DELTASPIKE-1091 add default values to Weld profiles. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] deltaspike pull request: DELTASPIKE-1137, created separate profile...
GitHub user manovotn opened a pull request: https://github.com/apache/deltaspike/pull/47 DELTASPIKE-1137, created separate profiles for Weld versions, changed⦠⦠docs accordingly. I created 3 separate profiles for Weld 1/2/3 respectively. As all three profiles have part of their build management/dependencies in common, I took those out and put them into a separate profile (`Weld-common-setup`). `Weld-common-setup` is automatically triggered when you use `-Dweld.version=...` when executing tests (which you do like...all the time? :) ). I couldn't really come up with other solution which would allow to avoid copying this setup into all three profiles. The downside of this is that once you run the tests without `-Dweld.version`, it will not work. Last but not least, I modified docs (`build.adoc` to be more precise) to reflect these changes. Ideas/comments are welcome! You can merge this pull request into a Git repository by running: $ git pull https://github.com/manovotn/deltaspike weldProfileRefactoring Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/47.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #47 commit ae16e7a4c6a3303657fe657c059a5a7da7a9ebbf Author: Matej Novotny <manov...@redhat.com> Date: 2016-04-28T12:15:36Z DELTASPIKE-1137, created separate profiles for Weld versions, changed docs accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
