[GitHub] deltaspike pull request #60: DELTASPIKE-1176 Support void methods in Futurea...
Github user kalgon closed the pull request at: https://github.com/apache/deltaspike/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] deltaspike pull request #60: DELTASPIKE-1176 Support void methods in Futurea...
Github user johnament commented on a diff in the pull request: https://github.com/apache/deltaspike/pull/60#discussion_r72879629 --- Diff: deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/future/DefaultFutureableStrategy.java --- @@ -202,6 +203,13 @@ public Object call() throws Exception }; final ExecutorService pool = getOrCreatePool(ic); + +if (void.class.isAssignableFrom(returnType)) --- End diff -- good to merge then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] deltaspike pull request #60: DELTASPIKE-1176 Support void methods in Futurea...
Github user r-tt commented on a diff in the pull request: https://github.com/apache/deltaspike/pull/60#discussion_r71988266 --- Diff: deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/future/DefaultFutureableStrategy.java --- @@ -202,6 +203,13 @@ public Object call() throws Exception }; final ExecutorService pool = getOrCreatePool(ic); + +if (void.class.isAssignableFrom(returnType)) --- End diff -- think `void` is enough, using Void is a workaround IMO and not a clean programming model we should promote. If we get some feedbacks justifying this we can add it later. Alternative is to add a `Handler` depending the returned type and a kind of SPI but looks overkilled _today_. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] deltaspike pull request #60: DELTASPIKE-1176 Support void methods in Futurea...
Github user johnament commented on a diff in the pull request: https://github.com/apache/deltaspike/pull/60#discussion_r71987310 --- Diff: deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/future/DefaultFutureableStrategy.java --- @@ -202,6 +203,13 @@ public Object call() throws Exception }; final ExecutorService pool = getOrCreatePool(ic); + +if (void.class.isAssignableFrom(returnType)) --- End diff -- Should we also check for `Void` in addition to `void`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
