[jira] [Comment Edited] (DELTASPIKE-577) Test-control: Add delegation of container boot

2014-04-20 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975073#comment-13975073
 ] 

Romain Manni-Bucau edited comment on DELTASPIKE-577 at 4/20/14 7:38 AM:


{code}
${openejb.home}/conf
{code}

Depend surefire config but by default:

{code}
${project.basedir}/conf
{code}

Note: when ignored you have in logs:

{code}
Cannot find the configuration file [conf/openejb.xml].  Will attempt to create 
one for the beans deployed.
{code}

and home is logged too:

{code}
INFO - openejb.home = /xxx/yyy
{code}


was (Author: romain.manni-bucau):
${openejb.home}/conf. Depend surefire config but by default: 
${project.basedir}/conf

Note: when ignored you have in logs:

{code}
Cannot find the configuration file [conf/openejb.xml].  Will attempt to create 
one for the beans deployed.
{code}

and home is logged too:

{code}
INFO - openejb.home = /xxx/yyy
{code}

 Test-control: Add delegation of container boot
 --

 Key: DELTASPIKE-577
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-577
 Project: DeltaSpike
  Issue Type: Improvement
  Components: CdiControl, TestControl
Affects Versions: 0.7
Reporter: Karl Kildén
Priority: Minor

 container.boot(); is used by Test-Control.
   
 This is nice for simple tests with cdictrl-openejb but I think it would be 
 nice to have the possibility to target the boot(Map?, ? properties) that is 
 available for the openejb container. I want Test-Control to delegate to me so 
 I can boot myself.
 I am thinking something like:
 @TestControl(bootDelegate = PropertyAwareEjbBootDelegate.class)
 public interface BootDelegate {
 public void boot(CdiContainer cdiContainer);
 }
 That way tests could be way more dynamic and end users could boot the 
 container in any way they want. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (DELTASPIKE-577) Test-control: Add delegation of container boot

2014-04-19 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974852#comment-13974852
 ] 

Romain Manni-Bucau edited comment on DELTASPIKE-577 at 4/19/14 1:11 PM:


well it is portable but values are not.

I'm +1 to remove it btw if we don't integrate it with cdi runner. Just make it 
highly inconsistent for me.

For me cdi runner should just be a CdiRule to help to handle scopes. Boot is 
generally provided by impl with custom runner/rule


was (Author: romain.manni-bucau):
well it is portable but values are not.

I'm +1 to remove it btw if we don't integrate it with cdi runner. Just make it 
highly inconsistent for me.

For me cdi runner should just be a CdiRule to help to handle scopes. Boot is 
generally 

 Test-control: Add delegation of container boot
 --

 Key: DELTASPIKE-577
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-577
 Project: DeltaSpike
  Issue Type: Improvement
  Components: CdiControl, TestControl
Affects Versions: 0.7
Reporter: Karl Kildén
Assignee: Romain Manni-Bucau
Priority: Minor

 container.boot(); is used by Test-Control.
   
 This is nice for simple tests with cdictrl-openejb but I think it would be 
 nice to have the possibility to target the boot(Map?, ? properties) that is 
 available for the openejb container. I want Test-Control to delegate to me so 
 I can boot myself.
 I am thinking something like:
 @TestControl(bootDelegate = PropertyAwareEjbBootDelegate.class)
 public interface BootDelegate {
 public void boot(CdiContainer cdiContainer);
 }
 That way tests could be way more dynamic and end users could boot the 
 container in any way they want. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)