[jira] [Commented] (DELTASPIKE-1090) ProjectStage config key with just uppercase letters and '_'

[Mark Struberg (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190698#comment-15190698
 ] 

Mark Struberg commented on DELTASPIKE-1090:
---

This generally hits us in the EnvironmentPropertyConfigSource. It needs some 
tricks to export or SET environment variables with dots in, so often they are 
written with underlines.

We could do the replacement generally in the EnvironmentPropertyConfigSource. 
That will be a 3-line change without much impact and would generally help for 
lots of use cases.

> ProjectStage config key with just uppercase letters and '_'
> ---
>
> Key: DELTASPIKE-1090
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1090
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Core
>Reporter: Patrick Suter
>Assignee: Mark Struberg
>Priority: Minor
> Fix For: 1.6.0
>
>
> It would be great to have a key to resolve the ProjectStage that only 
> contains uppercase letters and underscores to ensure it can be overwritten by 
> an environment variable. Have encountered some problems when deploying to 
> Cloud Foundry because a "." is not accepted in the name of an environment 
> variable.
> My suggestions would be to add 'DELTASPIKE_PROJECT_STAGE' to 
> org.apache.deltaspike.core.util.ProjectStageProducer.java:
> {code:title=org.apache.deltaspike.core.util.ProjectStageProducer.java|borderStyle=solid}
> /**
> * These config keys will get used to detect the ProjectStage.
> * We iterate through them until we find the first non-empty value.
> */
> public static final String[] CONFIG_SETTING_KEYS =
> {
> //TODO discuss it
> "org.apache.deltaspike.ProjectStage",
> "javax.faces.PROJECT_STAGE",
> "faces.PROJECT_STAGE",
> "DELTASPIKE_PROJECT_STAGE"
> };
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1090) ProjectStage config key with just uppercase letters and '_'

[Gerhard Petracek (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189097#comment-15189097
 ] 

Gerhard Petracek commented on DELTASPIKE-1090:
--

i tend to move to a more generic approach as illustrated in 
https://gist.github.com/os890/1a1d4ea70fd44853b63f

> ProjectStage config key with just uppercase letters and '_'
> ---
>
> Key: DELTASPIKE-1090
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1090
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Core
>Reporter: Patrick Suter
>Priority: Minor
> Fix For: 1.6.0
>
>
> It would be great to have a key to resolve the ProjectStage that only 
> contains uppercase letters and underscores to ensure it can be overwritten by 
> an environment variable. Have encountered some problems when deploying to 
> Cloud Foundry because a "." is not accepted in the name of an environment 
> variable.
> My suggestions would be to add 'DELTASPIKE_PROJECT_STAGE' to 
> org.apache.deltaspike.core.util.ProjectStageProducer.java:
> {code:title=org.apache.deltaspike.core.util.ProjectStageProducer.java|borderStyle=solid}
> /**
> * These config keys will get used to detect the ProjectStage.
> * We iterate through them until we find the first non-empty value.
> */
> public static final String[] CONFIG_SETTING_KEYS =
> {
> //TODO discuss it
> "org.apache.deltaspike.ProjectStage",
> "javax.faces.PROJECT_STAGE",
> "faces.PROJECT_STAGE",
> "DELTASPIKE_PROJECT_STAGE"
> };
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)