[jira] [Commented] (DELTASPIKE-1129) check portability of context-control
[
https://issues.apache.org/jira/browse/DELTASPIKE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316215#comment-15316215
]
Romain Manni-Bucau commented on DELTASPIKE-1129:
point is there is no guarantee such assumption will work. I really think
session is associated to the request - SE or not - by design so I think current
behavior is the good one.
> check portability of context-control
>
>
> Key: DELTASPIKE-1129
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1129
> Project: DeltaSpike
> Issue Type: Task
> Components: CdiControl
>Affects Versions: 1.6.0
> Environment: owb/tomee7
>Reporter: Gerhard Petracek
>Assignee: Mark Struberg
>
> ContextControl#stopContext(RequestScoped.class) also stops the
> session-context (at least in case of the current snapshot of tomee7) which
> requires the following workaround:
> {code}
> contextControl.stopContext(RequestScoped.class);
> contextControl.startContext(RequestScoped.class);
> contextControl.startContext(SessionScoped.class);
> {code}
> however, such a workaround is not portable.
> without the workaround:
> WebBeans context with scope type annotation @SessionScoped does not exist
> within current thread
> at org.junit.Assert.fail(Assert.java:93)
> at
> org.apache.deltaspike.cdise.tck.ContainerCtrlTckTest.testNewRequests(ContainerCtrlTckTest.java:321)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> see e.g.
> https://builds.apache.org/job/DeltaSpike_TomEE_7.0.0-M3/org.apache.deltaspike.cdictrl$deltaspike-cdictrl-openejb/166/testReport/junit/org.apache.deltaspike.cdise.tck/ContainerCtrlTckTest/testNewRequests/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1129) check portability of context-control
[
https://issues.apache.org/jira/browse/DELTASPIKE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316209#comment-15316209
]
Gerhard Petracek commented on DELTASPIKE-1129:
--
if it gets fixed in owb, i don't agree that we should add a workaround for
tomee 7.0.0.
instead we should fix it asap and release tomee 7.0.1.
since tomee doesn't use owb 1.6.4, users will also get issues with
partial-beans,...
therefore, several ds-users need to wait for tomee 7.0.1 anyway.
all others could use https://github.com/os890/tomee7-control
> check portability of context-control
>
>
> Key: DELTASPIKE-1129
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1129
> Project: DeltaSpike
> Issue Type: Task
> Components: CdiControl
>Affects Versions: 1.6.0
> Environment: owb/tomee7
>Reporter: Gerhard Petracek
>Assignee: Mark Struberg
>
> ContextControl#stopContext(RequestScoped.class) also stops the
> session-context (at least in case of the current snapshot of tomee7) which
> requires the following workaround:
> {code}
> contextControl.stopContext(RequestScoped.class);
> contextControl.startContext(RequestScoped.class);
> contextControl.startContext(SessionScoped.class);
> {code}
> however, such a workaround is not portable.
> without the workaround:
> WebBeans context with scope type annotation @SessionScoped does not exist
> within current thread
> at org.junit.Assert.fail(Assert.java:93)
> at
> org.apache.deltaspike.cdise.tck.ContainerCtrlTckTest.testNewRequests(ContainerCtrlTckTest.java:321)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> see e.g.
> https://builds.apache.org/job/DeltaSpike_TomEE_7.0.0-M3/org.apache.deltaspike.cdictrl$deltaspike-cdictrl-openejb/166/testReport/junit/org.apache.deltaspike.cdise.tck/ContainerCtrlTckTest/testNewRequests/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1129) check portability of context-control
[
https://issues.apache.org/jira/browse/DELTASPIKE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316185#comment-15316185
]
Mark Struberg commented on DELTASPIKE-1129:
---
This is because we do not distinct between 'detach' and 'stop'. If the request
ends in a real webapp, then of course the ThreadLocals holding the other
Contexts also need to get 'detached' (but not stopped of course!).
The original CdiCtrl code was written with JavaSE in mind.
Then another useful use case in EE popped up: to start/attach certain Contexts
in manually started Threads in EE. Remember that this was long before the
(still broken) concurrency-utils spec.
It was however never intended to stop a RequestContext and then continue some
work on the very thread in EE.
It should however work in SE.
> check portability of context-control
>
>
> Key: DELTASPIKE-1129
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1129
> Project: DeltaSpike
> Issue Type: Task
> Components: CdiControl
>Affects Versions: 1.6.0
> Environment: owb/tomee7
>Reporter: Gerhard Petracek
>Assignee: Mark Struberg
>
> ContextControl#stopContext(RequestScoped.class) also stops the
> session-context (at least in case of the current snapshot of tomee7) which
> requires the following workaround:
> {code}
> contextControl.stopContext(RequestScoped.class);
> contextControl.startContext(RequestScoped.class);
> contextControl.startContext(SessionScoped.class);
> {code}
> however, such a workaround is not portable.
> without the workaround:
> WebBeans context with scope type annotation @SessionScoped does not exist
> within current thread
> at org.junit.Assert.fail(Assert.java:93)
> at
> org.apache.deltaspike.cdise.tck.ContainerCtrlTckTest.testNewRequests(ContainerCtrlTckTest.java:321)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> see e.g.
> https://builds.apache.org/job/DeltaSpike_TomEE_7.0.0-M3/org.apache.deltaspike.cdictrl$deltaspike-cdictrl-openejb/166/testReport/junit/org.apache.deltaspike.cdise.tck/ContainerCtrlTckTest/testNewRequests/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1129) check portability of context-control
[
https://issues.apache.org/jira/browse/DELTASPIKE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315957#comment-15315957
]
Romain Manni-Bucau commented on DELTASPIKE-1129:
I think it should be fixed in DS anyway cause tomee 7.0.0 is out + this is a
cdictrl assumption issue and not an impl issue. Could also be a flag on the
controller itself to do it (then impl do noop when not needed)
"requestImplySession" or sthg like that.
> check portability of context-control
>
>
> Key: DELTASPIKE-1129
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1129
> Project: DeltaSpike
> Issue Type: Task
> Components: CdiControl
>Affects Versions: 1.6.0
> Environment: owb/tomee7
>Reporter: Gerhard Petracek
>Assignee: Mark Struberg
>
> ContextControl#stopContext(RequestScoped.class) also stops the
> session-context (at least in case of the current snapshot of tomee7) which
> requires the following workaround:
> {code}
> contextControl.stopContext(RequestScoped.class);
> contextControl.startContext(RequestScoped.class);
> contextControl.startContext(SessionScoped.class);
> {code}
> however, such a workaround is not portable.
> without the workaround:
> WebBeans context with scope type annotation @SessionScoped does not exist
> within current thread
> at org.junit.Assert.fail(Assert.java:93)
> at
> org.apache.deltaspike.cdise.tck.ContainerCtrlTckTest.testNewRequests(ContainerCtrlTckTest.java:321)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> see e.g.
> https://builds.apache.org/job/DeltaSpike_TomEE_7.0.0-M3/org.apache.deltaspike.cdictrl$deltaspike-cdictrl-openejb/166/testReport/junit/org.apache.deltaspike.cdise.tck/ContainerCtrlTckTest/testNewRequests/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1129) check portability of context-control
[
https://issues.apache.org/jira/browse/DELTASPIKE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315512#comment-15315512
]
John D. Ament commented on DELTASPIKE-1129:
---
Should we at least provide some docs on the website indicating the limitation?
Maybe a page with compatibility issues w/ TomEE 7?
> check portability of context-control
>
>
> Key: DELTASPIKE-1129
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1129
> Project: DeltaSpike
> Issue Type: Task
> Components: CdiControl
>Affects Versions: 1.6.0
> Environment: owb/tomee7
>Reporter: Gerhard Petracek
>Assignee: Mark Struberg
>
> ContextControl#stopContext(RequestScoped.class) also stops the
> session-context (at least in case of the current snapshot of tomee7) which
> requires the following workaround:
> {code}
> contextControl.stopContext(RequestScoped.class);
> contextControl.startContext(RequestScoped.class);
> contextControl.startContext(SessionScoped.class);
> {code}
> however, such a workaround is not portable.
> without the workaround:
> WebBeans context with scope type annotation @SessionScoped does not exist
> within current thread
> at org.junit.Assert.fail(Assert.java:93)
> at
> org.apache.deltaspike.cdise.tck.ContainerCtrlTckTest.testNewRequests(ContainerCtrlTckTest.java:321)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> see e.g.
> https://builds.apache.org/job/DeltaSpike_TomEE_7.0.0-M3/org.apache.deltaspike.cdictrl$deltaspike-cdictrl-openejb/166/testReport/junit/org.apache.deltaspike.cdise.tck/ContainerCtrlTckTest/testNewRequests/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1129) check portability of context-control
[
https://issues.apache.org/jira/browse/DELTASPIKE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249723#comment-15249723
]
Romain Manni-Bucau commented on DELTASPIKE-1129:
[~johndament] it affects last OWB and tomee (by inheritance) releases. Real
issue is assumptions done about session scope (= portability is fine for not
web scopes)
> check portability of context-control
>
>
> Key: DELTASPIKE-1129
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1129
> Project: DeltaSpike
> Issue Type: Task
> Components: CdiControl
>Affects Versions: 1.6.0
> Environment: owb/tomee7
>Reporter: Gerhard Petracek
>Assignee: Mark Struberg
> Fix For: 1.6.1
>
> Attachments: DELTASPIKE_1129.patch
>
>
> ContextControl#stopContext(RequestScoped.class) also stops the
> session-context (at least in case of the current snapshot of tomee7) which
> requires the following workaround:
> {code}
> contextControl.stopContext(RequestScoped.class);
> contextControl.startContext(RequestScoped.class);
> contextControl.startContext(SessionScoped.class);
> {code}
> however, such a workaround is not portable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1129) check portability of context-control
[
https://issues.apache.org/jira/browse/DELTASPIKE-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249661#comment-15249661
]
John D. Ament commented on DELTASPIKE-1129:
---
@gerhard does this only happen in TomEE 7 or does it also happen in OWB 1.6.x ?
If its TomEE 7 only, probably not critical since its not released yet...
> check portability of context-control
>
>
> Key: DELTASPIKE-1129
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1129
> Project: DeltaSpike
> Issue Type: Task
> Components: CdiControl
>Affects Versions: 1.6.0
> Environment: owb/tomee7
>Reporter: Gerhard Petracek
>Assignee: Mark Struberg
> Fix For: 1.6.1
>
> Attachments: DELTASPIKE_1129.patch
>
>
> ContextControl#stopContext(RequestScoped.class) also stops the
> session-context (at least in case of the current snapshot of tomee7) which
> requires the following workaround:
> {code}
> contextControl.stopContext(RequestScoped.class);
> contextControl.startContext(RequestScoped.class);
> contextControl.startContext(SessionScoped.class);
> {code}
> however, such a workaround is not portable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
